========== checkpatch - FAILED WARNING: 'atleast' may be misspelled - perhaps 'at least'? #17: atleast need a single CPU to run. ^^^^^^^ WARNING: line length of 81 exceeds 80 columns #38: FILE: arch/x86/net/bpf_jit_comp.c:2609: + /* emiting 5 byte nop for non-inline bpf_loop callback */ WARNING: line length of 99 exceeds 80 columns #39: FILE: arch/x86/net/bpf_jit_comp.c:2610: + if (bpf_is_subprog(bpf_prog) && bpf_prog->aux->is_bpf_loop_cb_non_inline) { WARNING: braces {} are not necessary for single statement blocks #39: FILE: arch/x86/net/bpf_jit_comp.c:2610: + if (bpf_is_subprog(bpf_prog) && bpf_prog->aux->is_bpf_loop_cb_non_inline) { + emit_nops(&prog, X86_PATCH_SIZE); + } CHECK: Please don't use multiple blank lines #49: FILE: arch/x86/net/bpf_jit_comp.c:3840: + WARNING: Missing a blank line after declarations #64: FILE: arch/x86/net/bpf_jit_comp.c:3864: + u8 ret_jmp_size = 1; + if (cpu_wants_rethunk()) { WARNING: braces {} are not necessary for single statement blocks #64: FILE: arch/x86/net/bpf_jit_comp.c:3864: + if (cpu_wants_rethunk()) { + ret_jmp_size = 5; + } WARNING: line length of 87 exceeds 80 columns #68: FILE: arch/x86/net/bpf_jit_comp.c:3868: + for (int i = 0; i < prog->term_states->patch_call_sites->call_sites_cnt; i++) { ERROR: trailing whitespace #69: FILE: arch/x86/net/bpf_jit_comp.c:3869: +^I^I$ CHECK: Blank lines aren't necessary after an open brace '{' #69: FILE: arch/x86/net/bpf_jit_comp.c:3869: + for (int i = 0; i < prog->term_states->patch_call_sites->call_sites_cnt; i++) { + CHECK: No space is necessary after a cast #70: FILE: arch/x86/net/bpf_jit_comp.c:3870: + new_target = (unsigned long) bpf_termination_null_func; WARNING: braces {} are not necessary for single statement blocks #71: FILE: arch/x86/net/bpf_jit_comp.c:3871: + if (call_states[i].is_bpf_loop_cb_inline) { + new_target = (unsigned long) bpf_loop_term_callback; + } ERROR: trailing whitespace #72: FILE: arch/x86/net/bpf_jit_comp.c:3872: +^I^I^Inew_target = (unsigned long) bpf_loop_term_callback;^I$ CHECK: No space is necessary after a cast #72: FILE: arch/x86/net/bpf_jit_comp.c:3872: + new_target = (unsigned long) bpf_loop_term_callback; WARNING: line length of 83 exceeds 80 columns #76: FILE: arch/x86/net/bpf_jit_comp.c:3876: + addr = (unsigned char *)prog->bpf_func + call_states->jit_call_idx; WARNING: line length of 96 exceeds 80 columns #78: FILE: arch/x86/net/bpf_jit_comp.c:3878: + unsigned long new_rel = (unsigned long)(new_target - (unsigned long)(addr + 5)); WARNING: Missing a blank line after declarations #79: FILE: arch/x86/net/bpf_jit_comp.c:3879: + unsigned long new_rel = (unsigned long)(new_target - (unsigned long)(addr + 5)); + new_insn[0] = 0xE8; WARNING: line length of 92 exceeds 80 columns #85: FILE: arch/x86/net/bpf_jit_comp.c:3885: + smp_text_poke_batch_add(addr, new_insn, 5 /* call instruction len */, NULL); ERROR: trailing whitespace #89: FILE: arch/x86/net/bpf_jit_comp.c:3889: +^I^I$ CHECK: Blank lines aren't necessary after an open brace '{' #89: FILE: arch/x86/net/bpf_jit_comp.c:3889: + if (prog->aux->is_bpf_loop_cb_non_inline) { + ERROR: trailing whitespace #92: FILE: arch/x86/net/bpf_jit_comp.c:3892: +^I^Ismp_text_poke_batch_add(prog->bpf_func + prog->jited_len - $ WARNING: Missing a blank line after declarations #92: FILE: arch/x86/net/bpf_jit_comp.c:3892: + char old_insn[5] = { 0x0F, 0x1F, 0x44, 0x00, 0x00 }; + smp_text_poke_batch_add(prog->bpf_func + prog->jited_len - WARNING: line length of 133 exceeds 80 columns #93: FILE: arch/x86/net/bpf_jit_comp.c:3893: + (1 + ret_jmp_size) /* leave, jmp/ ret */ - 5 /* nop size */, new_insn, 5 /* mov eax, 1 */, old_insn); CHECK: Please don't use multiple blank lines #96: FILE: arch/x86/net/bpf_jit_comp.c:3896: + + WARNING: Missing a blank line after declarations #104: FILE: arch/x86/net/bpf_jit_comp.c:3904: + u8 ret_jmp_size = 1; + if (cpu_wants_rethunk()) { WARNING: braces {} are not necessary for single statement blocks #104: FILE: arch/x86/net/bpf_jit_comp.c:3904: + if (cpu_wants_rethunk()) { + ret_jmp_size = 5; + } ERROR: trailing whitespace #111: FILE: arch/x86/net/bpf_jit_comp.c:3911: +^Iunsigned long jmp_offset = prog->jited_len - (4 /* First endbr is 4 bytes */ $ WARNING: line length of 85 exceeds 80 columns #111: FILE: arch/x86/net/bpf_jit_comp.c:3911: + unsigned long jmp_offset = prog->jited_len - (4 /* First endbr is 4 bytes */ ERROR: trailing whitespace #112: FILE: arch/x86/net/bpf_jit_comp.c:3912: +^I^I^I^I^I+ 5 /* noop is 5 bytes */ $ WARNING: line length of 103 exceeds 80 columns #113: FILE: arch/x86/net/bpf_jit_comp.c:3913: + + ret_jmp_size /* 5 bytes of jmp return_thunk or 1 byte ret*/); WARNING: Missing a blank line after declarations #116: FILE: arch/x86/net/bpf_jit_comp.c:3916: + char new_insn[5]; + new_insn[0] = 0xE9; WARNING: braces {} are not necessary for single statement blocks #125: FILE: arch/x86/net/bpf_jit_comp.c:3925: + for (int i = 0; i < prog->aux->func_cnt; i++) { + in_place_patch_bpf_prog(prog->aux->func[i]); + } CHECK: Blank lines aren't necessary before a close brace '}' #132: FILE: arch/x86/net/bpf_jit_comp.c:3932: + +} WARNING: line length of 96 exceeds 80 columns #136: FILE: arch/x86/net/bpf_jit_comp.c:3936: + struct bpf_term_aux_states *term_states = container_of(work, struct bpf_term_aux_states, WARNING: line length of 82 exceeds 80 columns #166: FILE: arch/x86/net/bpf_jit_comp.c:3966: + if (atomic_cmpxchg(&prog->term_states->bpf_die_in_progress, 0, 1)) ERROR: trailing whitespace #168: FILE: arch/x86/net/bpf_jit_comp.c:3968: +^I$ WARNING: line length of 90 exceeds 80 columns #169: FILE: arch/x86/net/bpf_jit_comp.c:3969: + bpf_termination_wq = alloc_workqueue("bpf_termination_wq", WQ_UNBOUND, 1); CHECK: Please don't use multiple blank lines #257: FILE: kernel/bpf/core.c:108: + + WARNING: void function return statements are not generally useful #261: FILE: kernel/bpf/core.c:112: + return; +} WARNING: void function return statements are not generally useful #266: FILE: kernel/bpf/core.c:117: + return; +} WARNING: void function return statements are not generally useful #271: FILE: kernel/bpf/core.c:122: + return; +} WARNING: void function return statements are not generally useful #276: FILE: kernel/bpf/core.c:127: + return; +} WARNING: line length of 83 exceeds 80 columns #313: FILE: kernel/watchdog.c:706: + * So trigger fast path termination to terminate such BPF programs. WARNING: line length of 84 exceeds 80 columns #315: FILE: kernel/watchdog.c:708: + if (time_after_eq(now, period_ts + get_softlockup_thresh() * 3 / 4)) total: 7 errors, 29 warnings, 8 checks, 259 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 1c8e1e3bd11c ("bpf: runtime part of fast-path termination approach") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.