ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.ej71PrcE8a and /tmp/tmp.N6ZeiKQii2 Tree base: c6142e1913de ("Merge branch '10g-qxgmii-for-aqr412c-felix-dsa-and-lynx-pcs-driver'") Now at: 1a1d56f7ff96 ("selftests: net: speed up pmtu.sh by avoiding unnecessary cleanup") ====== Checking before the patch ====== Checking tools/testing/selftests/net/pmtu.sh - 89d38106285ee53bd253d7bc6027d80337b16efedf7ca7ecffc2752800ec6da0 In pmtu.sh line 379: printf " COMMAND: $cmd\n" ^-------------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In pmtu.sh line 384: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In pmtu.sh line 389: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In pmtu.sh line 404: eval echo \$NS_$1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval echo \$NS_"$1" In pmtu.sh line 413: modprobe fou || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: modprobe fou || return "$ksft_skip" In pmtu.sh line 424: modprobe fou6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: modprobe fou6 || return "$ksft_skip" In pmtu.sh line 438: run_cmd ${ns_a} ip fou add port 5555 ipproto ${ipproto} || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip fou add port 5555 ipproto "${ipproto}" || return "$ksft_skip" In pmtu.sh line 439: run_cmd ${ns_a} ip link add ${encap}_a type ${type} ${mode} local ${a_addr} remote ${b_addr} encap ${encap} encap-sport auto encap-dport 5556 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add "${encap}"_a type "${type}" "${mode}" local "${a_addr}" remote "${b_addr}" encap "${encap}" encap-sport auto encap-dport 5556 || return "$ksft_skip" In pmtu.sh line 441: run_cmd ${ns_b} ip fou add port 5556 ipproto ${ipproto} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip fou add port 5556 ipproto "${ipproto}" In pmtu.sh line 442: run_cmd ${ns_b} ip link add ${encap}_b type ${type} ${mode} local ${b_addr} remote ${a_addr} encap ${encap} encap-sport auto encap-dport 5555 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${encap}"_b type "${type}" "${mode}" local "${b_addr}" remote "${a_addr}" encap "${encap}" encap-sport auto encap-dport 5555 In pmtu.sh line 445: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${encap}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${encap}"_a In pmtu.sh line 446: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${encap}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${encap}"_b In pmtu.sh line 448: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${encap}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${encap}"_a In pmtu.sh line 449: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${encap}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${encap}"_b In pmtu.sh line 452: run_cmd ${ns_a} ip link set ${encap}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${encap}"_a up In pmtu.sh line 453: run_cmd ${ns_b} ip link set ${encap}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${encap}"_b up In pmtu.sh line 513: run_cmd ${ns_a} ip link add ip_a type ${type} local ${a_addr} remote ${b_addr} mode ${mode} || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add ip_a type "${type}" local "${a_addr}" remote "${b_addr}" mode "${mode}" || return "$ksft_skip" In pmtu.sh line 514: run_cmd ${ns_b} ip link add ip_b type ${type} local ${b_addr} remote ${a_addr} mode ${mode} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add ip_b type "${type}" local "${b_addr}" remote "${a_addr}" mode "${mode}" In pmtu.sh line 516: run_cmd ${ns_a} ip link set ip_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set ip_a up In pmtu.sh line 517: run_cmd ${ns_b} ip link set ip_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set ip_b up In pmtu.sh line 520: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ip_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev ip_a In pmtu.sh line 521: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ip_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev ip_b In pmtu.sh line 523: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ip_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev ip_a In pmtu.sh line 524: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ip_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev ip_b In pmtu.sh line 546: for n in ${NS_A} ${NS_B} ${NS_C} ${NS_R1} ${NS_R2}; do ^-----^ SC2153 (info): Possible misspelling: NS_A may not be assigned. Did you mean ns_a? ^-----^ SC2153 (info): Possible misspelling: NS_B may not be assigned. Did you mean ns_b? ^-----^ SC2153 (info): Possible misspelling: NS_C may not be assigned. Did you mean ns_c? ^------^ SC2153 (info): Possible misspelling: NS_R1 may not be assigned. Did you mean ns_r1? ^------^ SC2153 (info): Possible misspelling: NS_R2 may not be assigned. Did you mean ns_r2? In pmtu.sh line 549: ip netns exec ${n} sysctl -q net/ipv6/conf/default/accept_dad=0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${n}" sysctl -q net/ipv6/conf/default/accept_dad=0 In pmtu.sh line 559: run_cmd ${ns_a} ip link add veth_a type veth peer name veth_b || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add veth_a type veth peer name veth_b || return 1 In pmtu.sh line 560: run_cmd ${ns_a} ip link set veth_b netns ${NS_B} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_b netns "${NS_B}" In pmtu.sh line 562: run_cmd ${ns_a} ip addr add ${veth4_a_addr}/${veth4_mask} dev veth_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${veth4_a_addr}"/"${veth4_mask}" dev veth_a In pmtu.sh line 563: run_cmd ${ns_b} ip addr add ${veth4_b_addr}/${veth4_mask} dev veth_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${veth4_b_addr}"/"${veth4_mask}" dev veth_b In pmtu.sh line 565: run_cmd ${ns_a} ip addr add ${veth6_a_addr}/${veth6_mask} dev veth_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${veth6_a_addr}"/"${veth6_mask}" dev veth_a In pmtu.sh line 566: run_cmd ${ns_b} ip addr add ${veth6_b_addr}/${veth6_mask} dev veth_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${veth6_b_addr}"/"${veth6_mask}" dev veth_b In pmtu.sh line 568: run_cmd ${ns_a} ip link set veth_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_a up In pmtu.sh line 569: run_cmd ${ns_b} ip link set veth_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set veth_b up In pmtu.sh line 580: [ ${proto} -eq 6 ] && vti_type="vti6" || vti_type="vti" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${proto}" -eq 6 ] && vti_type="vti6" || vti_type="vti" In pmtu.sh line 582: run_cmd ${ns_a} ip link add vti${proto}_a type ${vti_type} local ${veth_a_addr} remote ${veth_b_addr} key 10 || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti"${proto}"_a type "${vti_type}" local "${veth_a_addr}" remote "${veth_b_addr}" key 10 || return 1 In pmtu.sh line 583: run_cmd ${ns_b} ip link add vti${proto}_b type ${vti_type} local ${veth_b_addr} remote ${veth_a_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add vti"${proto}"_b type "${vti_type}" local "${veth_b_addr}" remote "${veth_a_addr}" key 10 In pmtu.sh line 585: run_cmd ${ns_a} ip addr add ${vti_a_addr}/${vti_mask} dev vti${proto}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${vti_a_addr}"/"${vti_mask}" dev vti"${proto}"_a In pmtu.sh line 586: run_cmd ${ns_b} ip addr add ${vti_b_addr}/${vti_mask} dev vti${proto}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${vti_b_addr}"/"${vti_mask}" dev vti"${proto}"_b In pmtu.sh line 588: run_cmd ${ns_a} ip link set vti${proto}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti"${proto}"_a up In pmtu.sh line 589: run_cmd ${ns_b} ip link set vti${proto}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set vti"${proto}"_b up In pmtu.sh line 593: setup_vti 4 ${veth4_a_addr} ${veth4_b_addr} ${tunnel4_a_addr} ${tunnel4_b_addr} ${tunnel4_mask} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 4 "${veth4_a_addr}" "${veth4_b_addr}" "${tunnel4_a_addr}" "${tunnel4_b_addr}" "${tunnel4_mask}" In pmtu.sh line 597: setup_vti 6 ${veth6_a_addr} ${veth6_b_addr} ${tunnel6_a_addr} ${tunnel6_b_addr} ${tunnel6_mask} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 6 "${veth6_a_addr}" "${veth6_b_addr}" "${tunnel6_a_addr}" "${tunnel6_b_addr}" "${tunnel6_mask}" In pmtu.sh line 601: setup_vti 4 ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ${tunnel4_a_addr} ${tunnel4_b_addr} ${tunnel4_mask} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 4 "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "${tunnel4_a_addr}" "${tunnel4_b_addr}" "${tunnel4_mask}" In pmtu.sh line 605: setup_vti 6 ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ${tunnel6_a_addr} ${tunnel6_b_addr} ${tunnel6_mask} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 6 "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "${tunnel6_a_addr}" "${tunnel6_b_addr}" "${tunnel6_mask}" In pmtu.sh line 624: run_cmd ${ns_a} ip link add ${type}_a type ${type} id 1 ${opts_a} remote ${b_addr} ${opts} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add "${type}"_a type "${type}" id 1 "${opts_a}" remote "${b_addr}" "${opts}" || return 1 In pmtu.sh line 625: run_cmd ${ns_b} ip link add ${type}_b type ${type} id 1 ${opts_b} remote ${a_addr} ${opts} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${type}"_b type "${type}" id 1 "${opts_b}" remote "${a_addr}" "${opts}" In pmtu.sh line 628: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${br_if_a}" In pmtu.sh line 629: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${br_if_a}" In pmtu.sh line 630: run_cmd ${ns_a} ip link set ${type}_a master ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${type}"_a master "${br_if_a}" In pmtu.sh line 632: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${type}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${type}"_a In pmtu.sh line 633: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${type}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${type}"_a In pmtu.sh line 636: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${type}"_b In pmtu.sh line 637: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${type}"_b In pmtu.sh line 639: run_cmd ${ns_a} ip link set ${type}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${type}"_a up In pmtu.sh line 640: run_cmd ${ns_b} ip link set ${type}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${type}"_b up In pmtu.sh line 644: setup_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" In pmtu.sh line 648: setup_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" In pmtu.sh line 652: setup_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" In pmtu.sh line 656: setup_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" In pmtu.sh line 660: setup_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" "br0" In pmtu.sh line 664: setup_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" "br0" In pmtu.sh line 668: setup_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" "br0" In pmtu.sh line 672: setup_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" "br0" In pmtu.sh line 681: run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm state add src "${veth_a_addr}" dst "${veth_b_addr}" spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" || return 1 In pmtu.sh line 682: run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm state add src "${veth_b_addr}" dst "${veth_a_addr}" spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 683: run_cmd ${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm policy add dir out mark 10 tmpl src "${veth_a_addr}" dst "${veth_b_addr}" proto esp mode tunnel In pmtu.sh line 684: run_cmd ${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm policy add dir in mark 10 tmpl src "${veth_b_addr}" dst "${veth_a_addr}" proto esp mode tunnel In pmtu.sh line 686: run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm state add src "${veth_a_addr}" dst "${veth_b_addr}" spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 687: run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm state add src "${veth_b_addr}" dst "${veth_a_addr}" spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 688: run_cmd ${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm policy add dir out mark 10 tmpl src "${veth_b_addr}" dst "${veth_a_addr}" proto esp mode tunnel In pmtu.sh line 689: run_cmd ${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm policy add dir in mark 10 tmpl src "${veth_a_addr}" dst "${veth_b_addr}" proto esp mode tunnel In pmtu.sh line 695: [ ${1} -eq 6 ] && proto="-6" || proto="" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${1}" -eq 6 ] && proto="-6" || proto="" In pmtu.sh line 706: setup_xfrm 4 ${veth4_a_addr} ${veth4_b_addr} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${veth4_a_addr}" "${veth4_b_addr}" In pmtu.sh line 710: setup_xfrm 6 ${veth6_a_addr} ${veth6_b_addr} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${veth6_a_addr}" "${veth6_b_addr}" In pmtu.sh line 714: setup_xfrm 4 ${veth4_a_addr} ${veth4_b_addr} "encap espinudp 4500 4500 0.0.0.0" && \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${veth4_a_addr}" "${veth4_b_addr}" "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 719: setup_xfrm 6 ${veth6_a_addr} ${veth6_b_addr} "encap espinudp 4500 4500 0.0.0.0" && \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${veth6_a_addr}" "${veth6_b_addr}" "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 724: setup_xfrm 4 ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "encap espinudp 4500 4500 0.0.0.0" && \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 729: setup_xfrm 6 ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "encap espinudp 4500 4500 0.0.0.0" && \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 739: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 755: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 757: ip -n ${ns_name} -${fam} nexthop add id ${nhid} via ${gw} dev ${dev} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" -"${fam}" nexthop add id "${nhid}" via "${gw}" dev "${dev}" In pmtu.sh line 769: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 779: ip netns exec ${i} sysctl -q net/ipv4/ip_forward=1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${i}" sysctl -q net/ipv4/ip_forward=1 In pmtu.sh line 780: ip netns exec ${i} sysctl -q net/ipv6/conf/all/forwarding=1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${i}" sysctl -q net/ipv6/conf/all/forwarding=1 In pmtu.sh line 788: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 789: peer_name="$(nsname ${peer})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: peer_name="$(nsname "${peer}")" In pmtu.sh line 794: ip link add ${if} up netns ${ns_name} type veth peer name ${ifpeer} netns ${peer_name} || return 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "${if}" up netns "${ns_name}" type veth peer name "${ifpeer}" netns "${peer_name}" || return 1 In pmtu.sh line 795: ip -n ${peer_name} link set dev ${ifpeer} up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" link set dev "${ifpeer}" up In pmtu.sh line 798: ip -n ${ns_name} addr add ${prefix4}.${segment}.1/24 dev ${if} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" addr add "${prefix4}"."${segment}".1/24 dev "${if}" In pmtu.sh line 799: ip -n ${ns_name} addr add ${prefix6}:${segment}::1/64 dev ${if} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" addr add "${prefix6}":"${segment}"::1/64 dev "${if}" In pmtu.sh line 801: ip -n ${peer_name} addr add ${prefix4}.${segment}.2/24 dev ${ifpeer} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" addr add "${prefix4}"."${segment}".2/24 dev "${ifpeer}" In pmtu.sh line 802: ip -n ${peer_name} addr add ${prefix6}:${segment}::2/64 dev ${ifpeer} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" addr add "${prefix6}":"${segment}"::2/64 dev "${ifpeer}" In pmtu.sh line 835: run_cmd ${ns_a} ip link add br0 type bridge || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add br0 type bridge || return "$ksft_skip" In pmtu.sh line 836: run_cmd ${ns_a} ip link set br0 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set br0 up In pmtu.sh line 838: run_cmd ${ns_c} ip link add veth_C-A type veth peer name veth_A-C ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link add veth_C-A type veth peer name veth_A-C In pmtu.sh line 839: run_cmd ${ns_c} ip link set veth_A-C netns ${NS_A} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_A-C netns "${NS_A}" In pmtu.sh line 841: run_cmd ${ns_a} ip link set veth_A-C up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-C up In pmtu.sh line 842: run_cmd ${ns_c} ip link set veth_C-A up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_C-A up In pmtu.sh line 843: run_cmd ${ns_c} ip addr add ${veth4_c_addr}/${veth4_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth4_c_addr}"/"${veth4_mask}" dev veth_C-A In pmtu.sh line 844: run_cmd ${ns_c} ip addr add ${veth6_c_addr}/${veth6_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth6_c_addr}"/"${veth6_mask}" dev veth_C-A In pmtu.sh line 845: run_cmd ${ns_a} ip link set veth_A-C master br0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-C master br0 In pmtu.sh line 854: run_cmd python3 ./openvswitch/ovs-dpctl.py add-if ovs_br0 ${type}_a -t ${type} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd python3 ./openvswitch/ovs-dpctl.py add-if ovs_br0 "${type}"_a -t "${type}" || return 1 In pmtu.sh line 857: br0_port=$(echo "$ports" | grep -E "\sovs_br0" | sed -e 's@port @@' | cut -d: -f1 | xargs) ^------^ SC2034 (warning): br0_port appears unused. Verify use (or export if used externally). In pmtu.sh line 858: type_a_port=$(echo "$ports" | grep ${type}_a | sed -e 's@port @@' | cut -d: -f1 | xargs) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: type_a_port=$(echo "$ports" | grep "${type}"_a | sed -e 's@port @@' | cut -d: -f1 | xargs) In pmtu.sh line 912: run_cmd ovs-vsctl add-port ovs_br0 ${type}_a -- \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ovs-vsctl add-port ovs_br0 "${type}"_a -- \ In pmtu.sh line 913: set interface ${type}_a type=${type} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: set interface "${type}"_a type="${type}" \ In pmtu.sh line 914: options:remote_ip=${b_addr} options:key=1 options:csum=true || return 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: options:remote_ip="${b_addr}" options:key=1 options:csum=true || return 1 In pmtu.sh line 933: run_cmd ${ns_b} ip link add ${type}_b type ${type} id 1 ${opts_b} remote ${a_addr} ${opts} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${type}"_b type "${type}" id 1 "${opts_b}" remote "${a_addr}" "${opts}" || return 1 In pmtu.sh line 935: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${type}"_b In pmtu.sh line 936: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${type}"_b In pmtu.sh line 938: run_cmd ip link set ${type}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "${type}"_a up In pmtu.sh line 939: run_cmd ${ns_b} ip link set ${type}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${type}"_b up In pmtu.sh line 943: setup_ovs_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 In pmtu.sh line 947: setup_ovs_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 In pmtu.sh line 951: setup_ovs_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 In pmtu.sh line 955: setup_ovs_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 In pmtu.sh line 975: setup_ovs_br_internal || setup_ovs_br_vswitchd || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_br_internal || setup_ovs_br_vswitchd || return "$ksft_skip" In pmtu.sh line 978: run_cmd ${ns_c} ip link add veth_C-A type veth peer name veth_A-C ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link add veth_C-A type veth peer name veth_A-C In pmtu.sh line 979: run_cmd ${ns_c} ip link set veth_A-C netns 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_A-C netns 1 In pmtu.sh line 982: run_cmd ${ns_c} ip link set veth_C-A up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_C-A up In pmtu.sh line 983: run_cmd ${ns_c} ip addr add ${veth4_c_addr}/${veth4_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth4_c_addr}"/"${veth4_mask}" dev veth_C-A In pmtu.sh line 984: run_cmd ${ns_c} ip addr add ${veth6_c_addr}/${veth6_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth6_c_addr}"/"${veth6_mask}" dev veth_C-A In pmtu.sh line 988: run_cmd ${ns_a} ip link set veth_A-R1 netns 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-R1 netns 1 In pmtu.sh line 989: run_cmd ip addr add ${prefix4}.${a_r1}.1/${veth4_mask} dev veth_A-R1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add "${prefix4}"."${a_r1}".1/"${veth4_mask}" dev veth_A-R1 In pmtu.sh line 990: run_cmd ip addr add ${prefix6}:${a_r1}::1/${veth6_mask} dev veth_A-R1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add "${prefix6}":"${a_r1}"::1/"${veth6_mask}" dev veth_A-R1 In pmtu.sh line 992: run_cmd ip route add ${prefix4}.${b_r1}.1 via ${prefix4}.${a_r1}.2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add "${prefix4}"."${b_r1}".1 via "${prefix4}"."${a_r1}".2 In pmtu.sh line 993: run_cmd ip route add ${prefix6}:${b_r1}::1 via ${prefix6}:${a_r1}::2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add "${prefix6}":"${b_r1}"::1 via "${prefix6}":"${a_r1}"::2 In pmtu.sh line 998: run_cmd ${ns_a} ip addr add ${host4_a_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${host4_a_addr}" dev lo In pmtu.sh line 999: run_cmd ${ns_a} ip nexthop add id 401 via ${prefix4}.${a_r1}.2 dev veth_A-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 401 via "${prefix4}"."${a_r1}".2 dev veth_A-R1 In pmtu.sh line 1000: run_cmd ${ns_a} ip nexthop add id 402 via ${prefix4}.${a_r2}.2 dev veth_A-R2 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 402 via "${prefix4}"."${a_r2}".2 dev veth_A-R2 In pmtu.sh line 1001: run_cmd ${ns_a} ip nexthop add id 403 group 401/402 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 403 group 401/402 In pmtu.sh line 1002: run_cmd ${ns_a} ip route add ${host4_b_addr} src ${host4_a_addr} nhid 403 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route add "${host4_b_addr}" src "${host4_a_addr}" nhid 403 In pmtu.sh line 1005: run_cmd ${ns_b} ip addr add ${host4_b_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${host4_b_addr}" dev lo In pmtu.sh line 1006: run_cmd ${ns_b} ip nexthop add id 401 via ${prefix4}.${b_r1}.2 dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 401 via "${prefix4}"."${b_r1}".2 dev veth_B-R1 In pmtu.sh line 1007: run_cmd ${ns_b} ip nexthop add id 402 via ${prefix4}.${b_r2}.2 dev veth_B-R2 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 402 via "${prefix4}"."${b_r2}".2 dev veth_B-R2 In pmtu.sh line 1008: run_cmd ${ns_b} ip nexthop add id 403 group 401/402 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 403 group 401/402 In pmtu.sh line 1009: run_cmd ${ns_b} ip route add ${host4_a_addr} src ${host4_b_addr} nhid 403 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route add "${host4_a_addr}" src "${host4_b_addr}" nhid 403 In pmtu.sh line 1014: run_cmd ${ns_a} ip addr add ${host4_a_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${host4_a_addr}" dev lo In pmtu.sh line 1015: run_cmd ${ns_a} ip route add ${host4_b_addr} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route add "${host4_b_addr}" \ In pmtu.sh line 1016: src ${host4_a_addr} \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src "${host4_a_addr}" \ In pmtu.sh line 1017: nexthop via ${prefix4}.${a_r1}.2 weight 1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${a_r1}".2 weight 1 \ In pmtu.sh line 1018: nexthop via ${prefix4}.${a_r2}.2 weight 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${a_r2}".2 weight 1 In pmtu.sh line 1021: run_cmd ${ns_b} ip addr add ${host4_b_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${host4_b_addr}" dev lo In pmtu.sh line 1022: run_cmd ${ns_b} ip route add ${host4_a_addr} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route add "${host4_a_addr}" \ In pmtu.sh line 1023: src ${host4_b_addr} \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src "${host4_b_addr}" \ In pmtu.sh line 1024: nexthop via ${prefix4}.${b_r1}.2 weight 1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${b_r1}".2 weight 1 \ In pmtu.sh line 1025: nexthop via ${prefix4}.${b_r2}.2 weight 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${b_r2}".2 weight 1 In pmtu.sh line 1036: run_cmd ${ns_r1} ip route add ${host4_a_addr} via ${prefix4}.${a_r1}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r1}" ip route add "${host4_a_addr}" via "${prefix4}"."${a_r1}".1 In pmtu.sh line 1037: run_cmd ${ns_r2} ip route add ${host4_a_addr} via ${prefix4}.${a_r2}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r2}" ip route add "${host4_a_addr}" via "${prefix4}"."${a_r2}".1 In pmtu.sh line 1038: run_cmd ${ns_r1} ip route add ${host4_b_addr} via ${prefix4}.${b_r1}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r1}" ip route add "${host4_b_addr}" via "${prefix4}"."${b_r1}".1 In pmtu.sh line 1039: run_cmd ${ns_r2} ip route add ${host4_b_addr} via ${prefix4}.${b_r2}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r2}" ip route add "${host4_b_addr}" via "${prefix4}"."${b_r2}".1 In pmtu.sh line 1043: [ "$(id -u)" -ne 0 ] && echo " need to run as root" && return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$(id -u)" -ne 0 ] && echo " need to run as root" && return "$ksft_skip" In pmtu.sh line 1046: eval setup_${arg} || { echo " ${arg} not supported"; return 1; } ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval setup_"${arg}" || { echo " ${arg} not supported"; return 1; } In pmtu.sh line 1051: [ $TRACING -eq 0 ] && return ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$TRACING" -eq 0 ] && return In pmtu.sh line 1076: kill ${pid} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "${pid}" In pmtu.sh line 1081: kill ${pid} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "${pid}" In pmtu.sh line 1104: ${ns_cmd} ip link set dev ${dev} mtu ${mtu} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${ns_cmd} ip link set dev "${dev}" mtu "${mtu}" In pmtu.sh line 1112: [ ${next} -eq 1 -a "${i}" = "lock" ] && next=2 && continue ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. Did you mean: [ "${next}" -eq 1 -a "${i}" = "lock" ] && next=2 && continue In pmtu.sh line 1113: [ ${next} -eq 1 ] && echo "${i}" && return ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${next}" -eq 1 ] && echo "${i}" && return In pmtu.sh line 1114: [ ${next} -eq 2 ] && echo "lock ${i}" && return ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${next}" -eq 2 ] && echo "lock ${i}" && return In pmtu.sh line 1130: mtu_parse "$(link_get "${ns_cmd}" ${name})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_parse "$(link_get "${ns_cmd}" "${name}")" In pmtu.sh line 1161: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 1167: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1189: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst1} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst1}" In pmtu.sh line 1190: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 1193: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1195: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1201: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1204: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1210: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1213: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1217: [ $family -eq 6 ] && return 0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$family" -eq 6 ] && return 0 In pmtu.sh line 1222: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1400 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1400 "${dst2}" In pmtu.sh line 1223: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1229: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1235: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1239: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1400 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1400 "${dst2}" In pmtu.sh line 1240: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1255: setup namespaces policy_routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces policy_routing || return "$ksft_skip" In pmtu.sh line 1297: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In pmtu.sh line 1300: setup namespaces policy_routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces policy_routing || return "$ksft_skip" In pmtu.sh line 1347: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1348: setup namespaces routing ${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${type}"4 || return "$ksft_skip" In pmtu.sh line 1350: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1352: setup namespaces routing ${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${type}"6 || return "$ksft_skip" In pmtu.sh line 1354: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1357: trace "${ns_a}" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1361: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1370: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1371: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1372: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1373: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1375: mtu "${ns_a}" ${type}_a $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${type}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1376: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1377: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1380: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1381: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ${type} interface" In pmtu.sh line 1422: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1423: setup namespaces routing bridge bridged_${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing bridge bridged_"${type}"4 || return "$ksft_skip" In pmtu.sh line 1425: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1427: setup namespaces routing bridge bridged_${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing bridge bridged_"${type}"6 || return "$ksft_skip" In pmtu.sh line 1429: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1432: trace "${ns_a}" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1438: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1447: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1448: mtu "${ns_a}" br0 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1449: mtu "${ns_a}" veth_A-C $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1450: mtu "${ns_c}" veth_C-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1451: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1452: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1453: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1455: mtu "${ns_a}" ${type}_a $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${type}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1456: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1458: run_cmd ${ns_c} ${ping} -q -M want -i 0.1 -c 10 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" "${ping}" -q -M want -i 0.1 -c 10 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1459: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1462: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1463: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on bridged ${type} interface" In pmtu.sh line 1464: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1465: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on locally bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on locally bridged ${type} interface" In pmtu.sh line 1470: run_cmd ${ns_a} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route flush cached "${dst}" In pmtu.sh line 1471: run_cmd ${ns_b} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route flush cached "${dst}" In pmtu.sh line 1472: run_cmd ${ns_c} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip route flush cached "${dst}" In pmtu.sh line 1475: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1480: ${ns_b} socat -T 3 -u -6 TCP-LISTEN:50000,reuseaddr STDOUT > $tmpoutfile & ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${ns_b} socat -T 3 -u -6 TCP-LISTEN:50000,reuseaddr STDOUT > "$tmpoutfile" & In pmtu.sh line 1483: wait_local_port_listen ${NS_B} 50000 tcp ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_local_port_listen "${NS_B}" 50000 tcp In pmtu.sh line 1485: dd if=/dev/zero status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN $TCPDST,connect-timeout=3 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dd if=/dev/zero status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN "$TCPDST",connect-timeout=3 In pmtu.sh line 1487: wait ${socat_pid} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait "${socat_pid}" In pmtu.sh line 1488: size=$(du -sb $tmpoutfile) ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: size=$(du -sb "$tmpoutfile") In pmtu.sh line 1491: [ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$size" -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1 In pmtu.sh line 1497: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1498: check_pmtu_value ${exp_mtu} "${pmtu}" "tcp: exceeding link layer MTU on bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "tcp: exceeding link layer MTU on bridged ${type} interface" In pmtu.sh line 1499: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1500: check_pmtu_value ${exp_mtu} "${pmtu}" "tcp exceeding link layer MTU on locally bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "tcp exceeding link layer MTU on locally bridged ${type} interface" In pmtu.sh line 1547: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1548: setup namespaces routing ovs_bridge ovs_${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ovs_bridge ovs_"${type}"4 || return "$ksft_skip" In pmtu.sh line 1550: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1552: setup namespaces routing ovs_bridge ovs_${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ovs_bridge ovs_"${type}"6 || return "$ksft_skip" In pmtu.sh line 1554: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1557: trace "" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1563: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1572: mtu "" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1573: mtu "" ovs_br0 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1574: mtu "" veth_A-C $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1575: mtu "${ns_c}" veth_C-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1576: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1577: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1578: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1580: mtu "" ${tun_a} $((${ll_mtu} + 1000)) 2>/dev/null || \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "" "${tun_a}" $((${ll_mtu} + 1000)) 2>/dev/null || \ In pmtu.sh line 1581: mtu "" ${type}_a $((${ll_mtu} + 1000)) 2>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "" "${type}"_a $((${ll_mtu} + 1000)) 2>/dev/null In pmtu.sh line 1582: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1584: run_cmd ${ns_c} ${ping} -q -M want -i 0.1 -c 20 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" "${ping}" -q -M want -i 0.1 -c 20 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1587: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1588: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on Open vSwitch ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on Open vSwitch ${type} interface" In pmtu.sh line 1629: setup namespaces routing ${encap}${outer_family}${inner_family} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${encap}""${outer_family}""${inner_family}" || return "$ksft_skip" In pmtu.sh line 1630: trace "${ns_a}" ${encap}_a "${ns_b}" ${encap}_b \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${encap}"_a "${ns_b}" "${encap}"_b \ In pmtu.sh line 1634: if [ ${inner_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${inner_family}" -eq 4 ]; then In pmtu.sh line 1648: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1650: exp_mtu=$((${ll_mtu} - 20 - 8 - ${encap_overhead})) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1653: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - ${encap_overhead})) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1657: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1658: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1659: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1660: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1662: mtu "${ns_a}" ${encap}_a $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${encap}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1663: mtu "${ns_b}" ${encap}_b $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${encap}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1664: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1667: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1668: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ${encap} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ${encap} interface" In pmtu.sh line 1708: setup namespaces routing ip${inner}ip${outer} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ip"${inner}"ip"${outer}" || return "$ksft_skip" In pmtu.sh line 1714: if [ ${inner} -eq 4 ]; then ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${inner}" -eq 4 ]; then In pmtu.sh line 1722: if [ ${outer} -eq 4 ]; then ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer}" -eq 4 ]; then In pmtu.sh line 1724: exp_mtu=$((${ll_mtu} - 20)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1727: exp_mtu=$((${ll_mtu} - 40 - 8)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1731: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1732: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1733: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1734: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1736: mtu "${ns_a}" ip_a $((${ll_mtu} + 1000)) || return ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1737: mtu "${ns_b}" ip_b $((${ll_mtu} + 1000)) || return ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1738: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1741: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1742: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ip${inner}ip${outer} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ip${inner}ip${outer} interface" In pmtu.sh line 1762: setup namespaces veth vti4 xfrm4 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 xfrm4 || return "$ksft_skip" In pmtu.sh line 1773: mtu "${ns_a}" veth_a ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_a "${veth_mtu}" In pmtu.sh line 1774: mtu "${ns_b}" veth_b ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_b "${veth_mtu}" In pmtu.sh line 1775: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1776: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1780: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1781: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1786: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) "${tunnel4_b_addr}" In pmtu.sh line 1787: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1792: setup namespaces veth vti6 xfrm6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 xfrm6 || return "$ksft_skip" In pmtu.sh line 1802: run_cmd ${ns_a} ${ping6} -q -i 0.1 -w 1 -s 60000 ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -i 0.1 -w 1 -s 60000 "${tunnel6_b_addr}" In pmtu.sh line 1805: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1810: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1815: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1818: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 1822: setup namespaces veth vti4 xfrm4udp || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 xfrm4udp || return "$ksft_skip" In pmtu.sh line 1833: mtu "${ns_a}" veth_a ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_a "${veth_mtu}" In pmtu.sh line 1834: mtu "${ns_b}" veth_b ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_b "${veth_mtu}" In pmtu.sh line 1835: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1836: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1840: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1841: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1846: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) "${tunnel4_b_addr}" In pmtu.sh line 1847: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1852: setup namespaces veth vti6 xfrm6udp || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 xfrm6udp || return "$ksft_skip" In pmtu.sh line 1862: run_cmd ${ns_a} ${ping6} -q -i 0.1 -w 1 -s 60000 ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -i 0.1 -w 1 -s 60000 "${tunnel6_b_addr}" In pmtu.sh line 1865: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1870: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1875: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1878: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 1882: setup namespaces routing vti4routed xfrm4udprouted || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing vti4routed xfrm4udprouted || return "$ksft_skip" In pmtu.sh line 1893: mtu "${ns_a}" veth_A-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_A-R1 "${veth_mtu}" In pmtu.sh line 1894: mtu "${ns_r1}" veth_R1-A ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-A "${veth_mtu}" In pmtu.sh line 1895: mtu "${ns_b}" veth_B-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${veth_mtu}" In pmtu.sh line 1896: mtu "${ns_r1}" veth_R1-B ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${veth_mtu}" In pmtu.sh line 1898: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1899: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1903: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1904: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1910: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload)) "${tunnel4_b_addr}" In pmtu.sh line 1911: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1916: setup namespaces routing vti6routed xfrm6udprouted || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing vti6routed xfrm6udprouted || return "$ksft_skip" In pmtu.sh line 1927: mtu "${ns_a}" veth_A-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_A-R1 "${veth_mtu}" In pmtu.sh line 1928: mtu "${ns_r1}" veth_R1-A ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-A "${veth_mtu}" In pmtu.sh line 1929: mtu "${ns_b}" veth_B-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${veth_mtu}" In pmtu.sh line 1930: mtu "${ns_r1}" veth_R1-B ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${veth_mtu}" In pmtu.sh line 1935: run_cmd ${ns_a} ${ping6} -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel6_b_addr}" In pmtu.sh line 1938: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1944: run_cmd ${ns_a} ${ping6} -q -M want -i 0.1 -w 1 -s $((ping_payload)) ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -M want -i 0.1 -w 1 -s $((ping_payload)) "${tunnel6_b_addr}" In pmtu.sh line 1945: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1951: setup namespaces veth vti4 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 || return "$ksft_skip" In pmtu.sh line 1963: setup namespaces veth vti6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 || return "$ksft_skip" In pmtu.sh line 1975: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 1977: run_cmd ${ns_a} ip link add vti4_a type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 1978: [ $? -ne 0 ] && err " vti not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " vti not supported" && return "$ksft_skip" In pmtu.sh line 1979: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 1987: run_cmd ${ns_a} ip link add vti4_a mtu ${v} type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a mtu "${v}" type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 1989: [ $? -ne 0 ] && continue ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In pmtu.sh line 1991: if [ ${mtu} -lt ${min} -o ${mtu} -gt ${max} ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -lt "${min}" -o "${mtu}" -gt "${max}" ]; then In pmtu.sh line 1995: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 2000: run_cmd ${ns_a} ip link add vti4_a mtu ${v} type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a mtu "${v}" type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 2002: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 2009: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2013: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 2015: run_cmd ${ns_a} ip link add vti6_a type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2016: [ $? -ne 0 ] && err " vti6 not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " vti6 not supported" && return "$ksft_skip" In pmtu.sh line 2017: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2025: run_cmd ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu "${v}" type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2027: [ $? -ne 0 ] && continue ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In pmtu.sh line 2029: if [ ${mtu} -lt ${min} -o ${mtu} -gt ${max} ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -lt "${min}" -o "${mtu}" -gt "${max}" ]; then In pmtu.sh line 2033: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2038: run_cmd ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu "${v}" type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2040: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2047: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2051: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 2053: run_cmd ${ns_a} ip link add dummy0 mtu 1500 type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add dummy0 mtu 1500 type dummy In pmtu.sh line 2054: [ $? -ne 0 ] && err " dummy not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " dummy not supported" && return "$ksft_skip" In pmtu.sh line 2055: run_cmd ${ns_a} ip link add dummy1 mtu 3000 type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add dummy1 mtu 3000 type dummy In pmtu.sh line 2056: run_cmd ${ns_a} ip link set dummy0 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set dummy0 up In pmtu.sh line 2057: run_cmd ${ns_a} ip link set dummy1 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set dummy1 up In pmtu.sh line 2059: run_cmd ${ns_a} ip addr add ${dummy6_0_prefix}1/${dummy6_mask} dev dummy0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${dummy6_0_prefix}"1/"${dummy6_mask}" dev dummy0 In pmtu.sh line 2060: run_cmd ${ns_a} ip addr add ${dummy6_1_prefix}1/${dummy6_mask} dev dummy1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${dummy6_1_prefix}"1/"${dummy6_mask}" dev dummy1 In pmtu.sh line 2065: run_cmd ${ns_a} ip link add vti6_a mtu 1300 type vti6 remote ${dummy6_0_prefix}2 local ${dummy6_0_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu 1300 type vti6 remote "${dummy6_0_prefix}"2 local "${dummy6_0_prefix}"1 In pmtu.sh line 2067: if [ ${mtu} -ne 1300 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne 1300 ]; then In pmtu.sh line 2074: run_cmd ${ns_a} ip link set vti6_a type vti6 remote ${dummy6_1_prefix}2 local ${dummy6_1_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti6_a type vti6 remote "${dummy6_1_prefix}"2 local "${dummy6_1_prefix}"1 In pmtu.sh line 2076: if [ ${mtu} -ne $((3000 - 40)) ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne $((3000 - 40)) ]; then In pmtu.sh line 2082: run_cmd ${ns_a} ip link set vti6_a mtu 1280 type vti6 remote ${dummy6_0_prefix}2 local ${dummy6_0_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti6_a mtu 1280 type vti6 remote "${dummy6_0_prefix}"2 local "${dummy6_0_prefix}"1 In pmtu.sh line 2084: if [ ${mtu} -ne 1280 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne 1280 ]; then In pmtu.sh line 2089: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2095: if ! which ${cmd} > /dev/null 2>&1; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ! which "${cmd}" > /dev/null 2>&1; then In pmtu.sh line 2106: [ "$(cat /proc/${pid}/cmdline 2>/dev/null | tr -d '\0')" = "${cmd}" ] ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$(cat /proc/"${pid}"/cmdline 2>/dev/null | tr -d '\0')" = "${cmd}" ] In pmtu.sh line 2114: check_command taskset || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_command taskset || return "$ksft_skip" In pmtu.sh line 2117: setup namespaces routing ${encap}${outer} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${encap}""${outer}" || return "$ksft_skip" In pmtu.sh line 2118: trace "${ns_a}" ${encap}_a "${ns_b}" ${encap}_b \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${encap}"_a "${ns_b}" "${encap}"_b \ In pmtu.sh line 2123: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2124: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2125: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 2126: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 2128: mtu "${ns_a}" ${encap}_a $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${encap}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 2129: mtu "${ns_b}" ${encap}_b $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${encap}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 2134: run_cmd taskset --cpu-list ${cpu} ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${tunnel4_b_addr} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd taskset --cpu-list "${cpu}" "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${tunnel4_b_addr}" In pmtu.sh line 2140: check_running ${iplink_pid} "iplinkdeldevveth_A-R1" || return 0 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_running "${iplink_pid}" "iplinkdeldevveth_A-R1" || return 0 In pmtu.sh line 2170: eval test_${tname} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval test_"${tname}" In pmtu.sh line 2180: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In pmtu.sh line 2197: $ksft_skip) ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob. In pmtu.sh line 2219: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 2243: run_cmd ${ns_b} ip addr add "${dst_prefix1}${i}" dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${dst_prefix1}${i}" dev veth_B-R1 In pmtu.sh line 2251: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 2 -s 1800 "${dst_prefix1}${i}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 2 -s 1800 "${dst_prefix1}${i}" In pmtu.sh line 2253: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 2 -s 1800 "${dst2}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 2 -s 1800 "${dst2}" In pmtu.sh line 2260: run_cmd ${ns_a} ip route flush cache ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route flush cache In pmtu.sh line 2261: pmtu1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst_prefix}1)" ^-----------^ SC2154 (warning): dst_prefix is referenced but not assigned (did you mean 'dst_prefix1'?). ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst_prefix}"1)" In pmtu.sh line 2262: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst_prefix}2)" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst_prefix}"2)" In pmtu.sh line 2269: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2273: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 2297: run_cmd ${ns_b} ip addr add "${dst_prefix1}${i}" dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${dst_prefix1}${i}" dev veth_B-R1 In pmtu.sh line 2302: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s 1800 "${dst_prefix1}${i}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s 1800 "${dst_prefix1}${i}" In pmtu.sh line 2304: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 2310: run_cmd ${ns_a} ip -6 route flush cache ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -6 route flush cache In pmtu.sh line 2312: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 2319: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2331: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 2355: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst1} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst1}" In pmtu.sh line 2356: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 2359: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 2361: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 2365: run_cmd ${ns_a} ip route change default via ${gw} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route change default via "${gw}" In pmtu.sh line 2368: run_cmd ${ns_a} ip link del "veth_A-R1" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del "veth_A-R1" In pmtu.sh line 2380: setup namespaces routing multipath || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing multipath || return "$ksft_skip" In pmtu.sh line 2399: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 1 -s 1800 "${host4_b_addr}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 1 -s 1800 "${host4_b_addr}" In pmtu.sh line 2441: shift $(($OPTIND-1)) ^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2458: [ $? -eq 0 ] && HAVE_NH=yes ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- br0_port appears unused. Verify u... https://www.shellcheck.net/wiki/SC2154 -- dst_prefix is referenced but not ... https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/pmtu.sh - 89d38106285ee53bd253d7bc6027d80337b16efedf7ca7ecffc2752800ec6da0 In pmtu.sh line 379: printf " COMMAND: $cmd\n" ^-------------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In pmtu.sh line 384: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In pmtu.sh line 389: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In pmtu.sh line 404: eval echo \$NS_$1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval echo \$NS_"$1" In pmtu.sh line 413: modprobe fou || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: modprobe fou || return "$ksft_skip" In pmtu.sh line 424: modprobe fou6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: modprobe fou6 || return "$ksft_skip" In pmtu.sh line 438: run_cmd ${ns_a} ip fou add port 5555 ipproto ${ipproto} || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip fou add port 5555 ipproto "${ipproto}" || return "$ksft_skip" In pmtu.sh line 439: run_cmd ${ns_a} ip link add ${encap}_a type ${type} ${mode} local ${a_addr} remote ${b_addr} encap ${encap} encap-sport auto encap-dport 5556 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add "${encap}"_a type "${type}" "${mode}" local "${a_addr}" remote "${b_addr}" encap "${encap}" encap-sport auto encap-dport 5556 || return "$ksft_skip" In pmtu.sh line 441: run_cmd ${ns_b} ip fou add port 5556 ipproto ${ipproto} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip fou add port 5556 ipproto "${ipproto}" In pmtu.sh line 442: run_cmd ${ns_b} ip link add ${encap}_b type ${type} ${mode} local ${b_addr} remote ${a_addr} encap ${encap} encap-sport auto encap-dport 5555 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${encap}"_b type "${type}" "${mode}" local "${b_addr}" remote "${a_addr}" encap "${encap}" encap-sport auto encap-dport 5555 In pmtu.sh line 445: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${encap}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${encap}"_a In pmtu.sh line 446: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${encap}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${encap}"_b In pmtu.sh line 448: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${encap}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${encap}"_a In pmtu.sh line 449: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${encap}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${encap}"_b In pmtu.sh line 452: run_cmd ${ns_a} ip link set ${encap}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${encap}"_a up In pmtu.sh line 453: run_cmd ${ns_b} ip link set ${encap}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${encap}"_b up In pmtu.sh line 513: run_cmd ${ns_a} ip link add ip_a type ${type} local ${a_addr} remote ${b_addr} mode ${mode} || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add ip_a type "${type}" local "${a_addr}" remote "${b_addr}" mode "${mode}" || return "$ksft_skip" In pmtu.sh line 514: run_cmd ${ns_b} ip link add ip_b type ${type} local ${b_addr} remote ${a_addr} mode ${mode} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add ip_b type "${type}" local "${b_addr}" remote "${a_addr}" mode "${mode}" In pmtu.sh line 516: run_cmd ${ns_a} ip link set ip_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set ip_a up In pmtu.sh line 517: run_cmd ${ns_b} ip link set ip_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set ip_b up In pmtu.sh line 520: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ip_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev ip_a In pmtu.sh line 521: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ip_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev ip_b In pmtu.sh line 523: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ip_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev ip_a In pmtu.sh line 524: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ip_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev ip_b In pmtu.sh line 546: for n in ${NS_A} ${NS_B} ${NS_C} ${NS_R1} ${NS_R2}; do ^-----^ SC2153 (info): Possible misspelling: NS_A may not be assigned. Did you mean ns_a? ^-----^ SC2153 (info): Possible misspelling: NS_B may not be assigned. Did you mean ns_b? ^-----^ SC2153 (info): Possible misspelling: NS_C may not be assigned. Did you mean ns_c? ^------^ SC2153 (info): Possible misspelling: NS_R1 may not be assigned. Did you mean ns_r1? ^------^ SC2153 (info): Possible misspelling: NS_R2 may not be assigned. Did you mean ns_r2? In pmtu.sh line 549: ip netns exec ${n} sysctl -q net/ipv6/conf/default/accept_dad=0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${n}" sysctl -q net/ipv6/conf/default/accept_dad=0 In pmtu.sh line 559: run_cmd ${ns_a} ip link add veth_a type veth peer name veth_b || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add veth_a type veth peer name veth_b || return 1 In pmtu.sh line 560: run_cmd ${ns_a} ip link set veth_b netns ${NS_B} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_b netns "${NS_B}" In pmtu.sh line 562: run_cmd ${ns_a} ip addr add ${veth4_a_addr}/${veth4_mask} dev veth_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${veth4_a_addr}"/"${veth4_mask}" dev veth_a In pmtu.sh line 563: run_cmd ${ns_b} ip addr add ${veth4_b_addr}/${veth4_mask} dev veth_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${veth4_b_addr}"/"${veth4_mask}" dev veth_b In pmtu.sh line 565: run_cmd ${ns_a} ip addr add ${veth6_a_addr}/${veth6_mask} dev veth_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${veth6_a_addr}"/"${veth6_mask}" dev veth_a In pmtu.sh line 566: run_cmd ${ns_b} ip addr add ${veth6_b_addr}/${veth6_mask} dev veth_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${veth6_b_addr}"/"${veth6_mask}" dev veth_b In pmtu.sh line 568: run_cmd ${ns_a} ip link set veth_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_a up In pmtu.sh line 569: run_cmd ${ns_b} ip link set veth_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set veth_b up In pmtu.sh line 580: [ ${proto} -eq 6 ] && vti_type="vti6" || vti_type="vti" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${proto}" -eq 6 ] && vti_type="vti6" || vti_type="vti" In pmtu.sh line 582: run_cmd ${ns_a} ip link add vti${proto}_a type ${vti_type} local ${veth_a_addr} remote ${veth_b_addr} key 10 || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti"${proto}"_a type "${vti_type}" local "${veth_a_addr}" remote "${veth_b_addr}" key 10 || return 1 In pmtu.sh line 583: run_cmd ${ns_b} ip link add vti${proto}_b type ${vti_type} local ${veth_b_addr} remote ${veth_a_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add vti"${proto}"_b type "${vti_type}" local "${veth_b_addr}" remote "${veth_a_addr}" key 10 In pmtu.sh line 585: run_cmd ${ns_a} ip addr add ${vti_a_addr}/${vti_mask} dev vti${proto}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${vti_a_addr}"/"${vti_mask}" dev vti"${proto}"_a In pmtu.sh line 586: run_cmd ${ns_b} ip addr add ${vti_b_addr}/${vti_mask} dev vti${proto}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${vti_b_addr}"/"${vti_mask}" dev vti"${proto}"_b In pmtu.sh line 588: run_cmd ${ns_a} ip link set vti${proto}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti"${proto}"_a up In pmtu.sh line 589: run_cmd ${ns_b} ip link set vti${proto}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set vti"${proto}"_b up In pmtu.sh line 593: setup_vti 4 ${veth4_a_addr} ${veth4_b_addr} ${tunnel4_a_addr} ${tunnel4_b_addr} ${tunnel4_mask} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 4 "${veth4_a_addr}" "${veth4_b_addr}" "${tunnel4_a_addr}" "${tunnel4_b_addr}" "${tunnel4_mask}" In pmtu.sh line 597: setup_vti 6 ${veth6_a_addr} ${veth6_b_addr} ${tunnel6_a_addr} ${tunnel6_b_addr} ${tunnel6_mask} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 6 "${veth6_a_addr}" "${veth6_b_addr}" "${tunnel6_a_addr}" "${tunnel6_b_addr}" "${tunnel6_mask}" In pmtu.sh line 601: setup_vti 4 ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ${tunnel4_a_addr} ${tunnel4_b_addr} ${tunnel4_mask} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 4 "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "${tunnel4_a_addr}" "${tunnel4_b_addr}" "${tunnel4_mask}" In pmtu.sh line 605: setup_vti 6 ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ${tunnel6_a_addr} ${tunnel6_b_addr} ${tunnel6_mask} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vti 6 "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "${tunnel6_a_addr}" "${tunnel6_b_addr}" "${tunnel6_mask}" In pmtu.sh line 624: run_cmd ${ns_a} ip link add ${type}_a type ${type} id 1 ${opts_a} remote ${b_addr} ${opts} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add "${type}"_a type "${type}" id 1 "${opts_a}" remote "${b_addr}" "${opts}" || return 1 In pmtu.sh line 625: run_cmd ${ns_b} ip link add ${type}_b type ${type} id 1 ${opts_b} remote ${a_addr} ${opts} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${type}"_b type "${type}" id 1 "${opts_b}" remote "${a_addr}" "${opts}" In pmtu.sh line 628: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${br_if_a}" In pmtu.sh line 629: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${br_if_a}" In pmtu.sh line 630: run_cmd ${ns_a} ip link set ${type}_a master ${br_if_a} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${type}"_a master "${br_if_a}" In pmtu.sh line 632: run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${type}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel4_a_addr}"/"${tunnel4_mask}" dev "${type}"_a In pmtu.sh line 633: run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${type}_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${tunnel6_a_addr}"/"${tunnel6_mask}" dev "${type}"_a In pmtu.sh line 636: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${type}"_b In pmtu.sh line 637: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${type}"_b In pmtu.sh line 639: run_cmd ${ns_a} ip link set ${type}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set "${type}"_a up In pmtu.sh line 640: run_cmd ${ns_b} ip link set ${type}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${type}"_b up In pmtu.sh line 644: setup_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" In pmtu.sh line 648: setup_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" In pmtu.sh line 652: setup_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" In pmtu.sh line 656: setup_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" In pmtu.sh line 660: setup_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" "br0" In pmtu.sh line 664: setup_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "df set" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "df set" "br0" In pmtu.sh line 668: setup_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" "br0" In pmtu.sh line 672: setup_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "" "br0" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "" "br0" In pmtu.sh line 681: run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm state add src "${veth_a_addr}" dst "${veth_b_addr}" spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" || return 1 In pmtu.sh line 682: run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm state add src "${veth_b_addr}" dst "${veth_a_addr}" spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 683: run_cmd ${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm policy add dir out mark 10 tmpl src "${veth_a_addr}" dst "${veth_b_addr}" proto esp mode tunnel In pmtu.sh line 684: run_cmd ${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -"${proto}" xfrm policy add dir in mark 10 tmpl src "${veth_b_addr}" dst "${veth_a_addr}" proto esp mode tunnel In pmtu.sh line 686: run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm state add src "${veth_a_addr}" dst "${veth_b_addr}" spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 687: run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel ${encap} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm state add src "${veth_b_addr}" dst "${veth_a_addr}" spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel "${encap}" In pmtu.sh line 688: run_cmd ${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm policy add dir out mark 10 tmpl src "${veth_b_addr}" dst "${veth_a_addr}" proto esp mode tunnel In pmtu.sh line 689: run_cmd ${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip -"${proto}" xfrm policy add dir in mark 10 tmpl src "${veth_a_addr}" dst "${veth_b_addr}" proto esp mode tunnel In pmtu.sh line 695: [ ${1} -eq 6 ] && proto="-6" || proto="" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${1}" -eq 6 ] && proto="-6" || proto="" In pmtu.sh line 706: setup_xfrm 4 ${veth4_a_addr} ${veth4_b_addr} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${veth4_a_addr}" "${veth4_b_addr}" In pmtu.sh line 710: setup_xfrm 6 ${veth6_a_addr} ${veth6_b_addr} ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${veth6_a_addr}" "${veth6_b_addr}" In pmtu.sh line 714: setup_xfrm 4 ${veth4_a_addr} ${veth4_b_addr} "encap espinudp 4500 4500 0.0.0.0" && \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${veth4_a_addr}" "${veth4_b_addr}" "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 719: setup_xfrm 6 ${veth6_a_addr} ${veth6_b_addr} "encap espinudp 4500 4500 0.0.0.0" && \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${veth6_a_addr}" "${veth6_b_addr}" "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 724: setup_xfrm 4 ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 "encap espinudp 4500 4500 0.0.0.0" && \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 4 "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 729: setup_xfrm 6 ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 "encap espinudp 4500 4500 0.0.0.0" && \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_xfrm 6 "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 "encap espinudp 4500 4500 0.0.0.0" && \ In pmtu.sh line 739: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 755: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 757: ip -n ${ns_name} -${fam} nexthop add id ${nhid} via ${gw} dev ${dev} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" -"${fam}" nexthop add id "${nhid}" via "${gw}" dev "${dev}" In pmtu.sh line 769: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 779: ip netns exec ${i} sysctl -q net/ipv4/ip_forward=1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${i}" sysctl -q net/ipv4/ip_forward=1 In pmtu.sh line 780: ip netns exec ${i} sysctl -q net/ipv6/conf/all/forwarding=1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${i}" sysctl -q net/ipv6/conf/all/forwarding=1 In pmtu.sh line 788: ns_name="$(nsname ${ns})" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ns_name="$(nsname "${ns}")" In pmtu.sh line 789: peer_name="$(nsname ${peer})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: peer_name="$(nsname "${peer}")" In pmtu.sh line 794: ip link add ${if} up netns ${ns_name} type veth peer name ${ifpeer} netns ${peer_name} || return 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "${if}" up netns "${ns_name}" type veth peer name "${ifpeer}" netns "${peer_name}" || return 1 In pmtu.sh line 795: ip -n ${peer_name} link set dev ${ifpeer} up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" link set dev "${ifpeer}" up In pmtu.sh line 798: ip -n ${ns_name} addr add ${prefix4}.${segment}.1/24 dev ${if} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" addr add "${prefix4}"."${segment}".1/24 dev "${if}" In pmtu.sh line 799: ip -n ${ns_name} addr add ${prefix6}:${segment}::1/64 dev ${if} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${ns_name}" addr add "${prefix6}":"${segment}"::1/64 dev "${if}" In pmtu.sh line 801: ip -n ${peer_name} addr add ${prefix4}.${segment}.2/24 dev ${ifpeer} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" addr add "${prefix4}"."${segment}".2/24 dev "${ifpeer}" In pmtu.sh line 802: ip -n ${peer_name} addr add ${prefix6}:${segment}::2/64 dev ${ifpeer} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "${peer_name}" addr add "${prefix6}":"${segment}"::2/64 dev "${ifpeer}" In pmtu.sh line 835: run_cmd ${ns_a} ip link add br0 type bridge || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add br0 type bridge || return "$ksft_skip" In pmtu.sh line 836: run_cmd ${ns_a} ip link set br0 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set br0 up In pmtu.sh line 838: run_cmd ${ns_c} ip link add veth_C-A type veth peer name veth_A-C ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link add veth_C-A type veth peer name veth_A-C In pmtu.sh line 839: run_cmd ${ns_c} ip link set veth_A-C netns ${NS_A} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_A-C netns "${NS_A}" In pmtu.sh line 841: run_cmd ${ns_a} ip link set veth_A-C up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-C up In pmtu.sh line 842: run_cmd ${ns_c} ip link set veth_C-A up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_C-A up In pmtu.sh line 843: run_cmd ${ns_c} ip addr add ${veth4_c_addr}/${veth4_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth4_c_addr}"/"${veth4_mask}" dev veth_C-A In pmtu.sh line 844: run_cmd ${ns_c} ip addr add ${veth6_c_addr}/${veth6_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth6_c_addr}"/"${veth6_mask}" dev veth_C-A In pmtu.sh line 845: run_cmd ${ns_a} ip link set veth_A-C master br0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-C master br0 In pmtu.sh line 854: run_cmd python3 ./openvswitch/ovs-dpctl.py add-if ovs_br0 ${type}_a -t ${type} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd python3 ./openvswitch/ovs-dpctl.py add-if ovs_br0 "${type}"_a -t "${type}" || return 1 In pmtu.sh line 857: br0_port=$(echo "$ports" | grep -E "\sovs_br0" | sed -e 's@port @@' | cut -d: -f1 | xargs) ^------^ SC2034 (warning): br0_port appears unused. Verify use (or export if used externally). In pmtu.sh line 858: type_a_port=$(echo "$ports" | grep ${type}_a | sed -e 's@port @@' | cut -d: -f1 | xargs) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: type_a_port=$(echo "$ports" | grep "${type}"_a | sed -e 's@port @@' | cut -d: -f1 | xargs) In pmtu.sh line 912: run_cmd ovs-vsctl add-port ovs_br0 ${type}_a -- \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ovs-vsctl add-port ovs_br0 "${type}"_a -- \ In pmtu.sh line 913: set interface ${type}_a type=${type} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: set interface "${type}"_a type="${type}" \ In pmtu.sh line 914: options:remote_ip=${b_addr} options:key=1 options:csum=true || return 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: options:remote_ip="${b_addr}" options:key=1 options:csum=true || return 1 In pmtu.sh line 933: run_cmd ${ns_b} ip link add ${type}_b type ${type} id 1 ${opts_b} remote ${a_addr} ${opts} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link add "${type}"_b type "${type}" id 1 "${opts_b}" remote "${a_addr}" "${opts}" || return 1 In pmtu.sh line 935: run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel4_b_addr}"/"${tunnel4_mask}" dev "${type}"_b In pmtu.sh line 936: run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${type}_b ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${tunnel6_b_addr}"/"${tunnel6_mask}" dev "${type}"_b In pmtu.sh line 938: run_cmd ip link set ${type}_a up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "${type}"_a up In pmtu.sh line 939: run_cmd ${ns_b} ip link set ${type}_b up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip link set "${type}"_b up In pmtu.sh line 943: setup_ovs_vxlan_or_geneve geneve ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve geneve "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 In pmtu.sh line 947: setup_ovs_vxlan_or_geneve vxlan ${prefix4}.${a_r1}.1 ${prefix4}.${b_r1}.1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve vxlan "${prefix4}"."${a_r1}".1 "${prefix4}"."${b_r1}".1 In pmtu.sh line 951: setup_ovs_vxlan_or_geneve geneve ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve geneve "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 In pmtu.sh line 955: setup_ovs_vxlan_or_geneve vxlan ${prefix6}:${a_r1}::1 ${prefix6}:${b_r1}::1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_vxlan_or_geneve vxlan "${prefix6}":"${a_r1}"::1 "${prefix6}":"${b_r1}"::1 In pmtu.sh line 975: setup_ovs_br_internal || setup_ovs_br_vswitchd || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_ovs_br_internal || setup_ovs_br_vswitchd || return "$ksft_skip" In pmtu.sh line 978: run_cmd ${ns_c} ip link add veth_C-A type veth peer name veth_A-C ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link add veth_C-A type veth peer name veth_A-C In pmtu.sh line 979: run_cmd ${ns_c} ip link set veth_A-C netns 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_A-C netns 1 In pmtu.sh line 982: run_cmd ${ns_c} ip link set veth_C-A up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip link set veth_C-A up In pmtu.sh line 983: run_cmd ${ns_c} ip addr add ${veth4_c_addr}/${veth4_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth4_c_addr}"/"${veth4_mask}" dev veth_C-A In pmtu.sh line 984: run_cmd ${ns_c} ip addr add ${veth6_c_addr}/${veth6_mask} dev veth_C-A ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip addr add "${veth6_c_addr}"/"${veth6_mask}" dev veth_C-A In pmtu.sh line 988: run_cmd ${ns_a} ip link set veth_A-R1 netns 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set veth_A-R1 netns 1 In pmtu.sh line 989: run_cmd ip addr add ${prefix4}.${a_r1}.1/${veth4_mask} dev veth_A-R1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add "${prefix4}"."${a_r1}".1/"${veth4_mask}" dev veth_A-R1 In pmtu.sh line 990: run_cmd ip addr add ${prefix6}:${a_r1}::1/${veth6_mask} dev veth_A-R1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add "${prefix6}":"${a_r1}"::1/"${veth6_mask}" dev veth_A-R1 In pmtu.sh line 992: run_cmd ip route add ${prefix4}.${b_r1}.1 via ${prefix4}.${a_r1}.2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add "${prefix4}"."${b_r1}".1 via "${prefix4}"."${a_r1}".2 In pmtu.sh line 993: run_cmd ip route add ${prefix6}:${b_r1}::1 via ${prefix6}:${a_r1}::2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add "${prefix6}":"${b_r1}"::1 via "${prefix6}":"${a_r1}"::2 In pmtu.sh line 998: run_cmd ${ns_a} ip addr add ${host4_a_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${host4_a_addr}" dev lo In pmtu.sh line 999: run_cmd ${ns_a} ip nexthop add id 401 via ${prefix4}.${a_r1}.2 dev veth_A-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 401 via "${prefix4}"."${a_r1}".2 dev veth_A-R1 In pmtu.sh line 1000: run_cmd ${ns_a} ip nexthop add id 402 via ${prefix4}.${a_r2}.2 dev veth_A-R2 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 402 via "${prefix4}"."${a_r2}".2 dev veth_A-R2 In pmtu.sh line 1001: run_cmd ${ns_a} ip nexthop add id 403 group 401/402 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip nexthop add id 403 group 401/402 In pmtu.sh line 1002: run_cmd ${ns_a} ip route add ${host4_b_addr} src ${host4_a_addr} nhid 403 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route add "${host4_b_addr}" src "${host4_a_addr}" nhid 403 In pmtu.sh line 1005: run_cmd ${ns_b} ip addr add ${host4_b_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${host4_b_addr}" dev lo In pmtu.sh line 1006: run_cmd ${ns_b} ip nexthop add id 401 via ${prefix4}.${b_r1}.2 dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 401 via "${prefix4}"."${b_r1}".2 dev veth_B-R1 In pmtu.sh line 1007: run_cmd ${ns_b} ip nexthop add id 402 via ${prefix4}.${b_r2}.2 dev veth_B-R2 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 402 via "${prefix4}"."${b_r2}".2 dev veth_B-R2 In pmtu.sh line 1008: run_cmd ${ns_b} ip nexthop add id 403 group 401/402 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip nexthop add id 403 group 401/402 In pmtu.sh line 1009: run_cmd ${ns_b} ip route add ${host4_a_addr} src ${host4_b_addr} nhid 403 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route add "${host4_a_addr}" src "${host4_b_addr}" nhid 403 In pmtu.sh line 1014: run_cmd ${ns_a} ip addr add ${host4_a_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${host4_a_addr}" dev lo In pmtu.sh line 1015: run_cmd ${ns_a} ip route add ${host4_b_addr} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route add "${host4_b_addr}" \ In pmtu.sh line 1016: src ${host4_a_addr} \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src "${host4_a_addr}" \ In pmtu.sh line 1017: nexthop via ${prefix4}.${a_r1}.2 weight 1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${a_r1}".2 weight 1 \ In pmtu.sh line 1018: nexthop via ${prefix4}.${a_r2}.2 weight 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${a_r2}".2 weight 1 In pmtu.sh line 1021: run_cmd ${ns_b} ip addr add ${host4_b_addr} dev lo ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${host4_b_addr}" dev lo In pmtu.sh line 1022: run_cmd ${ns_b} ip route add ${host4_a_addr} \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route add "${host4_a_addr}" \ In pmtu.sh line 1023: src ${host4_b_addr} \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src "${host4_b_addr}" \ In pmtu.sh line 1024: nexthop via ${prefix4}.${b_r1}.2 weight 1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${b_r1}".2 weight 1 \ In pmtu.sh line 1025: nexthop via ${prefix4}.${b_r2}.2 weight 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${prefix4}"."${b_r2}".2 weight 1 In pmtu.sh line 1036: run_cmd ${ns_r1} ip route add ${host4_a_addr} via ${prefix4}.${a_r1}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r1}" ip route add "${host4_a_addr}" via "${prefix4}"."${a_r1}".1 In pmtu.sh line 1037: run_cmd ${ns_r2} ip route add ${host4_a_addr} via ${prefix4}.${a_r2}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r2}" ip route add "${host4_a_addr}" via "${prefix4}"."${a_r2}".1 In pmtu.sh line 1038: run_cmd ${ns_r1} ip route add ${host4_b_addr} via ${prefix4}.${b_r1}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r1}" ip route add "${host4_b_addr}" via "${prefix4}"."${b_r1}".1 In pmtu.sh line 1039: run_cmd ${ns_r2} ip route add ${host4_b_addr} via ${prefix4}.${b_r2}.1 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_r2}" ip route add "${host4_b_addr}" via "${prefix4}"."${b_r2}".1 In pmtu.sh line 1043: [ "$(id -u)" -ne 0 ] && echo " need to run as root" && return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$(id -u)" -ne 0 ] && echo " need to run as root" && return "$ksft_skip" In pmtu.sh line 1046: eval setup_${arg} || { echo " ${arg} not supported"; return 1; } ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval setup_"${arg}" || { echo " ${arg} not supported"; return 1; } In pmtu.sh line 1051: [ $TRACING -eq 0 ] && return ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$TRACING" -eq 0 ] && return In pmtu.sh line 1076: kill ${pid} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "${pid}" In pmtu.sh line 1081: kill ${pid} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "${pid}" In pmtu.sh line 1105: ${ns_cmd} ip link set dev ${dev} mtu ${mtu} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${ns_cmd} ip link set dev "${dev}" mtu "${mtu}" In pmtu.sh line 1113: [ ${next} -eq 1 -a "${i}" = "lock" ] && next=2 && continue ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. Did you mean: [ "${next}" -eq 1 -a "${i}" = "lock" ] && next=2 && continue In pmtu.sh line 1114: [ ${next} -eq 1 ] && echo "${i}" && return ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${next}" -eq 1 ] && echo "${i}" && return In pmtu.sh line 1115: [ ${next} -eq 2 ] && echo "lock ${i}" && return ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "${next}" -eq 2 ] && echo "lock ${i}" && return In pmtu.sh line 1131: mtu_parse "$(link_get "${ns_cmd}" ${name})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_parse "$(link_get "${ns_cmd}" "${name}")" In pmtu.sh line 1162: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 1168: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1190: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst1} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst1}" In pmtu.sh line 1191: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 1194: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1196: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1202: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1205: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1211: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 1214: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1218: [ $family -eq 6 ] && return 0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$family" -eq 6 ] && return 0 In pmtu.sh line 1223: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1400 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1400 "${dst2}" In pmtu.sh line 1224: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1230: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1236: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1240: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1400 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1400 "${dst2}" In pmtu.sh line 1241: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 1256: setup namespaces policy_routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces policy_routing || return "$ksft_skip" In pmtu.sh line 1298: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In pmtu.sh line 1301: setup namespaces policy_routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces policy_routing || return "$ksft_skip" In pmtu.sh line 1348: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1349: setup namespaces routing ${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${type}"4 || return "$ksft_skip" In pmtu.sh line 1351: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1353: setup namespaces routing ${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${type}"6 || return "$ksft_skip" In pmtu.sh line 1355: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1358: trace "${ns_a}" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1362: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1371: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1372: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1373: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1374: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1376: mtu "${ns_a}" ${type}_a $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${type}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1377: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1378: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1381: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1382: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ${type} interface" In pmtu.sh line 1423: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1424: setup namespaces routing bridge bridged_${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing bridge bridged_"${type}"4 || return "$ksft_skip" In pmtu.sh line 1426: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1428: setup namespaces routing bridge bridged_${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing bridge bridged_"${type}"6 || return "$ksft_skip" In pmtu.sh line 1430: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1433: trace "${ns_a}" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1439: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1448: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1449: mtu "${ns_a}" br0 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1450: mtu "${ns_a}" veth_A-C $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1451: mtu "${ns_c}" veth_C-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1452: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1453: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1454: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1456: mtu "${ns_a}" ${type}_a $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${type}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1457: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1459: run_cmd ${ns_c} ${ping} -q -M want -i 0.1 -c 10 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" "${ping}" -q -M want -i 0.1 -c 10 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1460: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1463: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1464: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on bridged ${type} interface" In pmtu.sh line 1465: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1466: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on locally bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on locally bridged ${type} interface" In pmtu.sh line 1471: run_cmd ${ns_a} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route flush cached "${dst}" In pmtu.sh line 1472: run_cmd ${ns_b} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip route flush cached "${dst}" In pmtu.sh line 1473: run_cmd ${ns_c} ip route flush cached ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" ip route flush cached "${dst}" In pmtu.sh line 1476: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1481: ${ns_b} socat -T 3 -u -6 TCP-LISTEN:50000,reuseaddr STDOUT > $tmpoutfile & ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${ns_b} socat -T 3 -u -6 TCP-LISTEN:50000,reuseaddr STDOUT > "$tmpoutfile" & In pmtu.sh line 1484: wait_local_port_listen ${NS_B} 50000 tcp ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_local_port_listen "${NS_B}" 50000 tcp In pmtu.sh line 1486: dd if=/dev/zero status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN $TCPDST,connect-timeout=3 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dd if=/dev/zero status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN "$TCPDST",connect-timeout=3 In pmtu.sh line 1488: wait ${socat_pid} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait "${socat_pid}" In pmtu.sh line 1489: size=$(du -sb $tmpoutfile) ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: size=$(du -sb "$tmpoutfile") In pmtu.sh line 1492: [ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$size" -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1 In pmtu.sh line 1498: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1499: check_pmtu_value ${exp_mtu} "${pmtu}" "tcp: exceeding link layer MTU on bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "tcp: exceeding link layer MTU on bridged ${type} interface" In pmtu.sh line 1500: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1501: check_pmtu_value ${exp_mtu} "${pmtu}" "tcp exceeding link layer MTU on locally bridged ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "tcp exceeding link layer MTU on locally bridged ${type} interface" In pmtu.sh line 1548: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1549: setup namespaces routing ovs_bridge ovs_${type}4 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ovs_bridge ovs_"${type}"4 || return "$ksft_skip" In pmtu.sh line 1551: exp_mtu=$((${ll_mtu} - 20 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1553: setup namespaces routing ovs_bridge ovs_${type}6 || return $ksft_skip ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ovs_bridge ovs_"${type}"6 || return "$ksft_skip" In pmtu.sh line 1555: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - 14)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1558: trace "" ${type}_a "${ns_b}" ${type}_b \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "" "${type}"_a "${ns_b}" "${type}"_b \ In pmtu.sh line 1564: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 1573: mtu "" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1574: mtu "" ovs_br0 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1575: mtu "" veth_A-C $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1576: mtu "${ns_c}" veth_C-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1577: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1578: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1579: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1581: mtu "" ${tun_a} $((${ll_mtu} + 1000)) 2>/dev/null || \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "" "${tun_a}" $((${ll_mtu} + 1000)) 2>/dev/null || \ In pmtu.sh line 1582: mtu "" ${type}_a $((${ll_mtu} + 1000)) 2>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "" "${type}"_a $((${ll_mtu} + 1000)) 2>/dev/null In pmtu.sh line 1583: mtu "${ns_b}" ${type}_b $((${ll_mtu} + 1000)) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${type}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1585: run_cmd ${ns_c} ${ping} -q -M want -i 0.1 -c 20 -s $((${ll_mtu} + 500)) ${dst} || return 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_c}" "${ping}" -q -M want -i 0.1 -c 20 -s $((${ll_mtu} + 500)) "${dst}" || return 1 In pmtu.sh line 1588: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_c}" "${dst}")" In pmtu.sh line 1589: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on Open vSwitch ${type} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on Open vSwitch ${type} interface" In pmtu.sh line 1630: setup namespaces routing ${encap}${outer_family}${inner_family} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${encap}""${outer_family}""${inner_family}" || return "$ksft_skip" In pmtu.sh line 1631: trace "${ns_a}" ${encap}_a "${ns_b}" ${encap}_b \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${encap}"_a "${ns_b}" "${encap}"_b \ In pmtu.sh line 1635: if [ ${inner_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${inner_family}" -eq 4 ]; then In pmtu.sh line 1649: if [ ${outer_family} -eq 4 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer_family}" -eq 4 ]; then In pmtu.sh line 1651: exp_mtu=$((${ll_mtu} - 20 - 8 - ${encap_overhead})) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1654: exp_mtu=$((${ll_mtu} - 40 - 8 - 8 - ${encap_overhead})) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1658: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1659: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1660: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1661: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1663: mtu "${ns_a}" ${encap}_a $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${encap}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 1664: mtu "${ns_b}" ${encap}_b $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${encap}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 1665: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1668: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1669: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ${encap} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ${encap} interface" In pmtu.sh line 1709: setup namespaces routing ip${inner}ip${outer} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing ip"${inner}"ip"${outer}" || return "$ksft_skip" In pmtu.sh line 1715: if [ ${inner} -eq 4 ]; then ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${inner}" -eq 4 ]; then In pmtu.sh line 1723: if [ ${outer} -eq 4 ]; then ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${outer}" -eq 4 ]; then In pmtu.sh line 1725: exp_mtu=$((${ll_mtu} - 20)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1728: exp_mtu=$((${ll_mtu} - 40 - 8)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1732: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1733: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1734: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 1735: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 1737: mtu "${ns_a}" ip_a $((${ll_mtu} + 1000)) || return ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1738: mtu "${ns_b}" ip_b $((${ll_mtu} + 1000)) || return ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 1739: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${dst} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${dst}" In pmtu.sh line 1742: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst})" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst}")" In pmtu.sh line 1743: check_pmtu_value ${exp_mtu} "${pmtu}" "exceeding link layer MTU on ip${inner}ip${outer} interface" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_pmtu_value "${exp_mtu}" "${pmtu}" "exceeding link layer MTU on ip${inner}ip${outer} interface" In pmtu.sh line 1763: setup namespaces veth vti4 xfrm4 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 xfrm4 || return "$ksft_skip" In pmtu.sh line 1774: mtu "${ns_a}" veth_a ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_a "${veth_mtu}" In pmtu.sh line 1775: mtu "${ns_b}" veth_b ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_b "${veth_mtu}" In pmtu.sh line 1776: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1777: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1781: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1782: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1787: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) "${tunnel4_b_addr}" In pmtu.sh line 1788: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1793: setup namespaces veth vti6 xfrm6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 xfrm6 || return "$ksft_skip" In pmtu.sh line 1803: run_cmd ${ns_a} ${ping6} -q -i 0.1 -w 1 -s 60000 ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -i 0.1 -w 1 -s 60000 "${tunnel6_b_addr}" In pmtu.sh line 1806: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1811: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1816: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1819: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 1823: setup namespaces veth vti4 xfrm4udp || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 xfrm4udp || return "$ksft_skip" In pmtu.sh line 1834: mtu "${ns_a}" veth_a ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_a "${veth_mtu}" In pmtu.sh line 1835: mtu "${ns_b}" veth_b ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_b "${veth_mtu}" In pmtu.sh line 1836: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1837: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1841: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1842: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1847: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload + 1)) "${tunnel4_b_addr}" In pmtu.sh line 1848: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1853: setup namespaces veth vti6 xfrm6udp || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 xfrm6udp || return "$ksft_skip" In pmtu.sh line 1863: run_cmd ${ns_a} ${ping6} -q -i 0.1 -w 1 -s 60000 ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -i 0.1 -w 1 -s 60000 "${tunnel6_b_addr}" In pmtu.sh line 1866: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1871: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1876: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1879: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 1883: setup namespaces routing vti4routed xfrm4udprouted || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing vti4routed xfrm4udprouted || return "$ksft_skip" In pmtu.sh line 1894: mtu "${ns_a}" veth_A-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_A-R1 "${veth_mtu}" In pmtu.sh line 1895: mtu "${ns_r1}" veth_R1-A ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-A "${veth_mtu}" In pmtu.sh line 1896: mtu "${ns_b}" veth_B-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${veth_mtu}" In pmtu.sh line 1897: mtu "${ns_r1}" veth_R1-B ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${veth_mtu}" In pmtu.sh line 1899: mtu "${ns_a}" vti4_a ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" vti4_a "${vti_mtu}" In pmtu.sh line 1900: mtu "${ns_b}" vti4_b ${vti_mtu} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" vti4_b "${vti_mtu}" In pmtu.sh line 1904: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel4_b_addr}" In pmtu.sh line 1905: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1911: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((ping_payload)) ${tunnel4_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((ping_payload)) "${tunnel4_b_addr}" In pmtu.sh line 1912: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel4_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel4_b_addr}")" In pmtu.sh line 1917: setup namespaces routing vti6routed xfrm6udprouted || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing vti6routed xfrm6udprouted || return "$ksft_skip" In pmtu.sh line 1928: mtu "${ns_a}" veth_A-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_a}" veth_A-R1 "${veth_mtu}" In pmtu.sh line 1929: mtu "${ns_r1}" veth_R1-A ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-A "${veth_mtu}" In pmtu.sh line 1930: mtu "${ns_b}" veth_B-R1 ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${veth_mtu}" In pmtu.sh line 1931: mtu "${ns_r1}" veth_R1-B ${veth_mtu} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${veth_mtu}" In pmtu.sh line 1936: run_cmd ${ns_a} ${ping6} -q -M want -i 0.1 -w 1 -s ${ping_payload} ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -M want -i 0.1 -w 1 -s "${ping_payload}" "${tunnel6_b_addr}" In pmtu.sh line 1939: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1945: run_cmd ${ns_a} ${ping6} -q -M want -i 0.1 -w 1 -s $((ping_payload)) ${tunnel6_b_addr} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping6}" -q -M want -i 0.1 -w 1 -s $((ping_payload)) "${tunnel6_b_addr}" In pmtu.sh line 1946: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" ${tunnel6_b_addr})" ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu="$(route_get_dst_pmtu_from_exception "${ns_a}" "${tunnel6_b_addr}")" In pmtu.sh line 1952: setup namespaces veth vti4 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti4 || return "$ksft_skip" In pmtu.sh line 1964: setup namespaces veth vti6 || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces veth vti6 || return "$ksft_skip" In pmtu.sh line 1976: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 1978: run_cmd ${ns_a} ip link add vti4_a type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 1979: [ $? -ne 0 ] && err " vti not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " vti not supported" && return "$ksft_skip" In pmtu.sh line 1980: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 1988: run_cmd ${ns_a} ip link add vti4_a mtu ${v} type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a mtu "${v}" type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 1990: [ $? -ne 0 ] && continue ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In pmtu.sh line 1992: if [ ${mtu} -lt ${min} -o ${mtu} -gt ${max} ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -lt "${min}" -o "${mtu}" -gt "${max}" ]; then In pmtu.sh line 1996: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 2001: run_cmd ${ns_a} ip link add vti4_a mtu ${v} type vti local ${veth4_a_addr} remote ${veth4_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti4_a mtu "${v}" type vti local "${veth4_a_addr}" remote "${veth4_b_addr}" key 10 In pmtu.sh line 2003: run_cmd ${ns_a} ip link del vti4_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti4_a In pmtu.sh line 2010: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2014: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 2016: run_cmd ${ns_a} ip link add vti6_a type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2017: [ $? -ne 0 ] && err " vti6 not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " vti6 not supported" && return "$ksft_skip" In pmtu.sh line 2018: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2026: run_cmd ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu "${v}" type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2028: [ $? -ne 0 ] && continue ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In pmtu.sh line 2030: if [ ${mtu} -lt ${min} -o ${mtu} -gt ${max} ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -lt "${min}" -o "${mtu}" -gt "${max}" ]; then In pmtu.sh line 2034: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2039: run_cmd ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu "${v}" type vti6 local "${veth6_a_addr}" remote "${veth6_b_addr}" key 10 In pmtu.sh line 2041: run_cmd ${ns_a} ip link del vti6_a ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del vti6_a In pmtu.sh line 2048: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2052: setup namespaces || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces || return "$ksft_skip" In pmtu.sh line 2054: run_cmd ${ns_a} ip link add dummy0 mtu 1500 type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add dummy0 mtu 1500 type dummy In pmtu.sh line 2055: [ $? -ne 0 ] && err " dummy not supported" && return $ksft_skip ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ $? -ne 0 ] && err " dummy not supported" && return "$ksft_skip" In pmtu.sh line 2056: run_cmd ${ns_a} ip link add dummy1 mtu 3000 type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add dummy1 mtu 3000 type dummy In pmtu.sh line 2057: run_cmd ${ns_a} ip link set dummy0 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set dummy0 up In pmtu.sh line 2058: run_cmd ${ns_a} ip link set dummy1 up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set dummy1 up In pmtu.sh line 2060: run_cmd ${ns_a} ip addr add ${dummy6_0_prefix}1/${dummy6_mask} dev dummy0 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${dummy6_0_prefix}"1/"${dummy6_mask}" dev dummy0 In pmtu.sh line 2061: run_cmd ${ns_a} ip addr add ${dummy6_1_prefix}1/${dummy6_mask} dev dummy1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip addr add "${dummy6_1_prefix}"1/"${dummy6_mask}" dev dummy1 In pmtu.sh line 2066: run_cmd ${ns_a} ip link add vti6_a mtu 1300 type vti6 remote ${dummy6_0_prefix}2 local ${dummy6_0_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link add vti6_a mtu 1300 type vti6 remote "${dummy6_0_prefix}"2 local "${dummy6_0_prefix}"1 In pmtu.sh line 2068: if [ ${mtu} -ne 1300 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne 1300 ]; then In pmtu.sh line 2075: run_cmd ${ns_a} ip link set vti6_a type vti6 remote ${dummy6_1_prefix}2 local ${dummy6_1_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti6_a type vti6 remote "${dummy6_1_prefix}"2 local "${dummy6_1_prefix}"1 In pmtu.sh line 2077: if [ ${mtu} -ne $((3000 - 40)) ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne $((3000 - 40)) ]; then In pmtu.sh line 2083: run_cmd ${ns_a} ip link set vti6_a mtu 1280 type vti6 remote ${dummy6_0_prefix}2 local ${dummy6_0_prefix}1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link set vti6_a mtu 1280 type vti6 remote "${dummy6_0_prefix}"2 local "${dummy6_0_prefix}"1 In pmtu.sh line 2085: if [ ${mtu} -ne 1280 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${mtu}" -ne 1280 ]; then In pmtu.sh line 2090: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2096: if ! which ${cmd} > /dev/null 2>&1; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ! which "${cmd}" > /dev/null 2>&1; then In pmtu.sh line 2107: [ "$(cat /proc/${pid}/cmdline 2>/dev/null | tr -d '\0')" = "${cmd}" ] ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$(cat /proc/"${pid}"/cmdline 2>/dev/null | tr -d '\0')" = "${cmd}" ] In pmtu.sh line 2115: check_command taskset || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_command taskset || return "$ksft_skip" In pmtu.sh line 2118: setup namespaces routing ${encap}${outer} || return $ksft_skip ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing "${encap}""${outer}" || return "$ksft_skip" In pmtu.sh line 2119: trace "${ns_a}" ${encap}_a "${ns_b}" ${encap}_b \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: trace "${ns_a}" "${encap}"_a "${ns_b}" "${encap}"_b \ In pmtu.sh line 2124: mtu "${ns_a}" veth_A-R1 $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2125: mtu "${ns_r1}" veth_R1-A $((${ll_mtu} + 1000)) ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2126: mtu "${ns_b}" veth_B-R1 ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_b}" veth_B-R1 "${ll_mtu}" In pmtu.sh line 2127: mtu "${ns_r1}" veth_R1-B ${ll_mtu} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu "${ns_r1}" veth_R1-B "${ll_mtu}" In pmtu.sh line 2129: mtu "${ns_a}" ${encap}_a $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_a}" "${encap}"_a $((${ll_mtu} + 1000)) In pmtu.sh line 2130: mtu "${ns_b}" ${encap}_b $((${ll_mtu} + 1000)) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. Did you mean: mtu "${ns_b}" "${encap}"_b $((${ll_mtu} + 1000)) In pmtu.sh line 2135: run_cmd taskset --cpu-list ${cpu} ${ns_a} ping -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) ${tunnel4_b_addr} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd taskset --cpu-list "${cpu}" "${ns_a}" ping -q -M want -i 0.1 -w 1 -s $((${ll_mtu} + 500)) "${tunnel4_b_addr}" In pmtu.sh line 2141: check_running ${iplink_pid} "iplinkdeldevveth_A-R1" || return 0 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_running "${iplink_pid}" "iplinkdeldevveth_A-R1" || return 0 In pmtu.sh line 2171: eval test_${tname} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: eval test_"${tname}" In pmtu.sh line 2181: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In pmtu.sh line 2198: $ksft_skip) ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob. In pmtu.sh line 2220: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 2244: run_cmd ${ns_b} ip addr add "${dst_prefix1}${i}" dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${dst_prefix1}${i}" dev veth_B-R1 In pmtu.sh line 2252: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 2 -s 1800 "${dst_prefix1}${i}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 2 -s 1800 "${dst_prefix1}${i}" In pmtu.sh line 2254: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 2 -s 1800 "${dst2}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 2 -s 1800 "${dst2}" In pmtu.sh line 2261: run_cmd ${ns_a} ip route flush cache ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route flush cache In pmtu.sh line 2262: pmtu1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst_prefix}1)" ^-----------^ SC2154 (warning): dst_prefix is referenced but not assigned (did you mean 'dst_prefix1'?). ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst_prefix}"1)" In pmtu.sh line 2263: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst_prefix}2)" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst_prefix}"2)" In pmtu.sh line 2270: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2274: setup namespaces routing || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing || return "$ksft_skip" In pmtu.sh line 2298: run_cmd ${ns_b} ip addr add "${dst_prefix1}${i}" dev veth_B-R1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_b}" ip addr add "${dst_prefix1}${i}" dev veth_B-R1 In pmtu.sh line 2303: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s 1800 "${dst_prefix1}${i}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s 1800 "${dst_prefix1}${i}" In pmtu.sh line 2305: run_cmd ${ns_a} ping -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 2311: run_cmd ${ns_a} ip -6 route flush cache ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip -6 route flush cache In pmtu.sh line 2313: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 2320: return ${fail} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${fail}" In pmtu.sh line 2332: if [ ${family} -eq 4 ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${family}" -eq 4 ]; then In pmtu.sh line 2356: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst1} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst1}" In pmtu.sh line 2357: run_cmd ${ns_a} ${ping} -q -M want -i 0.1 -w 1 -s 1800 ${dst2} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" "${ping}" -q -M want -i 0.1 -w 1 -s 1800 "${dst2}" In pmtu.sh line 2360: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst1})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_1="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst1}")" In pmtu.sh line 2362: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" ${dst2})" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pmtu_2="$(route_get_dst_pmtu_from_exception "${ns_a}" "${dst2}")" In pmtu.sh line 2366: run_cmd ${ns_a} ip route change default via ${gw} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip route change default via "${gw}" In pmtu.sh line 2369: run_cmd ${ns_a} ip link del "veth_A-R1" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ip link del "veth_A-R1" In pmtu.sh line 2381: setup namespaces routing multipath || return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup namespaces routing multipath || return "$ksft_skip" In pmtu.sh line 2400: run_cmd ${ns_a} ping -q -M want -i 0.1 -c 1 -s 1800 "${host4_b_addr}" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "${ns_a}" ping -q -M want -i 0.1 -c 1 -s 1800 "${host4_b_addr}" In pmtu.sh line 2442: shift $(($OPTIND-1)) ^-----^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In pmtu.sh line 2459: [ $? -eq 0 ] && HAVE_NH=yes ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- br0_port appears unused. Verify u... https://www.shellcheck.net/wiki/SC2154 -- dst_prefix is referenced but not ... https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...