pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.G3Qxte7CNm and /tmp/tmp.5LLVwGM6pD Tree base: 953dddee6d9f ("selftests: drv-net: adjust tests before defaulting to shell=False") Now at: 0a9626a8d434 ("selftests: net: py: don't default to shell=True") ====== Checking before the patch ====== ************* Module py.utils tools/testing/selftests/net/lib/py/utils.py:144:0: C0301: Line too long (124/100) (line-too-long) tools/testing/selftests/net/lib/py/utils.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/utils.py:14:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:20:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:22:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/testing/selftests/net/lib/py/utils.py:28:0: C0103: Class name "cmd" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:34:4: R0913: Too many arguments (9/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:34:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:69:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:60:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/testing/selftests/net/lib/py/utils.py:73:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:91:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/net/lib/py/utils.py:28:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/utils.py:95:0: C0103: Class name "bkg" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:114:4: R0913: Too many arguments (8/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:114:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:139:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:139:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:141:8: W0602: Using global for 'global_defer_queue' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/utils.py:144:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:159:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:162:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:165:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:170:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:181:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:185:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:191:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:230:14: W0622: Redefining built-in 'type' (redefined-builtin) tools/testing/selftests/net/lib/py/utils.py:239:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:239:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:239:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:253:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:3:0: W0611: Unused import errno (unused-import) tools/testing/selftests/net/lib/py/utils.py:6:0: W0611: Unused import random (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.96/10 (previous run: 7.94/10, +0.02) ====== Checking the tree with the patch ====== ************* Module py.utils tools/testing/selftests/net/lib/py/utils.py:151:0: C0301: Line too long (124/100) (line-too-long) tools/testing/selftests/net/lib/py/utils.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/utils.py:14:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:20:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:22:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/testing/selftests/net/lib/py/utils.py:28:0: C0103: Class name "cmd" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:37:4: R0913: Too many arguments (9/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:37:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:76:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:67:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/testing/selftests/net/lib/py/utils.py:80:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:98:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/net/lib/py/utils.py:28:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/utils.py:102:0: C0103: Class name "bkg" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:121:4: R0913: Too many arguments (8/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:121:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:146:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:146:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:148:8: W0602: Using global for 'global_defer_queue' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/utils.py:151:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:166:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:169:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:172:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:177:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:188:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:192:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:198:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:237:14: W0622: Redefining built-in 'type' (redefined-builtin) tools/testing/selftests/net/lib/py/utils.py:246:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:246:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:246:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:260:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:3:0: W0611: Unused import errno (unused-import) tools/testing/selftests/net/lib/py/utils.py:6:0: W0611: Unused import random (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.99/10 (previous run: 7.96/10, +0.02)