ERROR: do not use in_atomic in drivers #54: FILE: drivers/net/ethernet/realtek/r8169_main.c:3987: + if (in_atomic() || irqs_disabled()) WARNING: line length of 91 exceeds 80 columns #60: FILE: drivers/net/ethernet/realtek/r8169_main.c:3993: + data = alloc_pages(gfp_flags | __GFP_NOWARN, get_order(R8169_RX_BUF_SIZE)); ERROR: trailing whitespace #66: FILE: drivers/net/ethernet/realtek/r8169_main.c:3999: +^I^I$ ERROR: trailing whitespace #82: FILE: drivers/net/ethernet/realtek/r8169_main.c:4014: +^I$ ERROR: trailing whitespace #98: FILE: drivers/net/ethernet/realtek/r8169_main.c:4179: +^I$ ERROR: trailing whitespace #104: FILE: drivers/net/ethernet/realtek/r8169_main.c:4185: +^I$ WARNING: line length of 83 exceeds 80 columns #116: FILE: drivers/net/ethernet/realtek/r8169_main.c:4196: + netdev_err(tp->dev, "Failed to map TX DMA: len=%u\n", len); ERROR: trailing whitespace #138: FILE: drivers/net/ethernet/realtek/r8169_main.c:4665: +^I^I$ ERROR: trailing whitespace #147: FILE: drivers/net/ethernet/realtek/r8169_main.c:4674: +^I^I$ ERROR: trailing whitespace #181: FILE: drivers/net/ethernet/realtek/r8169_main.c:4745: +^I^Iif (tp->mac_version <= RTL_GIGA_MAC_VER_06 || $ WARNING: line length of 102 exceeds 80 columns #187: FILE: drivers/net/ethernet/realtek/r8169_main.c:4751: + netdev_warn(tp->dev, "SYSErr on newer chip: status=0x%08x\n", status); WARNING: line length of 82 exceeds 80 columns #268: FILE: drivers/net/ethernet/realtek/r8169_main.c:5061: + dev_err(dev, "Failed to enable clock: %d\n", ret); WARNING: adding a line without newline at end of file #318: FILE: drivers/net/ethernet/realtek/r8169_main.c:5692: +module_pci_driver(rtl8169_pci_driver); WARNING: From:/Signed-off-by: email name mismatch: 'From: mohammad amin hosseini ' != 'Signed-off-by: Mohammad Amin Hosseini ' total: 8 errors, 6 warnings, 0 checks, 261 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit e4c102d0bef9 ("r8169: hardening and stability improvements") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.