pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.tqmRNrtxSo and /tmp/tmp.T5kBIrX0Z6 Tree base: 4f54dff818d7 ("pppoe: drop sock reference counting on fast path") Now at: 2a781257c22f ("selftests: drv-net: rss_ctx: use Netlink for timed reconfig") ====== Checking before the patch ====== ************* Module rss_ctx tools/testing/selftests/drivers/net/hw/rss_ctx.py:59:0: C0301: Line too long (104/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:67:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:260:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:480:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:481:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:484:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:572:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:624:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:738:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:788:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:17:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hw/rss_ctx.py:33:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:37:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:47:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:62:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:76:12: R1728: Consider using a generator instead 'max(x['queue-id'] for x in data)' (consider-using-generator) tools/testing/selftests/drivers/net/hw/rss_ctx.py:203:8: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test or qstat not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0912: Too many branches (15/12) (too-many-branches) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0915: Too many statements (70/50) (too-many-statements) tools/testing/selftests/drivers/net/hw/rss_ctx.py:342:8: W0612: Unused variable 'errors0' (unused-variable) tools/testing/selftests/drivers/net/hw/rss_ctx.py:371:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:374:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:381:12: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Unable to add any contexts') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:390:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:418:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:423:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:447:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:500:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:504:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:508:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:512:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:535:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:608:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:657:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:726:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:742:8: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Ntuple filter with RSS and nonzero action not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:806:0: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 9.05/10 (previous run: 9.05/10, +0.00) ====== Checking the tree with the patch ====== ************* Module rss_ctx tools/testing/selftests/drivers/net/hw/rss_ctx.py:59:0: C0301: Line too long (104/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:67:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:260:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:481:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:482:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:485:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:573:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:625:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:739:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:789:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:17:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hw/rss_ctx.py:33:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:37:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:47:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:62:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:76:12: R1728: Consider using a generator instead 'max(x['queue-id'] for x in data)' (consider-using-generator) tools/testing/selftests/drivers/net/hw/rss_ctx.py:203:8: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test or qstat not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0912: Too many branches (15/12) (too-many-branches) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0915: Too many statements (70/50) (too-many-statements) tools/testing/selftests/drivers/net/hw/rss_ctx.py:343:8: W0612: Unused variable 'errors0' (unused-variable) tools/testing/selftests/drivers/net/hw/rss_ctx.py:372:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:375:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:382:12: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Unable to add any contexts') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:391:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:419:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:424:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:448:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:501:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:505:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:509:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:513:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:536:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:609:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:658:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:727:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:743:8: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Ntuple filter with RSS and nonzero action not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:807:0: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 9.06/10 (previous run: 9.05/10, +0.00)