CHECK: Alignment should match open parenthesis #62: FILE: drivers/infiniband/hw/bng_re/bng_dev.c:127: + bng_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp, + sizeof(resp), BNGE_DFLT_HWRM_CMD_TIMEOUT); CHECK: Alignment should match open parenthesis #170: FILE: drivers/infiniband/hw/bng_re/bng_dev.c:298: + rc = bng_re_enable_fw_channel(&rdev->rcfw, + vid, db_offt); WARNING: line length of 81 exceeds 80 columns #254: FILE: drivers/infiniband/hw/bng_re/bng_fw.c:117: + memcpy(crsqe->resp, qp_event, sizeof(*qp_event)); CHECK: Please don't use multiple blank lines #325: FILE: drivers/infiniband/hw/bng_re/bng_fw.c:188: + + WARNING: line length of 81 exceeds 80 columns #417: FILE: drivers/infiniband/hw/bng_re/bng_fw.c:280: + mbox->db = (void __iomem *)(mbox->reg.bar_reg + BNG_FW_COMM_TRIG_OFFSET); CHECK: Please don't use multiple blank lines #631: FILE: drivers/infiniband/hw/bng_re/bng_fw.h:45: + + CHECK: Please use a blank line after function/struct/union/enum declarations #639: FILE: drivers/infiniband/hw/bng_re/bng_fw.h:60: } +struct bng_re_cmdq_mbox { CHECK: Macro argument 'hwq' may be better as '(hwq)' to avoid precedence issues #884: FILE: drivers/infiniband/hw/bng_re/bng_res.h:17: +#define HWQ_FREE_SLOTS(hwq) (hwq->max_elements - \ + ((HWQ_CMP(hwq->prod, hwq)\ + - HWQ_CMP(hwq->cons, hwq))\ + & (hwq->max_elements - 1))) CHECK: Please don't use multiple blank lines #900: FILE: drivers/infiniband/hw/bng_re/bng_res.h:33: + + WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1008: new file mode 100644 WARNING: line length of 98 exceeds 80 columns #1035: FILE: drivers/infiniband/hw/bng_re/bng_tlv.h:23: +#define HAS_TLV_HEADER(msg) (le16_to_cpu(((struct tlv *)(msg))->cmd_discr) == CMD_DISCR_TLV_ENCAP) total: 0 errors, 4 warnings, 7 checks, 1067 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e925172ebb26 ("RDMA/bng_re: Add infrastructure for enabling Firmware channel") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 7 checks, 1067 lines checked