ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.u8rQjqpNSi and /tmp/tmp.d90ukGL5HJ
Tree base:
5189446ba995 ("net: ipv4: fix regression in local-broadcast routes")
Now at:
bbf3035650e2 ("netfilter: nft_flowtable.sh: re-run with random mtu sizes")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/nft_flowtable.sh - 97ed1c3a9028e5fbabf61c0ddfacbdf11133e6f66732fb13ef0c6fb42b70b4aa


In nft_flowtable.sh line 34:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_flowtable.sh line 35:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_flowtable.sh line 48:
ip link add veth0 netns "$nsr1" type veth peer name eth0 netns "$ns1"
                         ^---^ SC2154 (warning): nsr1 is referenced but not assigned.


In nft_flowtable.sh line 49:
ip link add veth1 netns "$nsr1" type veth peer name veth0 netns "$nsr2"
                                                                 ^---^ SC2154 (warning): nsr2 is referenced but not assigned.


In nft_flowtable.sh line 180:
if [ $? -ne 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_flowtable.sh line 200:
if [ $? -ne 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_flowtable.sh line 390:
if [ $? -eq 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In nft_flowtable.sh line 407:
if [ $? -eq 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/nft_flowtable.sh - 97ed1c3a9028e5fbabf61c0ddfacbdf11133e6f66732fb13ef0c6fb42b70b4aa


In nft_flowtable.sh line 35:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_flowtable.sh line 36:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_flowtable.sh line 49:
ip link add veth0 netns "$nsr1" type veth peer name eth0 netns "$ns1"
                         ^---^ SC2154 (warning): nsr1 is referenced but not assigned.


In nft_flowtable.sh line 50:
ip link add veth1 netns "$nsr1" type veth peer name veth0 netns "$nsr2"
                                                                 ^---^ SC2154 (warning): nsr2 is referenced but not assigned.


In nft_flowtable.sh line 185:
if [ $? -ne 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_flowtable.sh line 205:
if [ $? -ne 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_flowtable.sh line 274:
	local pmtud="$2"
              ^---^ SC2034 (warning): pmtud appears unused. Verify use (or export if used externally).


In nft_flowtable.sh line 362:
	if [ $pmtu -eq 0 ]; then
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ "$pmtu" -eq 0 ]; then


In nft_flowtable.sh line 378:
		rc=1
                ^-- SC2034 (warning): rc appears unused. Verify use (or export if used externally).


In nft_flowtable.sh line 415:
if [ $? -eq 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In nft_flowtable.sh line 432:
if [ $? -eq 0 ]; then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- pmtud appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...