CHECK: spinlock_t definition without comment #39: FILE: drivers/net/ppp/pppoe.c:104: + spinlock_t hash_lock; WARNING: line length of 97 exceeds 80 columns #67: FILE: drivers/net/ppp/pppoe.c:182: + first = rcu_dereference_protected(pn->hash_table[hash], lockdep_is_held(&pn->hash_lock)); WARNING: line length of 92 exceeds 80 columns #75: FILE: drivers/net/ppp/pppoe.c:189: + ret = rcu_dereference_protected(ret->next, lockdep_is_held(&pn->hash_lock)); WARNING: line length of 95 exceeds 80 columns #93: FILE: drivers/net/ppp/pppoe.c:204: + ret = rcu_dereference_protected(pn->hash_table[hash], lockdep_is_held(&pn->hash_lock)); WARNING: line length of 90 exceeds 80 columns #103: FILE: drivers/net/ppp/pppoe.c:213: + lockdep_is_held(&pn->hash_lock)); WARNING: line length of 92 exceeds 80 columns #110: FILE: drivers/net/ppp/pppoe.c:219: + ret = rcu_dereference_protected(ret->next, lockdep_is_held(&pn->hash_lock)); WARNING: line length of 84 exceeds 80 columns #148: FILE: drivers/net/ppp/pppoe.c:284: + struct pppox_sock *po = rcu_dereference_protected(pn->hash_table[i], WARNING: line length of 99 exceeds 80 columns #149: FILE: drivers/net/ppp/pppoe.c:285: + lockdep_is_held(&pn->hash_lock)); WARNING: line length of 96 exceeds 80 columns #156: FILE: drivers/net/ppp/pppoe.c:291: + lockdep_is_held(&pn->hash_lock)); WARNING: line length of 88 exceeds 80 columns #177: FILE: drivers/net/ppp/pppoe.c:330: + lockdep_is_held(&pn->hash_lock)); total: 0 errors, 9 warnings, 1 checks, 243 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2d146ee674a7 ("pppoe: remove rwlock usage") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 9 warnings, 1 checks, 243 lines checked