WARNING: externs should be avoided in .c files #131: FILE: tools/testing/selftests/bpf/bench.c:287: +extern struct argp bench_lpm_trie_map_argp; WARNING: externs should be avoided in .c files #147: FILE: tools/testing/selftests/bpf/bench.c:563: +extern const struct bench bench_lpm_trie_noop; WARNING: externs should be avoided in .c files #148: FILE: tools/testing/selftests/bpf/bench.c:564: +extern const struct bench bench_lpm_trie_baseline; WARNING: externs should be avoided in .c files #149: FILE: tools/testing/selftests/bpf/bench.c:565: +extern const struct bench bench_lpm_trie_lookup; WARNING: externs should be avoided in .c files #150: FILE: tools/testing/selftests/bpf/bench.c:566: +extern const struct bench bench_lpm_trie_insert; WARNING: externs should be avoided in .c files #151: FILE: tools/testing/selftests/bpf/bench.c:567: +extern const struct bench bench_lpm_trie_update; WARNING: externs should be avoided in .c files #152: FILE: tools/testing/selftests/bpf/bench.c:568: +extern const struct bench bench_lpm_trie_delete; WARNING: externs should be avoided in .c files #153: FILE: tools/testing/selftests/bpf/bench.c:569: +extern const struct bench bench_lpm_trie_free; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #184: new file mode 100644 CHECK: Alignment should match open parenthesis #344: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:156: + DECLARE_LIBBPF_OPTS(bpf_map_batch_opts, opts, + .elem_flags = 0, CHECK: Alignment should match open parenthesis #361: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:173: + DECLARE_LIBBPF_OPTS(bpf_map_batch_opts, opts, + .elem_flags = 0, CHECK: Alignment should match open parenthesis #478: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:290: + fprintf(stderr, "Unexpected REINIT return code for op %d\n", + ctx.bench->bss->op); ERROR: space prohibited before that close parenthesis ')' #490: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:302: + .data_size_in = sizeof(in), .repeat = 1, ); WARNING: Missing a blank line after declarations #494: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:306: + int fd = bpf_program__fd(ctx.bench->progs.run_bench); + err = bpf_prog_test_run_opts(fd, &opts); WARNING: line length of 89 exceeds 80 columns #514: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:326: + fprintf(stderr, "Unexpected BPF prog return code %d for op %d\n", CHECK: Alignment should match open parenthesis #515: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:327: + fprintf(stderr, "Unexpected BPF prog return code %d for op %d\n", + opts.retval, ctx.bench->bss->op); WARNING: line length of 89 exceeds 80 columns #594: FILE: tools/testing/selftests/bpf/benchs/bench_lpm_trie_map.c:406: + printf("Summary: throughput %8.3lf \u00B1 %5.3lf %c ops/s (%7.3lf%c ops/prod), ", WARNING: line length of 88 exceeds 80 columns #777: FILE: tools/testing/selftests/bpf/progs/lpm_trie.h:28: +#define LPM_BENCH_REINIT_MAP 1 /* Reset trie to initial state for current op */ WARNING: please, no space before tabs #777: FILE: tools/testing/selftests/bpf/progs/lpm_trie.h:28: +#define LPM_BENCH_REINIT_MAP ^I1^I/* Reset trie to initial state for current op */$ WARNING: Improper SPDX comment style for 'tools/testing/selftests/bpf/progs/lpm_trie_map.c', please use '//' instead #1022: FILE: tools/testing/selftests/bpf/progs/lpm_trie_map.c:1: +/* SPDX-License-Identifier: GPL-2.0-or-later */ WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1022: FILE: tools/testing/selftests/bpf/progs/lpm_trie_map.c:1: +/* SPDX-License-Identifier: GPL-2.0-or-later */ total: 1 errors, 16 warnings, 4 checks, 895 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b4ba347e0a66 ("selftests/bpf: Add LPM trie microbenchmarks") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.