========== checkpatch - FAILED WARNING: line length of 84 exceeds 80 columns #58: FILE: net/ipv4/icmp.c:812: + if ( !(ct->status & IPS_SRC_NAT && CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) ERROR: space prohibited after that open parenthesis '(' #58: FILE: net/ipv4/icmp.c:812: + if ( !(ct->status & IPS_SRC_NAT && CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) WARNING: line length of 90 exceeds 80 columns #59: FILE: net/ipv4/icmp.c:813: + && !(ct->status & IPS_DST_NAT && CTINFO2DIR(ctinfo) == IP_CT_DIR_REPLY)) { CHECK: Logical continuations should be on the previous line #59: FILE: net/ipv4/icmp.c:813: + if ( !(ct->status & IPS_SRC_NAT && CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) + && !(ct->status & IPS_DST_NAT && CTINFO2DIR(ctinfo) == IP_CT_DIR_REPLY)) { WARNING: braces {} are not necessary for any arm of this statement #68: FILE: net/ipv4/icmp.c:828: + if (CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) { [...] + } else { [...] WARNING: line length of 90 exceeds 80 columns #69: FILE: net/ipv4/icmp.c:829: + ip_hdr(skb_in)->saddr = ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.u3.ip; WARNING: line length of 87 exceeds 80 columns #71: FILE: net/ipv4/icmp.c:831: + ip_hdr(skb_in)->saddr = ct->tuplehash[IP_CT_DIR_REPLY].tuple.src.u3.ip; total: 1 errors, 5 warnings, 1 checks, 26 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d64f3cb2d2da ("icmp: fix icmp_ndo_send address translation for reply direction") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.