pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.XsGDGYlgt3 and /tmp/tmp.Dyk5PSR3rQ Tree base: 992e9f53a0db ("selftests: drv-net: xdp: make sure we're actually testing native XDP") Now at: ba9ed8d8ed92 ("selftests: drv-net: hds: restore hds settings") ====== Checking before the patch ====== ************* Module hds tools/testing/selftests/drivers/net/hds.py:150:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hds.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hds.py:9:0: E0611: No name 'random' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hds.py:16:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:15:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:24:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:26:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:37:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:36:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:49:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:53:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:57:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:56:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:61:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:65:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:66:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:68:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:72:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:71:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:78:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:82:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:83:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:85:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:89:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:88:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:99:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:100:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:102:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:106:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:105:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:112:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:116:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:122:4: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:135:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:136:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:138:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:115:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:142:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:146:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:152:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:153:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:155:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:145:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:159:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:163:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:162:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:199:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:203:0: E0102: function already defined line 174 (function-redefined) tools/testing/selftests/drivers/net/hds.py:216:0: E0102: function already defined line 187 (function-redefined) tools/testing/selftests/drivers/net/hds.py:228:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:232:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:266:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:270:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:5:0: W0611: Unused import os (unused-import) ------------------------------------------------------------------ Your code has been rated at 6.36/10 (previous run: 6.79/10, -0.43) ====== Checking the tree with the patch ====== ************* Module hds tools/testing/selftests/drivers/net/hds.py:187:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hds.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hds.py:10:0: E0611: No name 'random' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hds.py:17:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:16:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:25:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:27:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:38:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:37:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:50:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:58:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:57:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:89:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:93:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:98:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:99:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:101:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:105:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:104:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:111:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:116:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:117:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:119:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:123:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:122:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:129:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:134:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:135:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:137:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:141:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:140:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:147:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:152:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:158:4: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:171:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:172:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:174:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:151:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:178:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:183:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:189:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:190:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:192:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:182:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:196:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:201:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:200:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:238:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:242:0: E0102: function already defined line 212 (function-redefined) tools/testing/selftests/drivers/net/hds.py:255:0: E0102: function already defined line 226 (function-redefined) tools/testing/selftests/drivers/net/hds.py:267:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:271:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:305:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:309:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:5:0: W0611: Unused import os (unused-import) ------------------------------------------------------------------ Your code has been rated at 6.81/10 (previous run: 6.36/10, +0.45)