WARNING: line length of 92 exceeds 80 columns #31: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:28: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: architecture specific defines should be avoided #31: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:28: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) WARNING: line length of 92 exceeds 80 columns #42: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:47: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: architecture specific defines should be avoided #42: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:47: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: Lines should not end with a '(' #47: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:52: + asm volatile( CHECK: spaces preferred around that '%' (ctx:BxO) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ CHECK: spaces preferred around that '%' (ctx:OxV) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ ERROR: space required after that ',' (ctx:VxO) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ CHECK: spaces preferred around that '%' (ctx:OxO) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ CHECK: spaces preferred around that '%' (ctx:OxV) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ ERROR: space required after that ',' (ctx:VxV) #49: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:54: + STAP_PROBE_ASM(test, usdt_sib, -2@(%%rdx,%%rax,2)) ^ WARNING: line length of 92 exceeds 80 columns #80: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:90: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: architecture specific defines should be avoided #80: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:90: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) WARNING: line length of 93 exceeds 80 columns #83: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:93: + 0 /*self*/, "/proc/self/exe", CHECK: Alignment should match open parenthesis #83: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:93: + skel->links.usdt_sib = bpf_program__attach_usdt(skel->progs.usdt_sib, + 0 /*self*/, "/proc/self/exe", WARNING: line length of 91 exceeds 80 columns #84: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:94: + "test", "usdt_sib", &opts); WARNING: line length of 92 exceeds 80 columns #104: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:189: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: architecture specific defines should be avoided #104: FILE: tools/testing/selftests/bpf/prog_tests/usdt.c:189: +#if ((defined(__x86_64__) || defined(__i386__)) && defined(__GNUC__) && !defined(__clang__)) CHECK: Please don't use multiple blank lines #125: FILE: tools/testing/selftests/bpf/progs/test_usdt.c:110: + total: 2 errors, 6 warnings, 11 checks, 120 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 97d95fb5fc22 ("selftests/bpf: Enrich subtest_basic_usdt case in selftests to cover SIB handling logic") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.