WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #35: FILE: drivers/net/dsa/Kconfig:164: +config NET_DSA_YT921X + tristate "Motorcomm YT9215 ethernet switch chip support" + select NET_DSA_TAG_YT921X + help + This enables support for the Motorcomm YT9215 ethernet switch + chip. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #84: FILE: drivers/net/dsa/yt921x.c:25: +#define YT921X_SMI_SWITCHID(x) FIELD_PREP(YT921X_SMI_SWITCHID_M, (x)) WARNING: line length of 99 exceeds 80 columns #105: FILE: drivers/net/dsa/yt921x.c:46: +#define YT921X_EXT_CPU_PORT_PORT(x) FIELD_PREP(YT921X_EXT_CPU_PORT_PORT_M, (x)) WARNING: line length of 92 exceeds 80 columns #114: FILE: drivers/net/dsa/yt921x.c:55: +#define YT921X_SGMII_MODE(x) FIELD_PREP(YT921X_SGMII_MODE_M, (x)) WARNING: line length of 93 exceeds 80 columns #127: FILE: drivers/net/dsa/yt921x.c:68: +#define YT921X_SGMII_SPEED(x) FIELD_PREP(YT921X_SGMII_SPEED_M, (x)) WARNING: line length of 84 exceeds 80 columns #135: FILE: drivers/net/dsa/yt921x.c:76: +#define YT921X_PORT_LINK BIT(9) /* CTRL: auto negotiation */ WARNING: line length of 92 exceeds 80 columns #136: FILE: drivers/net/dsa/yt921x.c:77: +#define YT921X_PORT_HALF_PAUSE BIT(8) /* Half-duplex back pressure mode */ WARNING: line length of 92 exceeds 80 columns #143: FILE: drivers/net/dsa/yt921x.c:84: +#define YT921X_PORT_SPEED(x) FIELD_PREP(YT921X_PORT_SPEED_M, (x)) WARNING: line length of 100 exceeds 80 columns #157: FILE: drivers/net/dsa/yt921x.c:98: +#define YT921X_MDIO_POLLING_SPEED(x) FIELD_PREP(YT921X_MDIO_POLLING_SPEED_M, (x)) WARNING: line length of 84 exceeds 80 columns #158: FILE: drivers/net/dsa/yt921x.c:99: +#define YT921X_MDIO_POLLING_SPEED_10 YT921X_MDIO_POLLING_SPEED(0) WARNING: line length of 84 exceeds 80 columns #159: FILE: drivers/net/dsa/yt921x.c:100: +#define YT921X_MDIO_POLLING_SPEED_100 YT921X_MDIO_POLLING_SPEED(1) WARNING: line length of 84 exceeds 80 columns #160: FILE: drivers/net/dsa/yt921x.c:101: +#define YT921X_MDIO_POLLING_SPEED_1000 YT921X_MDIO_POLLING_SPEED(2) WARNING: line length of 84 exceeds 80 columns #161: FILE: drivers/net/dsa/yt921x.c:102: +#define YT921X_MDIO_POLLING_SPEED_2500 YT921X_MDIO_POLLING_SPEED(4) WARNING: line length of 89 exceeds 80 columns #168: FILE: drivers/net/dsa/yt921x.c:109: +#define YT921X_XMII_CTRL_EXTIFn(port) BIT(9 - (port)) /* Yes, it's reversed */ WARNING: line length of 91 exceeds 80 columns #171: FILE: drivers/net/dsa/yt921x.c:112: +#define YT921X_XMII_MODE(x) FIELD_PREP(YT921X_XMII_MODE_M, (x)) WARNING: line length of 107 exceeds 80 columns #182: FILE: drivers/net/dsa/yt921x.c:123: +#define YT921X_XMII_RGMII_TX_DELAY_150PS(x) FIELD_PREP(YT921X_XMII_RGMII_TX_DELAY_150PS_M, (x)) WARNING: line length of 107 exceeds 80 columns #188: FILE: drivers/net/dsa/yt921x.c:129: +#define YT921X_XMII_RGMII_RX_DELAY_150PS(x) FIELD_PREP(YT921X_XMII_RGMII_RX_DELAY_150PS_M, (x)) WARNING: line length of 96 exceeds 80 columns #195: FILE: drivers/net/dsa/yt921x.c:136: +#define YT921X_MAC_FRAME_SIZE(x) FIELD_PREP(YT921X_MAC_FRAME_SIZE_M, (x)) WARNING: line length of 95 exceeds 80 columns #206: FILE: drivers/net/dsa/yt921x.c:147: +#define YT921X_MIB_CTRL_PORT(x) FIELD_PREP(YT921X_MIB_CTRL_PORT_M, (x)) WARNING: line length of 97 exceeds 80 columns #215: FILE: drivers/net/dsa/yt921x.c:156: +#define YT921X_EDATA_CTRL_ADDR(x) FIELD_PREP(YT921X_EDATA_CTRL_ADDR_M, (x)) WARNING: line length of 95 exceeds 80 columns #217: FILE: drivers/net/dsa/yt921x.c:158: +#define YT921X_EDATA_CTRL_OP(x) FIELD_PREP(YT921X_EDATA_CTRL_OP_M, (x)) WARNING: line length of 99 exceeds 80 columns #222: FILE: drivers/net/dsa/yt921x.c:163: +#define YT921X_EDATA_DATA_STATUS(x) FIELD_PREP(YT921X_EDATA_DATA_STATUS_M, (x)) WARNING: line length of 83 exceeds 80 columns #223: FILE: drivers/net/dsa/yt921x.c:164: +#define YT921X_EDATA_DATA_IDLE YT921X_EDATA_DATA_STATUS(3) WARNING: line length of 96 exceeds 80 columns #231: FILE: drivers/net/dsa/yt921x.c:172: +#define YT921X_MBUS_CTRL_PORT(x) FIELD_PREP(YT921X_MBUS_CTRL_PORT_M, (x)) WARNING: line length of 95 exceeds 80 columns #233: FILE: drivers/net/dsa/yt921x.c:174: +#define YT921X_MBUS_CTRL_REG(x) FIELD_PREP(YT921X_MBUS_CTRL_REG_M, (x)) WARNING: line length of 96 exceeds 80 columns #235: FILE: drivers/net/dsa/yt921x.c:176: +#define YT921X_MBUS_CTRL_TYPE(x) FIELD_PREP(YT921X_MBUS_CTRL_TYPE_M, (x)) WARNING: line length of 94 exceeds 80 columns #238: FILE: drivers/net/dsa/yt921x.c:179: +#define YT921X_MBUS_CTRL_OP(x) FIELD_PREP(YT921X_MBUS_CTRL_OP_M, (x)) WARNING: line length of 97 exceeds 80 columns #262: FILE: drivers/net/dsa/yt921x.c:203: +#define YT921X_PORT_LEARN_MODE(x) FIELD_PREP(YT921X_PORT_LEARN_MODE_M, (x)) WARNING: line length of 81 exceeds 80 columns #263: FILE: drivers/net/dsa/yt921x.c:204: +#define YT921X_PORT_LEARN_MODE_AUTO YT921X_PORT_LEARN_MODE(0) WARNING: line length of 81 exceeds 80 columns #264: FILE: drivers/net/dsa/yt921x.c:205: +#define YT921X_PORT_LEARN_MODE_AUTO_AND_COPY YT921X_PORT_LEARN_MODE(1) WARNING: line length of 81 exceeds 80 columns #265: FILE: drivers/net/dsa/yt921x.c:206: +#define YT921X_PORT_LEARN_MODE_CPU_CONTROL YT921X_PORT_LEARN_MODE(2) WARNING: line length of 94 exceeds 80 columns #273: FILE: drivers/net/dsa/yt921x.c:214: +#define YT921X_FDB_OP_INDEX(x) FIELD_PREP(YT921X_FDB_OP_INDEX_M, (x)) WARNING: line length of 94 exceeds 80 columns #277: FILE: drivers/net/dsa/yt921x.c:218: +#define YT921X_FDB_OP_FLUSH(x) FIELD_PREP(YT921X_FDB_OP_FLUSH_M, (x)) WARNING: line length of 98 exceeds 80 columns #284: FILE: drivers/net/dsa/yt921x.c:225: +#define YT921X_FDB_OP_NEXT_TYPE(x) FIELD_PREP(YT921X_FDB_OP_NEXT_TYPE_M, (x)) WARNING: line length of 82 exceeds 80 columns #285: FILE: drivers/net/dsa/yt921x.c:226: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST_PORT YT921X_FDB_OP_NEXT_TYPE(0) WARNING: line length of 82 exceeds 80 columns #286: FILE: drivers/net/dsa/yt921x.c:227: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST_VID YT921X_FDB_OP_NEXT_TYPE(1) WARNING: line length of 82 exceeds 80 columns #287: FILE: drivers/net/dsa/yt921x.c:228: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST YT921X_FDB_OP_NEXT_TYPE(2) WARNING: line length of 82 exceeds 80 columns #288: FILE: drivers/net/dsa/yt921x.c:229: +#define YT921X_FDB_OP_NEXT_TYPE_MCAST YT921X_FDB_OP_NEXT_TYPE(3) WARNING: line length of 91 exceeds 80 columns #290: FILE: drivers/net/dsa/yt921x.c:231: +#define YT921X_FDB_OP_OP(x) FIELD_PREP(YT921X_FDB_OP_OP_M, (x)) WARNING: line length of 98 exceeds 80 columns #302: FILE: drivers/net/dsa/yt921x.c:243: +#define YT921X_FDB_RESULT_INDEX(x) FIELD_PREP(YT921X_FDB_RESULT_INDEX_M, (x)) WARNING: line length of 96 exceeds 80 columns #308: FILE: drivers/net/dsa/yt921x.c:249: +#define YT921X_FDB_IO1_STATUS(x) FIELD_PREP(YT921X_FDB_IO1_STATUS_M, (x)) WARNING: line length of 89 exceeds 80 columns #315: FILE: drivers/net/dsa/yt921x.c:256: +#define YT921X_FDB_IO1_FID_M GENMASK(27, 16) /* filtering ID (VID) */ WARNING: line length of 93 exceeds 80 columns #316: FILE: drivers/net/dsa/yt921x.c:257: +#define YT921X_FDB_IO1_FID(x) FIELD_PREP(YT921X_FDB_IO1_FID_M, (x)) WARNING: line length of 99 exceeds 80 columns #322: FILE: drivers/net/dsa/yt921x.c:263: +#define YT921X_FDB_IO2_EGR_PORTS(x) FIELD_PREP(YT921X_FDB_IO2_EGR_PORTS_M, (x)) WARNING: line length of 97 exceeds 80 columns #327: FILE: drivers/net/dsa/yt921x.c:268: +#define YT921X_FDB_IO2_INT_PRI(x) FIELD_PREP(YT921X_FDB_IO2_INT_PRI_M, (x)) WARNING: line length of 97 exceeds 80 columns #329: FILE: drivers/net/dsa/yt921x.c:270: +#define YT921X_FDB_IO2_NEW_VID(x) FIELD_PREP(YT921X_FDB_IO2_NEW_VID_M, (x)) WARNING: line length of 94 exceeds 80 columns #335: FILE: drivers/net/dsa/yt921x.c:276: +#define YT921X_FILTER_PORTS(x) FIELD_PREP(YT921X_FILTER_PORTS_M, (x)) WARNING: line length of 83 exceeds 80 columns #345: FILE: drivers/net/dsa/yt921x.c:286: +#define YT921X_ACT_UNK_ACTn_M(port) GENMASK(2 * (port) + 1, 2 * (port)) WARNING: line length of 84 exceeds 80 columns #347: FILE: drivers/net/dsa/yt921x.c:288: +#define YT921X_ACT_UNK_ACTn_FORWARD(port) YT921X_ACT_UNK_ACTn(port, 0) WARNING: line length of 105 exceeds 80 columns #348: FILE: drivers/net/dsa/yt921x.c:289: +#define YT921X_ACT_UNK_ACTn_TRAP(port) YT921X_ACT_UNK_ACTn(port, 1) /* interrupt CPU */ WARNING: line length of 84 exceeds 80 columns #349: FILE: drivers/net/dsa/yt921x.c:290: +#define YT921X_ACT_UNK_ACTn_DROP(port) YT921X_ACT_UNK_ACTn(port, 2) WARNING: line length of 84 exceeds 80 columns #350: FILE: drivers/net/dsa/yt921x.c:291: +#define YT921X_ACT_UNK_ACTn_COPY(port) YT921X_ACT_UNK_ACTn(port, 3) WARNING: line length of 97 exceeds 80 columns #360: FILE: drivers/net/dsa/yt921x.c:301: +#define YT921X_VLAN_CTRL_PORTS(x) FIELD_PREP(YT921X_VLAN_CTRL_PORTS_M, (x)) WARNING: line length of 104 exceeds 80 columns #367: FILE: drivers/net/dsa/yt921x.c:308: +#define YT921X_VLAN_CTRL1_UNTAG_PORTS(x) FIELD_PREP(YT921X_VLAN_CTRL1_UNTAG_PORTS_M, (x)) WARNING: line length of 99 exceeds 80 columns #370: FILE: drivers/net/dsa/yt921x.c:311: +#define YT921X_VLAN_CTRL1_STP_ID(x) FIELD_PREP(YT921X_VLAN_CTRL1_STP_ID_M, (x)) WARNING: line length of 101 exceeds 80 columns #378: FILE: drivers/net/dsa/yt921x.c:319: +#define YT921X_PORT_VLAN_CTRL_SVID(x) FIELD_PREP(YT921X_PORT_VLAN_CTRL_SVID_M, (x)) WARNING: line length of 101 exceeds 80 columns #380: FILE: drivers/net/dsa/yt921x.c:321: +#define YT921X_PORT_VLAN_CTRL_CVID(x) FIELD_PREP(YT921X_PORT_VLAN_CTRL_CVID_M, (x)) WARNING: line length of 98 exceeds 80 columns #393: FILE: drivers/net/dsa/yt921x.c:334: +#define YT921X_MIRROR_IGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_IGR_PORTS_M, (x)) WARNING: line length of 98 exceeds 80 columns #396: FILE: drivers/net/dsa/yt921x.c:337: +#define YT921X_MIRROR_EGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_EGR_PORTS_M, (x)) WARNING: line length of 93 exceeds 80 columns #399: FILE: drivers/net/dsa/yt921x.c:340: +#define YT921X_MIRROR_PORT(x) FIELD_PREP(YT921X_MIRROR_PORT_M, (x)) WARNING: line length of 90 exceeds 80 columns #401: FILE: drivers/net/dsa/yt921x.c:342: +#define YT921X_REG_END 0x400000 /* as long as reg space is below this */ WARNING: line length of 96 exceeds 80 columns #436: FILE: drivers/net/dsa/yt921x.c:377: + MIB_DESC(1, 0x08, "RxMulticast"), /* rx multicast pkts, excluding pause and OAM */ WARNING: line length of 81 exceeds 80 columns #437: FILE: drivers/net/dsa/yt921x.c:378: + MIB_DESC(1, 0x0c, "RxCrcErr"), /* rx crc err pkts, len >= 64B */ WARNING: line length of 86 exceeds 80 columns #439: FILE: drivers/net/dsa/yt921x.c:380: + MIB_DESC(1, 0x10, "RxAlignErr"), /* rx pkts with odd number of bytes */ WARNING: line length of 85 exceeds 80 columns #444: FILE: drivers/net/dsa/yt921x.c:385: + MIB_DESC(1, 0x20, "RxPktSz65To127"), /* rx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #445: FILE: drivers/net/dsa/yt921x.c:386: + MIB_DESC(1, 0x24, "RxPktSz128To255"), /* rx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #446: FILE: drivers/net/dsa/yt921x.c:387: + MIB_DESC(1, 0x28, "RxPktSz256To511"), /* rx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #447: FILE: drivers/net/dsa/yt921x.c:388: + MIB_DESC(1, 0x2c, "RxPktSz512To1023"), /* rx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #449: FILE: drivers/net/dsa/yt921x.c:390: + MIB_DESC(1, 0x30, "RxPktSz1024To1518"), /* rx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 83 exceeds 80 columns #456: FILE: drivers/net/dsa/yt921x.c:397: + MIB_DESC(2, 0x48, "RxOverSzErr"), /* rx pkts, len > mac frame size */ WARNING: line length of 98 exceeds 80 columns #459: FILE: drivers/net/dsa/yt921x.c:400: + MIB_DESC(1, 0x50, "RxDropped"), /* rx dropped pkts, excluding crc err and pause */ WARNING: line length of 96 exceeds 80 columns #462: FILE: drivers/net/dsa/yt921x.c:403: + MIB_DESC(1, 0x5c, "TxMulticast"), /* tx multicast pkts, excluding pause and OAM */ WARNING: line length of 85 exceeds 80 columns #466: FILE: drivers/net/dsa/yt921x.c:407: + MIB_DESC(1, 0x68, "TxPktSz65To127"), /* tx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #467: FILE: drivers/net/dsa/yt921x.c:408: + MIB_DESC(1, 0x6c, "TxPktSz128To255"), /* tx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #469: FILE: drivers/net/dsa/yt921x.c:410: + MIB_DESC(1, 0x70, "TxPktSz256To511"), /* tx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #470: FILE: drivers/net/dsa/yt921x.c:411: + MIB_DESC(1, 0x74, "TxPktSz512To1023"), /* tx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #471: FILE: drivers/net/dsa/yt921x.c:412: + MIB_DESC(1, 0x78, "TxPktSz1024To1518"), /* tx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 96 exceeds 80 columns #479: FILE: drivers/net/dsa/yt921x.c:420: + MIB_DESC(1, 0x90, "TxExcessiveCollistion"), /* aborted pkts due to too many colls */ WARNING: line length of 92 exceeds 80 columns #480: FILE: drivers/net/dsa/yt921x.c:421: + MIB_DESC(1, 0x94, "TxMultipleCollision"), /* multiple collision for one mac */ WARNING: line length of 86 exceeds 80 columns #484: FILE: drivers/net/dsa/yt921x.c:425: + MIB_DESC(1, 0xa0, "TxDeferred"), /* delayed pkts due to defer signal */ WARNING: quoted string split across lines #847: FILE: drivers/net/dsa/yt921x.c:788: + pr_warn("%s: Read 0xfade at 0x%x, which is a sign of " + "non-existent register; consider reporting a bug if " WARNING: quoted string split across lines #848: FILE: drivers/net/dsa/yt921x.c:789: + "non-existent register; consider reporting a bug if " + "this happens again\n", __func__, reg); WARNING: quoted string split across lines #851: FILE: drivers/net/dsa/yt921x.c:792: + pr_warn("%s: Read 0xdead at 0x%x, which is usually a serious " + "data race condition; consider reporting a bug if " WARNING: quoted string split across lines #852: FILE: drivers/net/dsa/yt921x.c:793: + "data race condition; consider reporting a bug if " + "this happens again\n", __func__, reg); WARNING: quoted string split across lines #2252: FILE: drivers/net/dsa/yt921x.c:2193: + "%s: index 0x%x, mac %02x:%02x:%02x:%02x:%02x:%02x, " + "vid %d, ports 0x%x, status %d\n", WARNING: quoted string split across lines #3047: FILE: drivers/net/dsa/yt921x.c:2988: + "%s: port %d, mode %u, interface %d, speed %d, duplex %d, " + "pause %d, advertising %lx\n", __func__, WARNING: line length of 84 exceeds 80 columns #3285: FILE: drivers/net/dsa/yt921x.c:3226: + YT921X_EXT_CPU_PORT_PORT(__fls(priv->active_cpu_ports_mask)); WARNING: line length of 94 exceeds 80 columns #3464: FILE: drivers/net/dsa/yt921x.c:3405: + .preferred_default_local_cpu_port = yt921x_dsa_preferred_default_local_cpu_port, total: 0 errors, 89 warnings, 0 checks, 3602 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4d30d983b5ef ("net: dsa: yt921x: Add support for Motorcomm YT921x") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 89 warnings, 0 checks, 3602 lines checked