ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.EkvOseq6S1 and /tmp/tmp.IZWhrun3me Tree base: da114122b831 ("net: ethernet: stmmac: dwmac-rk: Make the clk_phy could be used for external phy") Now at: f5437425a299 ("selftests: rtnetlink: print device info on preferred_lft test failure") ====== Checking before the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 56: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 70: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 86: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 87: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 105: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 106: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 113: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 114: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 124: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 129: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 152: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 155: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 157: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 185: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 200: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 201: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 202: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 203: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 210: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 212: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 238: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 255: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 264: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 288: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 300: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 311: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 326: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 328: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 332: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 333: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 338: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 365: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 380: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 387: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 412: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 425: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 427: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 430: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 435: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 444: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 457: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 459: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 490: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 502: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 504: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 509: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 514: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 521: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 534: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 536: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 545: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 553: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 555: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 558: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 568: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 586: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 588: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 591: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 603: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 635: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 637: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 643: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 644: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 648: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 650: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 653: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 654: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 657: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 658: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 659: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 661: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 662: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 665: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 666: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 670: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 671: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 675: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 676: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 678: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 680: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 681: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 684: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 685: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 686: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 687: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 692: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 694: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 736: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 738: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 744: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 746: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 748: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 749: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 750: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 754: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 763: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 764: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 767: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 768: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 771: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 772: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 773: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 775: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 776: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 777: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 779: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 785: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 786: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 792: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 794: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 797: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 806: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 814: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 815: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 825: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 838: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 840: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 844: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 847: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 856: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 863: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 879: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 881: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 885: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 888: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 897: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 904: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 919: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 921: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 924: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 926: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 936: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 946: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 953: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 968: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 970: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 973: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 975: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 985: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 995: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1004: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1024: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1026: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1030: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1032: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1036: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1038: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1039: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1040: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1041: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1042: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1043: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1044: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1046: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1048: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1064: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1066: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1070: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1072: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1076: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1077: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1078: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1079: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1080: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1081: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1082: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1083: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1085: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1087: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1103: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1105: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1109: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1110: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1111: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1114: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1115: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1116: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1119: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1120: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1121: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1124: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1125: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1126: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1128: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1144: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1146: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1152: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1154: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1156: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1157: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1159: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1160: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1171: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1252: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1269: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1278: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1280: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1283: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1284: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1285: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1286: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1287: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1307: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1308: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1310: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1313: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1319: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1320: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1328: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1342: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1344: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1348: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1349: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1350: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1351: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1352: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1353: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1359: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1364: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1370: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1371: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1372: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1374: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1377: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1380: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1387: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1449: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1464: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 56: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 70: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 86: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 87: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 105: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 106: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 113: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 114: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 124: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 129: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 152: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 155: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 157: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 185: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 200: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 201: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 202: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 203: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 210: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 212: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 238: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 255: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 264: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 288: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 300: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 311: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 328: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 330: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 334: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 335: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 340: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 367: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 382: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 389: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 414: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 427: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 429: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 432: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 437: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 446: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 459: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 461: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 492: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 504: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 506: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 511: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 516: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 523: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 536: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 538: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 547: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 555: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 557: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 560: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 570: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 588: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 590: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 593: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 605: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 637: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 639: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 645: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 646: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 650: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 652: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 655: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 656: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 659: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 660: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 661: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 663: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 664: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 667: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 668: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 672: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 673: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 677: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 678: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 680: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 682: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 683: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 686: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 687: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 688: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 689: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 694: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 696: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 738: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 740: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 746: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 748: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 750: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 751: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 752: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 756: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 765: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 766: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 769: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 770: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 773: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 774: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 775: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 777: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 778: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 779: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 781: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 787: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 788: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 794: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 796: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 799: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 808: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 816: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 817: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 827: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 840: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 842: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 846: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 849: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 858: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 865: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 881: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 883: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 887: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 890: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 899: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 906: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 921: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 923: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 926: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 928: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 938: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 948: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 955: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 970: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 972: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 975: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 977: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 987: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 997: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1006: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1026: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1028: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1032: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1034: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1038: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1040: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1041: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1042: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1043: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1044: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1045: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1046: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1048: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1050: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1066: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1068: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1072: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1074: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1078: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1079: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1080: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1081: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1082: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1083: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1084: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1085: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1087: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1089: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1105: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1107: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1111: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1112: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1113: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1116: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1117: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1118: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1121: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1122: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1123: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1126: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1127: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1128: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1130: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1146: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1148: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1154: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1156: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1158: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1159: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1161: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1162: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1173: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1254: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1271: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1280: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1282: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1285: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1286: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1287: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1288: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1289: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1309: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1310: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1312: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1315: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1321: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1322: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1330: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1344: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1346: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1350: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1351: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1352: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1353: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1354: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1355: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1361: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1366: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1372: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1373: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1374: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1376: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1379: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1382: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1389: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1451: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1466: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi...