WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 WARNING: line length of 82 exceeds 80 columns #124: FILE: net/quic/path.c:50: + struct quic_udp_sock *us = container_of(work, struct quic_udp_sock, work); WARNING: line length of 81 exceeds 80 columns #127: FILE: net/quic/path.c:53: + head = quic_udp_sock_head(sock_net(us->sk), ntohs(us->addr.v4.sin_port)); WARNING: line length of 86 exceeds 80 columns #135: FILE: net/quic/path.c:61: +static struct quic_udp_sock *quic_udp_sock_create(struct sock *sk, union quic_addr *a) WARNING: line length of 95 exceeds 80 columns #183: FILE: net/quic/path.c:109: +/* Lookup a quic_udp_sock in the global hash table. If not found, creates and returns a new one WARNING: line length of 96 exceeds 80 columns #186: FILE: net/quic/path.c:112: +static struct quic_udp_sock *quic_udp_sock_lookup(struct sock *sk, union quic_addr *a, u16 port) WARNING: line length of 89 exceeds 80 columns #276: FILE: net/quic/path.c:202: + * Promotes the alternate path (path[1]) to become the new active path (path[0]). If the WARNING: line length of 90 exceeds 80 columns #277: FILE: net/quic/path.c:203: + * alternate path has a valid UDP socket, the entire path is swapped. Otherwise, only the WARNING: line length of 93 exceeds 80 columns #278: FILE: net/quic/path.c:204: + * destination address is exchanged, assuming the source address is the same and no rebind is WARNING: line length of 87 exceeds 80 columns #302: FILE: net/quic/path.c:228: + * This is used for cleanup during error handling or when the path is no longer needed. WARNING: line length of 92 exceeds 80 columns #317: FILE: net/quic/path.c:243: + * If the new source or destination address differs from the active path, and alternate path WARNING: line length of 93 exceeds 80 columns #318: FILE: net/quic/path.c:244: + * detection is not disabled, the function updates the alternate path slot (path[1]) with the WARNING: line length of 93 exceeds 80 columns #321: FILE: net/quic/path.c:247: + * This is typically called on packet receive to detect new possible network paths (e.g., NAT WARNING: line length of 97 exceeds 80 columns #326: FILE: net/quic/path.c:252: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 98 exceeds 80 columns #329: FILE: net/quic/path.c:255: + if ((!quic_cmp_sk_addr(sk, quic_path_saddr(paths, 0), sa) && !paths->disable_saddr_alt) || WARNING: line length of 98 exceeds 80 columns #330: FILE: net/quic/path.c:256: + (!quic_cmp_sk_addr(sk, quic_path_daddr(paths, 0), da) && !paths->disable_daddr_alt)) { WARNING: line length of 87 exceeds 80 columns #345: FILE: net/quic/path.c:271: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 87 exceeds 80 columns #354: FILE: net/quic/path.c:280: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 92 exceeds 80 columns #383: FILE: net/quic/path.c:309: + * Called immediately after sending a probe packet in QUIC Path MTU Discovery. Tracks probe WARNING: line length of 93 exceeds 80 columns #384: FILE: net/quic/path.c:310: + * count and manages state transitions based on the number of probes sent and current PLPMTUD WARNING: line length of 92 exceeds 80 columns #385: FILE: net/quic/path.c:311: + * state (BASE, SEARCH, COMPLETE, ERROR). Detects probe failures and black holes, adjusting WARNING: line length of 99 exceeds 80 columns #400: FILE: net/quic/path.c:326: + if (paths->pl.probe_size == QUIC_BASE_PLPMTU) { /* BASE_PLPMTU Confirming Failed */ WARNING: line length of 87 exceeds 80 columns #407: FILE: net/quic/path.c:333: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 87 exceeds 80 columns #419: FILE: net/quic/path.c:345: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 86 exceeds 80 columns #420: FILE: net/quic/path.c:346: + paths->pl.state = QUIC_PL_BASE; /* Search Complete -> Base */ WARNING: line length of 91 exceeds 80 columns #429: FILE: net/quic/path.c:355: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #430: FILE: net/quic/path.c:356: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 90 exceeds 80 columns #437: FILE: net/quic/path.c:363: + * Called when a probe packet is acknowledged. Updates probe size and transitions state if WARNING: line length of 86 exceeds 80 columns #438: FILE: net/quic/path.c:364: + * needed (e.g., from SEARCH to COMPLETE). Expands PMTU using binary or linear search WARNING: line length of 87 exceeds 80 columns #443: FILE: net/quic/path.c:369: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete) WARNING: line length of 91 exceeds 80 columns #447: FILE: net/quic/path.c:373: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #448: FILE: net/quic/path.c:374: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 89 exceeds 80 columns #467: FILE: net/quic/path.c:393: + (u16)min(paths->pl.probe_size + QUIC_PL_BIG_STEP, WARNING: line length of 91 exceeds 80 columns #477: FILE: net/quic/path.c:403: + paths->pl.state = QUIC_PL_COMPLETE; /* Search -> Search Complete */ WARNING: line length of 83 exceeds 80 columns #484: FILE: net/quic/path.c:410: + /* Raise probe_size again after 30 * interval in Search Complete */ WARNING: line length of 81 exceeds 80 columns #485: FILE: net/quic/path.c:411: + paths->pl.state = QUIC_PL_SEARCH; /* Search Complete -> Search */ WARNING: line length of 88 exceeds 80 columns #486: FILE: net/quic/path.c:412: + paths->pl.probe_size = (u16)min(paths->pl.probe_size + QUIC_PL_MIN_STEP, WARNING: line length of 90 exceeds 80 columns #496: FILE: net/quic/path.c:422: + * Responds to an incoming ICMP error by reducing the probe size or falling back to a safe WARNING: line length of 89 exceeds 80 columns #497: FILE: net/quic/path.c:423: + * baseline PMTU depending on current state. Also handles cases where the PMTU hint lies WARNING: line length of 83 exceeds 80 columns #502: FILE: net/quic/path.c:428: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer) WARNING: line length of 90 exceeds 80 columns #506: FILE: net/quic/path.c:432: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, ptb: %d\n", __func__, paths, WARNING: line length of 92 exceeds 80 columns #529: FILE: net/quic/path.c:455: + } else if (pmtu > (u32)paths->pl.pmtu && pmtu < (u32)paths->pl.probe_size) { WARNING: line length of 92 exceeds 80 columns #550: FILE: net/quic/path.c:476: + * Resets all PLPMTUD-related state to its initial configuration. Called when a new path is WARNING: line length of 90 exceeds 80 columns #563: FILE: net/quic/path.c:489: + * Checks whether the last probe (tracked by .number) has been acknowledged. If the probe WARNING: line length of 83 exceeds 80 columns #568: FILE: net/quic/path.c:494: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest) WARNING: line length of 95 exceeds 80 columns #570: FILE: net/quic/path.c:496: + return paths->pl.number && paths->pl.number >= smallest && paths->pl.number <= largest; WARNING: line length of 87 exceeds 80 columns #632: FILE: net/quic/path.h:40: + QUIC_PATH_ALT_NONE, /* No alternate path (migration complete or aborted) */ WARNING: line length of 85 exceeds 80 columns #633: FILE: net/quic/path.h:41: + QUIC_PATH_ALT_PENDING, /* Waiting for a new destination CID for migration */ WARNING: line length of 84 exceeds 80 columns #634: FILE: net/quic/path.h:42: + QUIC_PATH_ALT_PROBING, /* Validating the alternate path (PATH_CHALLENGE) */ WARNING: line length of 81 exceeds 80 columns #635: FILE: net/quic/path.h:43: + QUIC_PATH_ALT_SWAPPED, /* Alternate path is now active; roles swapped */ WARNING: line length of 84 exceeds 80 columns #639: FILE: net/quic/path.h:47: + struct work_struct work; /* Workqueue to destroy UDP tunnel socket */ WARNING: line length of 90 exceeds 80 columns #640: FILE: net/quic/path.h:48: + struct hlist_node node; /* Entry in address-based UDP socket hash table */ WARNING: line length of 93 exceeds 80 columns #650: FILE: net/quic/path.h:58: + struct quic_udp_sock *udp_sk; /* Wrapped UDP socket used to receive QUIC packets */ WARNING: line length of 82 exceeds 80 columns #655: FILE: net/quic/path.h:63: + struct quic_conn_id retry_dcid; /* Source CID from Retry packet */ WARNING: line length of 88 exceeds 80 columns #656: FILE: net/quic/path.h:64: + struct quic_conn_id orig_dcid; /* Destination CID from first Initial */ WARNING: line length of 92 exceeds 80 columns #660: FILE: net/quic/path.h:68: + struct quic_path path[2]; /* Active path (0) and alternate path (1) */ WARNING: line length of 86 exceeds 80 columns #661: FILE: net/quic/path.h:69: + struct flowi fl; /* Flow info from routing decisions */ WARNING: line length of 82 exceeds 80 columns #668: FILE: net/quic/path.h:76: + u32 mtu_info; /* PMTU value from received ICMP, pending apply */ WARNING: line length of 92 exceeds 80 columns #680: FILE: net/quic/path.h:88: + u8 disable_saddr_alt:1; /* Remote disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 91 exceeds 80 columns #681: FILE: net/quic/path.h:89: + u8 disable_daddr_alt:1; /* Local disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 86 exceeds 80 columns #682: FILE: net/quic/path.h:90: + u8 pref_addr:1; /* Preferred address offered (rfc9000#section-18.2) */ WARNING: line length of 90 exceeds 80 columns #684: FILE: net/quic/path.h:92: + u8 alt_state; /* State for alternate path migration logic (see above) */ WARNING: line length of 86 exceeds 80 columns #693: FILE: net/quic/path.h:101: +static inline union quic_addr *quic_path_saddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #704: FILE: net/quic/path.h:112: +static inline union quic_addr *quic_path_daddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #715: FILE: net/quic/path.h:123: +static inline union quic_addr *quic_path_uaddr(struct quic_path_group *paths, u8 path) WARNING: line length of 82 exceeds 80 columns #720: FILE: net/quic/path.h:128: +static inline struct sock *quic_path_usock(struct quic_path_group *paths, u8 path) WARNING: line length of 83 exceeds 80 columns #730: FILE: net/quic/path.h:138: +static inline void quic_path_set_alt_state(struct quic_path_group *paths, u8 state) WARNING: line length of 84 exceeds 80 columns #735: FILE: net/quic/path.h:143: +/* Returns the destination Connection ID (DCID) used for identifying the connection. WARNING: line length of 88 exceeds 80 columns #736: FILE: net/quic/path.h:144: + * Per rfc9000#section-7.3, handshake packets are considered part of the same connection WARNING: line length of 85 exceeds 80 columns #739: FILE: net/quic/path.h:147: +static inline struct quic_conn_id *quic_path_orig_dcid(struct quic_path_group *paths) WARNING: line length of 97 exceeds 80 columns #744: FILE: net/quic/path.h:152: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 88 exceeds 80 columns #750: FILE: net/quic/path.h:158: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete); WARNING: line length of 84 exceeds 80 columns #751: FILE: net/quic/path.h:159: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer); WARNING: line length of 88 exceeds 80 columns #754: FILE: net/quic/path.h:162: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 88 exceeds 80 columns #755: FILE: net/quic/path.h:163: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 84 exceeds 80 columns #756: FILE: net/quic/path.h:164: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest); total: 0 errors, 76 warnings, 0 checks, 745 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4137a6dec871 ("quic: add path management") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 76 warnings, 0 checks, 745 lines checked