CHECK: Unnecessary parentheses around queue->ctrl->ctrl #42: FILE: drivers/nvme/host/tcp.c:1317: + enum nvme_ctrl_state state = nvme_ctrl_state(&(queue->ctrl->ctrl)); WARNING: line length of 82 exceeds 80 columns #58: FILE: drivers/nvme/host/tcp.c:1360: + nvme_change_ctrl_state(&(queue->ctrl->ctrl), NVME_CTRL_RESETTING); CHECK: Unnecessary parentheses around queue->ctrl->ctrl #58: FILE: drivers/nvme/host/tcp.c:1360: + nvme_change_ctrl_state(&(queue->ctrl->ctrl), NVME_CTRL_RESETTING); CHECK: Unnecessary parentheses around queue->ctrl->ctrl #63: FILE: drivers/nvme/host/tcp.c:1365: + ret = nvme_tcp_start_tls(&(queue->ctrl->ctrl), WARNING: line length of 83 exceeds 80 columns #80: FILE: drivers/nvme/host/tcp.c:1411: + enum nvme_ctrl_state state = nvme_ctrl_state(&(queue->ctrl->ctrl)); CHECK: Unnecessary parentheses around queue->ctrl->ctrl #80: FILE: drivers/nvme/host/tcp.c:1411: + enum nvme_ctrl_state state = nvme_ctrl_state(&(queue->ctrl->ctrl)); CHECK: Alignment should match open parenthesis #91: FILE: drivers/nvme/host/tcp.c:1427: + if (result == -EKEYEXPIRED && + state != NVME_CTRL_CONNECTING && WARNING: line length of 98 exceeds 80 columns #98: FILE: drivers/nvme/host/tcp.c:1434: + nvme_change_ctrl_state(&(queue->ctrl->ctrl), NVME_CTRL_RESETTING); CHECK: Unnecessary parentheses around queue->ctrl->ctrl #98: FILE: drivers/nvme/host/tcp.c:1434: + nvme_change_ctrl_state(&(queue->ctrl->ctrl), NVME_CTRL_RESETTING); WARNING: line length of 81 exceeds 80 columns #103: FILE: drivers/nvme/host/tcp.c:1439: + result = nvme_tcp_start_tls(&(queue->ctrl->ctrl), CHECK: Unnecessary parentheses around queue->ctrl->ctrl #103: FILE: drivers/nvme/host/tcp.c:1439: + result = nvme_tcp_start_tls(&(queue->ctrl->ctrl), WARNING: line length of 91 exceeds 80 columns #104: FILE: drivers/nvme/host/tcp.c:1440: + queue, queue->ctrl->ctrl.tls_pskid, CHECK: Alignment should match open parenthesis #104: FILE: drivers/nvme/host/tcp.c:1440: + result = nvme_tcp_start_tls(&(queue->ctrl->ctrl), + queue, queue->ctrl->ctrl.tls_pskid, WARNING: line length of 92 exceeds 80 columns #105: FILE: drivers/nvme/host/tcp.c:1441: + HANDSHAKE_KEY_UPDATE_TYPE_RECEIVED); WARNING: line length of 90 exceeds 80 columns #109: FILE: drivers/nvme/host/tcp.c:1445: + "failed to update the keys %d\n", result); total: 0 errors, 7 warnings, 8 checks, 113 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit fa89017839ea ("nvme-tcp: Support KeyUpdate") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 7 warnings, 8 checks, 113 lines checked