WARNING: line length of 82 exceeds 80 columns #65: FILE: tools/lib/bpf/usdt.bpf.h:73: +/* Helpers to (un)pack SIB extras from idx_packed without relying on bitfields. */ WARNING: line length of 83 exceeds 80 columns #93: FILE: tools/lib/bpf/usdt.bpf.h:234: + * is in arg_spec->val_off, the scale factor is in arg_spec->scale. WARNING: line length of 81 exceeds 80 columns #97: FILE: tools/lib/bpf/usdt.bpf.h:238: + * base address and the offset to get the final address. Finally, WARNING: line length of 96 exceeds 80 columns #103: FILE: tools/lib/bpf/usdt.bpf.h:244: + err = bpf_probe_read_kernel(&val, sizeof(val), (void *)ctx + arg_spec->reg_off); WARNING: line length of 86 exceeds 80 columns #106: FILE: tools/lib/bpf/usdt.bpf.h:247: + err = bpf_probe_read_kernel(&idx, sizeof(idx), (void *)ctx + idx_off); WARNING: line length of 108 exceeds 80 columns #109: FILE: tools/lib/bpf/usdt.bpf.h:250: + err = bpf_probe_read_user(&val, sizeof(val), (void *)val + idx * scale + arg_spec->val_off); WARNING: line length of 82 exceeds 80 columns #142: FILE: tools/lib/bpf/usdt.c:220: +/* Helpers to (un)pack SIB extras from idx_packed without relying on bitfields. */ WARNING: line length of 87 exceeds 80 columns #144: FILE: tools/lib/bpf/usdt.c:222: + ((__u16)(((__u16)((idx_off) & 0x0fff)) << 4) | (__u16)((scale_shift) & 0x000f)) WARNING: line length of 86 exceeds 80 columns #162: FILE: tools/lib/bpf/usdt.c:1299: + arg_sz, &off, reg_name, idx_reg_name, &scale, &len) == 5 || CHECK: Alignment should match open parenthesis #162: FILE: tools/lib/bpf/usdt.c:1299: + if (sscanf(arg_str, " %d @ %ld ( %%%15[^,] , %%%15[^,] , %d ) %n", + arg_sz, &off, reg_name, idx_reg_name, &scale, &len) == 5 || CHECK: Alignment should match open parenthesis #164: FILE: tools/lib/bpf/usdt.c:1301: + sscanf(arg_str, " %d @ ( %%%15[^,] , %%%15[^,] , %d ) %n", + arg_sz, reg_name, idx_reg_name, &scale, &len) == 4 || CHECK: Alignment should match open parenthesis #166: FILE: tools/lib/bpf/usdt.c:1303: + sscanf(arg_str, " %d @ %ld ( %%%15[^,] , %%%15[^)] ) %n", + arg_sz, &off, reg_name, idx_reg_name, &len) == 4 || CHECK: Alignment should match open parenthesis #168: FILE: tools/lib/bpf/usdt.c:1305: + sscanf(arg_str, " %d @ ( %%%15[^,] , %%%15[^)] ) %n", + arg_sz, reg_name, idx_reg_name, &len) == 3 CHECK: braces {} should be used on all arms of this statement #190: FILE: tools/lib/bpf/usdt.c:1326: + if (scale == 1) [...] + else if (scale == 2) [...] + else if (scale == 4) [...] + else if (scale == 8) [...] + else { [...] CHECK: Unbalanced braces around else statement #198: FILE: tools/lib/bpf/usdt.c:1334: + else { WARNING: line length of 106 exceeds 80 columns #199: FILE: tools/lib/bpf/usdt.c:1335: + pr_warn("usdt: invalid SIB scale %d, expected 1,2,4,8; defaulting to 1\n", scale); total: 0 errors, 10 warnings, 6 checks, 176 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 64ec26947a71 ("libbpf: fix USDT SIB argument handling causing unrecognized register error") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 10 warnings, 6 checks, 176 lines checked