WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #35: FILE: drivers/net/dsa/Kconfig:156: +config NET_DSA_YT921X + tristate "Motorcomm YT9215 ethernet switch chip support" + select NET_DSA_TAG_YT921X + help + This enables support for the Motorcomm YT9215 ethernet switch + chip. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #85: FILE: drivers/net/dsa/yt921x.c:26: +#define YT921X_SMI_SWITCHID(x) FIELD_PREP(YT921X_SMI_SWITCHID_M, (x)) WARNING: line length of 99 exceeds 80 columns #106: FILE: drivers/net/dsa/yt921x.c:47: +#define YT921X_EXT_CPU_PORT_PORT(x) FIELD_PREP(YT921X_EXT_CPU_PORT_PORT_M, (x)) WARNING: line length of 92 exceeds 80 columns #115: FILE: drivers/net/dsa/yt921x.c:56: +#define YT921X_SGMII_MODE(x) FIELD_PREP(YT921X_SGMII_MODE_M, (x)) WARNING: line length of 93 exceeds 80 columns #128: FILE: drivers/net/dsa/yt921x.c:69: +#define YT921X_SGMII_SPEED(x) FIELD_PREP(YT921X_SGMII_SPEED_M, (x)) WARNING: line length of 84 exceeds 80 columns #136: FILE: drivers/net/dsa/yt921x.c:77: +#define YT921X_PORT_LINK BIT(9) /* CTRL: auto negotiation */ WARNING: line length of 92 exceeds 80 columns #137: FILE: drivers/net/dsa/yt921x.c:78: +#define YT921X_PORT_HALF_PAUSE BIT(8) /* Half-duplex back pressure mode */ WARNING: line length of 92 exceeds 80 columns #144: FILE: drivers/net/dsa/yt921x.c:85: +#define YT921X_PORT_SPEED(x) FIELD_PREP(YT921X_PORT_SPEED_M, (x)) WARNING: line length of 100 exceeds 80 columns #158: FILE: drivers/net/dsa/yt921x.c:99: +#define YT921X_MDIO_POLLING_SPEED(x) FIELD_PREP(YT921X_MDIO_POLLING_SPEED_M, (x)) WARNING: line length of 84 exceeds 80 columns #159: FILE: drivers/net/dsa/yt921x.c:100: +#define YT921X_MDIO_POLLING_SPEED_10 YT921X_MDIO_POLLING_SPEED(0) WARNING: line length of 84 exceeds 80 columns #160: FILE: drivers/net/dsa/yt921x.c:101: +#define YT921X_MDIO_POLLING_SPEED_100 YT921X_MDIO_POLLING_SPEED(1) WARNING: line length of 84 exceeds 80 columns #161: FILE: drivers/net/dsa/yt921x.c:102: +#define YT921X_MDIO_POLLING_SPEED_1000 YT921X_MDIO_POLLING_SPEED(2) WARNING: line length of 84 exceeds 80 columns #162: FILE: drivers/net/dsa/yt921x.c:103: +#define YT921X_MDIO_POLLING_SPEED_2500 YT921X_MDIO_POLLING_SPEED(4) WARNING: line length of 89 exceeds 80 columns #166: FILE: drivers/net/dsa/yt921x.c:107: +#define YT921X_EXTIF_SEL_EXTIFn_XMII(port) BIT(9 - (port)) /* Yes, it's reversed */ WARNING: line length of 97 exceeds 80 columns #169: FILE: drivers/net/dsa/yt921x.c:110: +#define YT921X_EXTIF_MODE_MODE(x) FIELD_PREP(YT921X_EXTIF_MODE_MODE_M, (x)) WARNING: line length of 81 exceeds 80 columns #170: FILE: drivers/net/dsa/yt921x.c:111: +#define YT921X_EXTIF_MODE_MODE_MII YT921X_EXTIF_MODE_MODE(0) WARNING: line length of 81 exceeds 80 columns #171: FILE: drivers/net/dsa/yt921x.c:112: +#define YT921X_EXTIF_MODE_MODE_REVMII YT921X_EXTIF_MODE_MODE(1) WARNING: line length of 81 exceeds 80 columns #172: FILE: drivers/net/dsa/yt921x.c:113: +#define YT921X_EXTIF_MODE_MODE_RMII YT921X_EXTIF_MODE_MODE(2) WARNING: line length of 81 exceeds 80 columns #173: FILE: drivers/net/dsa/yt921x.c:114: +#define YT921X_EXTIF_MODE_MODE_REVRMII YT921X_EXTIF_MODE_MODE(3) WARNING: line length of 81 exceeds 80 columns #174: FILE: drivers/net/dsa/yt921x.c:115: +#define YT921X_EXTIF_MODE_MODE_RGMII YT921X_EXTIF_MODE_MODE(4) WARNING: line length of 81 exceeds 80 columns #175: FILE: drivers/net/dsa/yt921x.c:116: +#define YT921X_EXTIF_MODE_MODE_DISABLE YT921X_EXTIF_MODE_MODE(5) WARNING: line length of 96 exceeds 80 columns #180: FILE: drivers/net/dsa/yt921x.c:121: +#define YT921X_MAC_FRAME_SIZE(x) FIELD_PREP(YT921X_MAC_FRAME_SIZE_M, (x)) WARNING: line length of 95 exceeds 80 columns #191: FILE: drivers/net/dsa/yt921x.c:132: +#define YT921X_MIB_CTRL_PORT(x) FIELD_PREP(YT921X_MIB_CTRL_PORT_M, (x)) WARNING: line length of 97 exceeds 80 columns #200: FILE: drivers/net/dsa/yt921x.c:141: +#define YT921X_EDATA_CTRL_ADDR(x) FIELD_PREP(YT921X_EDATA_CTRL_ADDR_M, (x)) WARNING: line length of 95 exceeds 80 columns #202: FILE: drivers/net/dsa/yt921x.c:143: +#define YT921X_EDATA_CTRL_OP(x) FIELD_PREP(YT921X_EDATA_CTRL_OP_M, (x)) WARNING: line length of 99 exceeds 80 columns #207: FILE: drivers/net/dsa/yt921x.c:148: +#define YT921X_EDATA_DATA_STATUS(x) FIELD_PREP(YT921X_EDATA_DATA_STATUS_M, (x)) WARNING: line length of 83 exceeds 80 columns #208: FILE: drivers/net/dsa/yt921x.c:149: +#define YT921X_EDATA_DATA_IDLE YT921X_EDATA_DATA_STATUS(3) WARNING: line length of 96 exceeds 80 columns #216: FILE: drivers/net/dsa/yt921x.c:157: +#define YT921X_MBUS_CTRL_PORT(x) FIELD_PREP(YT921X_MBUS_CTRL_PORT_M, (x)) WARNING: line length of 95 exceeds 80 columns #218: FILE: drivers/net/dsa/yt921x.c:159: +#define YT921X_MBUS_CTRL_REG(x) FIELD_PREP(YT921X_MBUS_CTRL_REG_M, (x)) WARNING: line length of 96 exceeds 80 columns #220: FILE: drivers/net/dsa/yt921x.c:161: +#define YT921X_MBUS_CTRL_TYPE(x) FIELD_PREP(YT921X_MBUS_CTRL_TYPE_M, (x)) WARNING: line length of 94 exceeds 80 columns #223: FILE: drivers/net/dsa/yt921x.c:164: +#define YT921X_MBUS_CTRL_OP(x) FIELD_PREP(YT921X_MBUS_CTRL_OP_M, (x)) WARNING: line length of 97 exceeds 80 columns #247: FILE: drivers/net/dsa/yt921x.c:188: +#define YT921X_PORT_LEARN_MODE(x) FIELD_PREP(YT921X_PORT_LEARN_MODE_M, (x)) WARNING: line length of 81 exceeds 80 columns #248: FILE: drivers/net/dsa/yt921x.c:189: +#define YT921X_PORT_LEARN_MODE_AUTO YT921X_PORT_LEARN_MODE(0) WARNING: line length of 81 exceeds 80 columns #249: FILE: drivers/net/dsa/yt921x.c:190: +#define YT921X_PORT_LEARN_MODE_AUTO_AND_COPY YT921X_PORT_LEARN_MODE(1) WARNING: line length of 81 exceeds 80 columns #250: FILE: drivers/net/dsa/yt921x.c:191: +#define YT921X_PORT_LEARN_MODE_CPU_CONTROL YT921X_PORT_LEARN_MODE(2) WARNING: line length of 94 exceeds 80 columns #256: FILE: drivers/net/dsa/yt921x.c:197: +#define YT921X_FDB_OP_INDEX(x) FIELD_PREP(YT921X_FDB_OP_INDEX_M, (x)) WARNING: line length of 85 exceeds 80 columns #257: FILE: drivers/net/dsa/yt921x.c:198: +#define YT921X_FDB_OP_MODE_INDEX BIT(10) /* hash from addr / index */ WARNING: line length of 94 exceeds 80 columns #260: FILE: drivers/net/dsa/yt921x.c:201: +#define YT921X_FDB_OP_FLUSH(x) FIELD_PREP(YT921X_FDB_OP_FLUSH_M, (x)) WARNING: line length of 98 exceeds 80 columns #267: FILE: drivers/net/dsa/yt921x.c:208: +#define YT921X_FDB_OP_NEXT_TYPE(x) FIELD_PREP(YT921X_FDB_OP_NEXT_TYPE_M, (x)) WARNING: line length of 82 exceeds 80 columns #268: FILE: drivers/net/dsa/yt921x.c:209: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST_PORT YT921X_FDB_OP_NEXT_TYPE(0) WARNING: line length of 82 exceeds 80 columns #269: FILE: drivers/net/dsa/yt921x.c:210: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST_VID YT921X_FDB_OP_NEXT_TYPE(1) WARNING: line length of 82 exceeds 80 columns #270: FILE: drivers/net/dsa/yt921x.c:211: +#define YT921X_FDB_OP_NEXT_TYPE_UCAST YT921X_FDB_OP_NEXT_TYPE(2) WARNING: line length of 82 exceeds 80 columns #271: FILE: drivers/net/dsa/yt921x.c:212: +#define YT921X_FDB_OP_NEXT_TYPE_MCAST YT921X_FDB_OP_NEXT_TYPE(3) WARNING: line length of 91 exceeds 80 columns #273: FILE: drivers/net/dsa/yt921x.c:214: +#define YT921X_FDB_OP_OP(x) FIELD_PREP(YT921X_FDB_OP_OP_M, (x)) WARNING: line length of 98 exceeds 80 columns #285: FILE: drivers/net/dsa/yt921x.c:226: +#define YT921X_FDB_RESULT_INDEX(x) FIELD_PREP(YT921X_FDB_RESULT_INDEX_M, (x)) WARNING: line length of 96 exceeds 80 columns #291: FILE: drivers/net/dsa/yt921x.c:232: +#define YT921X_FDB_IO1_STATUS(x) FIELD_PREP(YT921X_FDB_IO1_STATUS_M, (x)) WARNING: line length of 89 exceeds 80 columns #298: FILE: drivers/net/dsa/yt921x.c:239: +#define YT921X_FDB_IO1_FID_M GENMASK(27, 16) /* filtering ID (VID) */ WARNING: line length of 93 exceeds 80 columns #299: FILE: drivers/net/dsa/yt921x.c:240: +#define YT921X_FDB_IO1_FID(x) FIELD_PREP(YT921X_FDB_IO1_FID_M, (x)) WARNING: line length of 99 exceeds 80 columns #305: FILE: drivers/net/dsa/yt921x.c:246: +#define YT921X_FDB_IO2_EGR_PORTS(x) FIELD_PREP(YT921X_FDB_IO2_EGR_PORTS_M, (x)) WARNING: line length of 97 exceeds 80 columns #310: FILE: drivers/net/dsa/yt921x.c:251: +#define YT921X_FDB_IO2_INT_PRI(x) FIELD_PREP(YT921X_FDB_IO2_INT_PRI_M, (x)) WARNING: line length of 97 exceeds 80 columns #312: FILE: drivers/net/dsa/yt921x.c:253: +#define YT921X_FDB_IO2_NEW_VID(x) FIELD_PREP(YT921X_FDB_IO2_NEW_VID_M, (x)) WARNING: line length of 97 exceeds 80 columns #322: FILE: drivers/net/dsa/yt921x.c:263: +#define YT921X_VLAN_CTRL_PORTS(x) FIELD_PREP(YT921X_VLAN_CTRL_PORTS_M, (x)) WARNING: line length of 104 exceeds 80 columns #329: FILE: drivers/net/dsa/yt921x.c:270: +#define YT921X_VLAN_CTRL1_UNTAG_PORTS(x) FIELD_PREP(YT921X_VLAN_CTRL1_UNTAG_PORTS_M, (x)) WARNING: line length of 101 exceeds 80 columns #339: FILE: drivers/net/dsa/yt921x.c:280: +#define YT921X_PORT_VLAN_CTRL_SVID(x) FIELD_PREP(YT921X_PORT_VLAN_CTRL_SVID_M, (x)) WARNING: line length of 101 exceeds 80 columns #341: FILE: drivers/net/dsa/yt921x.c:282: +#define YT921X_PORT_VLAN_CTRL_CVID(x) FIELD_PREP(YT921X_PORT_VLAN_CTRL_CVID_M, (x)) WARNING: line length of 90 exceeds 80 columns #352: FILE: drivers/net/dsa/yt921x.c:293: +#define YT921X_REG_END 0x400000 /* as long as reg space is below this */ WARNING: line length of 96 exceeds 80 columns #385: FILE: drivers/net/dsa/yt921x.c:326: + MIB_DESC(1, 0x08, "RxMulticast"), /* rx multicast pkts, excluding pause and OAM */ WARNING: line length of 81 exceeds 80 columns #386: FILE: drivers/net/dsa/yt921x.c:327: + MIB_DESC(1, 0x0c, "RxCrcErr"), /* rx crc err pkts, len >= 64B */ WARNING: line length of 86 exceeds 80 columns #388: FILE: drivers/net/dsa/yt921x.c:329: + MIB_DESC(1, 0x10, "RxAlignErr"), /* rx pkts with odd number of bytes */ WARNING: line length of 85 exceeds 80 columns #393: FILE: drivers/net/dsa/yt921x.c:334: + MIB_DESC(1, 0x20, "RxPktSz65To127"), /* rx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #394: FILE: drivers/net/dsa/yt921x.c:335: + MIB_DESC(1, 0x24, "RxPktSz128To255"), /* rx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #395: FILE: drivers/net/dsa/yt921x.c:336: + MIB_DESC(1, 0x28, "RxPktSz256To511"), /* rx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #396: FILE: drivers/net/dsa/yt921x.c:337: + MIB_DESC(1, 0x2c, "RxPktSz512To1023"), /* rx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #398: FILE: drivers/net/dsa/yt921x.c:339: + MIB_DESC(1, 0x30, "RxPktSz1024To1518"), /* rx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 83 exceeds 80 columns #405: FILE: drivers/net/dsa/yt921x.c:346: + MIB_DESC(2, 0x48, "RxOverSzErr"), /* rx pkts, len > mac frame size */ WARNING: line length of 98 exceeds 80 columns #408: FILE: drivers/net/dsa/yt921x.c:349: + MIB_DESC(1, 0x50, "RxDropped"), /* rx dropped pkts, excluding crc err and pause */ WARNING: line length of 96 exceeds 80 columns #411: FILE: drivers/net/dsa/yt921x.c:352: + MIB_DESC(1, 0x5c, "TxMulticast"), /* tx multicast pkts, excluding pause and OAM */ WARNING: line length of 85 exceeds 80 columns #415: FILE: drivers/net/dsa/yt921x.c:356: + MIB_DESC(1, 0x68, "TxPktSz65To127"), /* tx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #416: FILE: drivers/net/dsa/yt921x.c:357: + MIB_DESC(1, 0x6c, "TxPktSz128To255"), /* tx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #418: FILE: drivers/net/dsa/yt921x.c:359: + MIB_DESC(1, 0x70, "TxPktSz256To511"), /* tx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #419: FILE: drivers/net/dsa/yt921x.c:360: + MIB_DESC(1, 0x74, "TxPktSz512To1023"), /* tx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #420: FILE: drivers/net/dsa/yt921x.c:361: + MIB_DESC(1, 0x78, "TxPktSz1024To1518"), /* tx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 96 exceeds 80 columns #428: FILE: drivers/net/dsa/yt921x.c:369: + MIB_DESC(1, 0x90, "TxExcessiveCollistion"), /* aborted pkts due to too many colls */ WARNING: line length of 92 exceeds 80 columns #429: FILE: drivers/net/dsa/yt921x.c:370: + MIB_DESC(1, 0x94, "TxMultipleCollision"), /* multiple collision for one mac */ WARNING: line length of 86 exceeds 80 columns #433: FILE: drivers/net/dsa/yt921x.c:374: + MIB_DESC(1, 0xa0, "TxDeferred"), /* delayed pkts due to defer signal */ WARNING: quoted string split across lines #1778: FILE: drivers/net/dsa/yt921x.c:1719: + "%s: port %d, mode %u, interface %d, speed %d, duplex %d, " + "pause %d, advertising %lx\n", __func__, WARNING: quoted string split across lines #1968: FILE: drivers/net/dsa/yt921x.c:1909: + "%s: index 0x%x, mac %02x:%02x:%02x:%02x:%02x:%02x, " + "vid %d, ports 0x%x, status %d\n", WARNING: line length of 84 exceeds 80 columns #3101: FILE: drivers/net/dsa/yt921x.c:3042: + YT921X_EXT_CPU_PORT_PORT(__fls(priv->active_cpu_ports_mask)); WARNING: line length of 94 exceeds 80 columns #3261: FILE: drivers/net/dsa/yt921x.c:3202: + .preferred_default_local_cpu_port = yt921x_dsa_preferred_default_local_cpu_port, total: 0 errors, 80 warnings, 0 checks, 3408 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e3efecc8c7b2 ("net: dsa: yt921x: Add support for Motorcomm YT921x") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 80 warnings, 0 checks, 3408 lines checked