ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.1HBEcEBX4X and /tmp/tmp.HAVw3NYbGA
Tree base:
76af00d8700a ("bpftool: Add support for signing BPF programs")
Now at:
7273c18c49af ("selftests/bpf: Enable signature verification for some lskel tests")
 ====== Checking before the patch ======
Checking tools/testing/selftests/bpf/verify_sig_setup.sh - 683371b5f969704f233a5b02362cfb5537e482efb171e86c46a7edd0b3fcfed6


In verify_sig_setup.sh line 39:
	echo "${x509_genkey_content}" > ${tmp_dir}/x509.genkey
                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "${x509_genkey_content}" > "${tmp_dir}"/x509.genkey


In verify_sig_setup.sh line 42:
			-batch -x509 -config ${tmp_dir}/x509.genkey \
                                             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-batch -x509 -config "${tmp_dir}"/x509.genkey \


In verify_sig_setup.sh line 43:
			-outform PEM -out ${tmp_dir}/signing_key.pem \
                                          ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-outform PEM -out "${tmp_dir}"/signing_key.pem \


In verify_sig_setup.sh line 44:
			-keyout ${tmp_dir}/signing_key.pem 2>&1
                                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-keyout "${tmp_dir}"/signing_key.pem 2>&1


In verify_sig_setup.sh line 46:
	openssl x509 -in ${tmp_dir}/signing_key.pem -out \
                         ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	openssl x509 -in "${tmp_dir}"/signing_key.pem -out \


In verify_sig_setup.sh line 47:
		${tmp_dir}/signing_key.der -outform der
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"${tmp_dir}"/signing_key.der -outform der


In verify_sig_setup.sh line 49:
	key_id=$(cat ${tmp_dir}/signing_key.der | keyctl padd asymmetric ebpf_testing_key @s)
                     ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	key_id=$(cat "${tmp_dir}"/signing_key.der | keyctl padd asymmetric ebpf_testing_key @s)


In verify_sig_setup.sh line 52:
	keyctl link $key_id $keyring_id
                    ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	keyctl link "$key_id" "$keyring_id"


In verify_sig_setup.sh line 58:
	keyctl unlink $(keyctl search @s asymmetric ebpf_testing_key) @s
                      ^-- SC2046 (warning): Quote this to prevent word splitting.


In verify_sig_setup.sh line 59:
	keyctl unlink $(keyctl search @s keyring ebpf_testing_keyring) @s
                      ^-- SC2046 (warning): Quote this to prevent word splitting.


In verify_sig_setup.sh line 60:
	rm -rf ${tmp_dir}
               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm -rf "${tmp_dir}"


In verify_sig_setup.sh line 68:
	dd if=/dev/urandom of=$data_file bs=1 count=12345 2> /dev/null
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	dd if=/dev/urandom of="$data_file" bs=1 count=12345 2> /dev/null


In verify_sig_setup.sh line 69:
	fsverity sign --key ${tmp_dir}/signing_key.pem $data_file $sig_file
                            ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity sign --key "${tmp_dir}"/signing_key.pem "$data_file" "$sig_file"


In verify_sig_setup.sh line 73:
	touch ${tmp_dir}/tmp-file
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	touch "${tmp_dir}"/tmp-file


In verify_sig_setup.sh line 74:
	fsverity enable ${tmp_dir}/tmp-file
                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity enable "${tmp_dir}"/tmp-file


In verify_sig_setup.sh line 81:
	fsverity enable $data_file
                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity enable "$data_file"


In verify_sig_setup.sh line 94:
	exit ${exit_code}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	exit "${exit_code}"

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/bpf/verify_sig_setup.sh - 683371b5f969704f233a5b02362cfb5537e482efb171e86c46a7edd0b3fcfed6


In verify_sig_setup.sh line 39:
	echo "${x509_genkey_content}" > ${tmp_dir}/x509.genkey
                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "${x509_genkey_content}" > "${tmp_dir}"/x509.genkey


In verify_sig_setup.sh line 42:
			-batch -x509 -config ${tmp_dir}/x509.genkey \
                                             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-batch -x509 -config "${tmp_dir}"/x509.genkey \


In verify_sig_setup.sh line 43:
			-outform PEM -out ${tmp_dir}/signing_key.pem \
                                          ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-outform PEM -out "${tmp_dir}"/signing_key.pem \


In verify_sig_setup.sh line 44:
			-keyout ${tmp_dir}/signing_key.pem 2>&1
                                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			-keyout "${tmp_dir}"/signing_key.pem 2>&1


In verify_sig_setup.sh line 46:
	openssl x509 -in ${tmp_dir}/signing_key.pem -out \
                         ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	openssl x509 -in "${tmp_dir}"/signing_key.pem -out \


In verify_sig_setup.sh line 47:
		${tmp_dir}/signing_key.der -outform der
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"${tmp_dir}"/signing_key.der -outform der


In verify_sig_setup.sh line 57:
	key_id=$(cat ${tmp_dir}/signing_key.der | keyctl padd asymmetric ebpf_testing_key @s)
                     ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	key_id=$(cat "${tmp_dir}"/signing_key.der | keyctl padd asymmetric ebpf_testing_key @s)


In verify_sig_setup.sh line 59:
	keyctl link $key_id $keyring_id
                    ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	keyctl link "$key_id" "$keyring_id"


In verify_sig_setup.sh line 65:
	keyctl unlink $(keyctl search @s asymmetric ebpf_testing_key) @s
                      ^-- SC2046 (warning): Quote this to prevent word splitting.


In verify_sig_setup.sh line 66:
	keyctl unlink $(keyctl search @s keyring ebpf_testing_keyring) @s
                      ^-- SC2046 (warning): Quote this to prevent word splitting.


In verify_sig_setup.sh line 67:
	rm -rf ${tmp_dir}
               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm -rf "${tmp_dir}"


In verify_sig_setup.sh line 75:
	dd if=/dev/urandom of=$data_file bs=1 count=12345 2> /dev/null
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	dd if=/dev/urandom of="$data_file" bs=1 count=12345 2> /dev/null


In verify_sig_setup.sh line 76:
	fsverity sign --key ${tmp_dir}/signing_key.pem $data_file $sig_file
                            ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity sign --key "${tmp_dir}"/signing_key.pem "$data_file" "$sig_file"


In verify_sig_setup.sh line 80:
	touch ${tmp_dir}/tmp-file
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	touch "${tmp_dir}"/tmp-file


In verify_sig_setup.sh line 81:
	fsverity enable ${tmp_dir}/tmp-file
                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity enable "${tmp_dir}"/tmp-file


In verify_sig_setup.sh line 88:
	fsverity enable $data_file
                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	fsverity enable "$data_file"


In verify_sig_setup.sh line 101:
	exit ${exit_code}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	exit "${exit_code}"

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...