WARNING: Avoid line continuations in quoted strings
#202: FILE: tools/bpf/bpftool/gen.c:806:
+		codegen("\

WARNING: line length of 94 exceeds 80 columns
#204: FILE: tools/bpf/bpftool/gen.c:808:
+			static const char opts_sig[] __attribute__((__aligned__(8))) = \"\\\n\

WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8)))
#204: FILE: tools/bpf/bpftool/gen.c:808:
+			static const char opts_sig[] __attribute__((__aligned__(8))) = \"\\\n\

WARNING: Avoid line continuations in quoted strings
#207: FILE: tools/bpf/bpftool/gen.c:811:
+		codegen("\

WARNING: Avoid line continuations in quoted strings
#211: FILE: tools/bpf/bpftool/gen.c:815:
+		codegen("\

WARNING: line length of 100 exceeds 80 columns
#213: FILE: tools/bpf/bpftool/gen.c:817:
+			static const char opts_excl_hash[] __attribute__((__aligned__(8))) = \"\\\n\

WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8)))
#213: FILE: tools/bpf/bpftool/gen.c:817:
+			static const char opts_excl_hash[] __attribute__((__aligned__(8))) = \"\\\n\

WARNING: Avoid line continuations in quoted strings
#216: FILE: tools/bpf/bpftool/gen.c:820:
+		codegen("\

WARNING: Avoid line continuations in quoted strings
#220: FILE: tools/bpf/bpftool/gen.c:824:
+		codegen("\

WARNING: line length of 83 exceeds 80 columns
#222: FILE: tools/bpf/bpftool/gen.c:826:
+			opts.signature = (void *)opts_sig;			\n\

WARNING: line length of 83 exceeds 80 columns
#223: FILE: tools/bpf/bpftool/gen.c:827:
+			opts.signature_sz = sizeof(opts_sig) - 1;		\n\

WARNING: line length of 83 exceeds 80 columns
#224: FILE: tools/bpf/bpftool/gen.c:828:
+			opts.excl_prog_hash = (void *)opts_excl_hash;		\n\

WARNING: line length of 83 exceeds 80 columns
#225: FILE: tools/bpf/bpftool/gen.c:829:
+			opts.excl_prog_hash_sz = sizeof(opts_excl_hash) - 1;	\n\

WARNING: line length of 83 exceeds 80 columns
#226: FILE: tools/bpf/bpftool/gen.c:830:
+			opts.keyring_id = KEY_SPEC_SESSION_KEYRING;		\n\

WARNING: Avoid line continuations in quoted strings
#230: FILE: tools/bpf/bpftool/gen.c:834:
+	codegen("\

CHECK: Comparison to NULL could be written "!private_key_path"
#313: FILE: tools/bpf/bpftool/main.c:550:
+	if (sign_progs && (private_key_path == NULL || cert_path == NULL)) {

CHECK: Comparison to NULL could be written "!cert_path"
#313: FILE: tools/bpf/bpftool/main.c:550:
+	if (sign_progs && (private_key_path == NULL || cert_path == NULL)) {

CHECK: Comparison to NULL could be written "private_key_path"
#318: FILE: tools/bpf/bpftool/main.c:555:
+	if (!sign_progs && (private_key_path != NULL || cert_path != NULL)) {

CHECK: Comparison to NULL could be written "cert_path"
#318: FILE: tools/bpf/bpftool/main.c:555:
+	if (!sign_progs && (private_key_path != NULL || cert_path != NULL)) {

WARNING: unnecessary whitespace before a quoted newline
#439: FILE: tools/bpf/bpftool/prog.c:2590:
+		"                    {-L|--use-loader} | [ {-S|--sign } {-k} <private_key.pem> {-i} <certificate.x509> ] \n"

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#444: 
new file mode 100644

WARNING: braces {} are not necessary for any arm of this statement
#491: FILE: tools/bpf/bpftool/sign.c:43:
+		if (data && (flags & ERR_TXT_STRING)) {
[...]
+		} else {
[...]

CHECK: Alignment should match open parenthesis
#566: FILE: tools/bpf/bpftool/sign.c:118:
+	key_id = syscall(__NR_add_key, "asymmetric", key_der_path, der_buf,
+			     (size_t)der_len, KEY_SPEC_SESSION_KEYRING);

WARNING: line length of 82 exceeds 80 columns
#646: FILE: tools/bpf/bpftool/sign.c:198:
+	if (BIO_read(bd_out, opts->signature, actual_sig_len) != actual_sig_len) {

total: 0 errors, 19 warnings, 5 checks, 553 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit fcb62f482db7 ("bpftool: Add support for signing BPF programs") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 19 warnings, 5 checks, 553 lines checked