ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.RCTinha7ay and /tmp/tmp.Smkj5GzyWZ Tree base: e96755ab90af ("bridge: Redirect to backup port when port is administratively down") Now at: 4d6bf16c5daa ("selftests: net: Test bridge backup port when port is administratively down") ====== Checking before the patch ====== Checking tools/testing/selftests/net/test_bridge_backup_port.sh - f8aac16043fa06b83d41dec2470aec64b4e72e9b40a145d18221c7ff0a2f17ff In test_bridge_backup_port.sh line 63: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_bridge_backup_port.sh line 77: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_backup_port.sh line 85: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_backup_port.sh line 99: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_bridge_backup_port.sh line 103: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_bridge_backup_port.sh line 105: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_bridge_backup_port.sh line 109: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_bridge_backup_port.sh line 121: pkts=$(tc -n $ns -j -s filter show $id \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pkts=$(tc -n "$ns" -j -s filter show "$id" \ In test_bridge_backup_port.sh line 124: [[ $pkts == $count ]] ^----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In test_bridge_backup_port.sh line 133: bridge -n $ns -d -j link show dev $dev | \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" -d -j link show dev "$dev" | \ In test_bridge_backup_port.sh line 144: ip netns exec $ns sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 In test_bridge_backup_port.sh line 145: ip netns exec $ns sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 In test_bridge_backup_port.sh line 146: ip netns exec $ns sysctl -qw net.ipv6.conf.all.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.accept_dad=0 In test_bridge_backup_port.sh line 147: ip netns exec $ns sysctl -qw net.ipv6.conf.default.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.accept_dad=0 In test_bridge_backup_port.sh line 155: for ns in $sw1 $sw2; do ^--^ SC2154 (warning): sw1 is referenced but not assigned. ^--^ SC2154 (warning): sw2 is referenced but not assigned. In test_bridge_backup_port.sh line 156: setup_topo_ns $ns ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_topo_ns "$ns" In test_bridge_backup_port.sh line 160: ip link set dev veth0 netns $sw1 name veth0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev veth0 netns "$sw1" name veth0 In test_bridge_backup_port.sh line 161: ip link set dev veth1 netns $sw2 name veth0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev veth1 netns "$sw2" name veth0 In test_bridge_backup_port.sh line 173: ip -n $ns address add $local_addr/32 dev lo ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$local_addr"/32 dev lo In test_bridge_backup_port.sh line 175: ip -n $ns link set dev veth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev veth0 up In test_bridge_backup_port.sh line 176: ip -n $ns address add $veth_addr/28 dev veth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$veth_addr"/28 dev veth0 In test_bridge_backup_port.sh line 177: ip -n $ns route add default via $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" route add default via "$gw_addr" In test_bridge_backup_port.sh line 179: ip -n $ns link add name br0 up type bridge vlan_filtering 1 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name br0 up type bridge vlan_filtering 1 \ In test_bridge_backup_port.sh line 182: ip -n $ns link add link br0 name br0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.10 up type vlan id 10 In test_bridge_backup_port.sh line 183: bridge -n $ns vlan add vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev br0 self In test_bridge_backup_port.sh line 184: ip -n $ns address add $br_addr/28 dev br0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$br_addr"/28 dev br0.10 In test_bridge_backup_port.sh line 186: ip -n $ns link add name swp1 up type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name swp1 up type dummy In test_bridge_backup_port.sh line 187: ip -n $ns link set dev swp1 master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev swp1 master br0 In test_bridge_backup_port.sh line 188: bridge -n $ns vlan add vid 10 dev swp1 untagged ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev swp1 untagged In test_bridge_backup_port.sh line 190: ip -n $ns link add name vx0 up master br0 type vxlan \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name vx0 up master br0 type vxlan \ In test_bridge_backup_port.sh line 191: local $local_addr dstport 4789 nolearning external ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local_addr" dstport 4789 nolearning external In test_bridge_backup_port.sh line 192: bridge -n $ns link set dev vx0 vlan_tunnel on learning off ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" link set dev vx0 vlan_tunnel on learning off In test_bridge_backup_port.sh line 194: bridge -n $ns vlan add vid 10 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 In test_bridge_backup_port.sh line 195: bridge -n $ns vlan add vid 10 dev vx0 tunnel_info id 10010 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 tunnel_info id 10010 In test_bridge_backup_port.sh line 207: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr \ In test_bridge_backup_port.sh line 220: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr \ In test_bridge_backup_port.sh line 239: cleanup_ns $sw1 $sw2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$sw1" "$sw2" In test_bridge_backup_port.sh line 266: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 268: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 272: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 276: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 278: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 282: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 293: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 295: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 299: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 303: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 305: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 309: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 313: tc_check_packets $sw1 "dev swp1 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 3 In test_bridge_backup_port.sh line 315: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 325: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 327: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 331: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 335: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 337: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 381: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 383: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 387: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 391: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 393: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 395: tc_check_packets $sw2 "dev vx0 ingress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 0 In test_bridge_backup_port.sh line 397: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 401: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 412: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 414: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 418: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 422: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 424: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 426: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 428: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 432: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 436: tc_check_packets $sw1 "dev swp1 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 3 In test_bridge_backup_port.sh line 438: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 440: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 442: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 453: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 455: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 457: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 459: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 463: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 467: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 469: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_backup_port.sh line 471: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 473: tc_check_packets $sw2 "dev vx0 ingress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 2 In test_bridge_backup_port.sh line 499: tx_drop=$(ip -n $sw1 -s -j link show dev vx0 | jq '.[]["stats64"]["tx"]["dropped"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tx_drop=$(ip -n "$sw1" -s -j link show dev vx0 | jq '.[]["stats64"]["tx"]["dropped"]') In test_bridge_backup_port.sh line 520: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 524: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 526: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 528: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 539: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 541: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 543: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 555: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 557: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_backup_port.sh line 559: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 570: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 572: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_backup_port.sh line 574: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 588: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 590: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_backup_port.sh line 592: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 608: sw1_mac=$(ip -n $sw1 -j -p link show br0.10 | jq -r '.[]["address"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sw1_mac=$(ip -n "$sw1" -j -p link show br0.10 | jq -r '.[]["address"]') In test_bridge_backup_port.sh line 609: sw2_mac=$(ip -n $sw2 -j -p link show br0.10 | jq -r '.[]["address"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sw2_mac=$(ip -n "$sw2" -j -p link show br0.10 | jq -r '.[]["address"]') In test_bridge_backup_port.sh line 628: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 630: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw2 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw2" swp1 disabled In test_bridge_backup_port.sh line 646: ip -n $sw1 nexthop del id 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" nexthop del id 10 In test_bridge_backup_port.sh line 647: ip -n $sw1 nexthop replace id 10 group 1/2 fdb ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" nexthop replace id 10 group 1/2 fdb In test_bridge_backup_port.sh line 657: local pid3 ^--^ SC2034 (warning): pid3 appears unused. Verify use (or export if used externally). In test_bridge_backup_port.sh line 679: ip netns exec $sw1 mausezahn br0.10 -a $smac -b $dmac -A 198.51.100.1 -B 198.51.100.2 -t ip -p 100 -q -c 0 & ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$sw1" mausezahn br0.10 -a "$smac" -b "$dmac" -A 198.51.100.1 -B 198.51.100.2 -t ip -p 100 -q -c 0 & In test_bridge_backup_port.sh line 683: kill -9 $pid1 $pid2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill -9 "$pid1" "$pid2" In test_bridge_backup_port.sh line 684: wait $pid1 $pid2 2>/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait "$pid1" "$pid2" 2>/dev/null In test_bridge_backup_port.sh line 716: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_bridge_backup_port.sh line 757: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_bridge_backup_port.sh line 771: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_bridge_backup_port.sh line 772: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2034 -- pid3 appears unused. Verify use (... https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2154 -- sw1 is referenced but not assigned. ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/test_bridge_backup_port.sh - f8aac16043fa06b83d41dec2470aec64b4e72e9b40a145d18221c7ff0a2f17ff In test_bridge_backup_port.sh line 63: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_bridge_backup_port.sh line 77: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_backup_port.sh line 85: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_backup_port.sh line 99: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_bridge_backup_port.sh line 103: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_bridge_backup_port.sh line 105: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_bridge_backup_port.sh line 109: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_bridge_backup_port.sh line 121: pkts=$(tc -n $ns -j -s filter show $id \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pkts=$(tc -n "$ns" -j -s filter show "$id" \ In test_bridge_backup_port.sh line 124: [[ $pkts == $count ]] ^----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In test_bridge_backup_port.sh line 133: bridge -n $ns -d -j link show dev $dev | \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" -d -j link show dev "$dev" | \ In test_bridge_backup_port.sh line 144: ip netns exec $ns sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 In test_bridge_backup_port.sh line 145: ip netns exec $ns sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 In test_bridge_backup_port.sh line 146: ip netns exec $ns sysctl -qw net.ipv6.conf.all.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.accept_dad=0 In test_bridge_backup_port.sh line 147: ip netns exec $ns sysctl -qw net.ipv6.conf.default.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.accept_dad=0 In test_bridge_backup_port.sh line 155: for ns in $sw1 $sw2; do ^--^ SC2154 (warning): sw1 is referenced but not assigned. ^--^ SC2154 (warning): sw2 is referenced but not assigned. In test_bridge_backup_port.sh line 156: setup_topo_ns $ns ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_topo_ns "$ns" In test_bridge_backup_port.sh line 160: ip link set dev veth0 netns $sw1 name veth0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev veth0 netns "$sw1" name veth0 In test_bridge_backup_port.sh line 161: ip link set dev veth1 netns $sw2 name veth0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev veth1 netns "$sw2" name veth0 In test_bridge_backup_port.sh line 173: ip -n $ns address add $local_addr/32 dev lo ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$local_addr"/32 dev lo In test_bridge_backup_port.sh line 175: ip -n $ns link set dev veth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev veth0 up In test_bridge_backup_port.sh line 176: ip -n $ns address add $veth_addr/28 dev veth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$veth_addr"/28 dev veth0 In test_bridge_backup_port.sh line 177: ip -n $ns route add default via $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" route add default via "$gw_addr" In test_bridge_backup_port.sh line 179: ip -n $ns link add name br0 up type bridge vlan_filtering 1 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name br0 up type bridge vlan_filtering 1 \ In test_bridge_backup_port.sh line 182: ip -n $ns link add link br0 name br0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.10 up type vlan id 10 In test_bridge_backup_port.sh line 183: bridge -n $ns vlan add vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev br0 self In test_bridge_backup_port.sh line 184: ip -n $ns address add $br_addr/28 dev br0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$br_addr"/28 dev br0.10 In test_bridge_backup_port.sh line 186: ip -n $ns link add name swp1 up type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name swp1 up type dummy In test_bridge_backup_port.sh line 187: ip -n $ns link set dev swp1 master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev swp1 master br0 In test_bridge_backup_port.sh line 188: bridge -n $ns vlan add vid 10 dev swp1 untagged ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev swp1 untagged In test_bridge_backup_port.sh line 190: ip -n $ns link add name vx0 up master br0 type vxlan \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name vx0 up master br0 type vxlan \ In test_bridge_backup_port.sh line 191: local $local_addr dstport 4789 nolearning external ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local_addr" dstport 4789 nolearning external In test_bridge_backup_port.sh line 192: bridge -n $ns link set dev vx0 vlan_tunnel on learning off ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" link set dev vx0 vlan_tunnel on learning off In test_bridge_backup_port.sh line 194: bridge -n $ns vlan add vid 10 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 In test_bridge_backup_port.sh line 195: bridge -n $ns vlan add vid 10 dev vx0 tunnel_info id 10010 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 tunnel_info id 10010 In test_bridge_backup_port.sh line 207: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr \ In test_bridge_backup_port.sh line 220: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr \ In test_bridge_backup_port.sh line 239: cleanup_ns $sw1 $sw2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$sw1" "$sw2" In test_bridge_backup_port.sh line 266: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 268: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 272: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 276: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 278: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 282: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 293: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 295: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 299: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 303: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 305: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 309: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 313: tc_check_packets $sw1 "dev swp1 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 3 In test_bridge_backup_port.sh line 315: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 322: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 326: tc_check_packets $sw1 "dev swp1 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 3 In test_bridge_backup_port.sh line 328: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 332: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 336: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 338: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 348: tc_check_packets $sw1 "dev swp1 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 5 In test_bridge_backup_port.sh line 350: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 354: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 358: tc_check_packets $sw1 "dev swp1 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 5 In test_bridge_backup_port.sh line 360: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 404: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 406: tc_check_packets $sw1 "dev vx0 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 0 In test_bridge_backup_port.sh line 410: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 414: tc_check_packets $sw1 "dev swp1 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 1 In test_bridge_backup_port.sh line 416: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 418: tc_check_packets $sw2 "dev vx0 ingress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 0 In test_bridge_backup_port.sh line 420: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 424: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 435: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 437: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 441: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 445: tc_check_packets $sw1 "dev swp1 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 2 In test_bridge_backup_port.sh line 447: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 449: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 451: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 455: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 forwarding ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 forwarding In test_bridge_backup_port.sh line 459: tc_check_packets $sw1 "dev swp1 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 3 In test_bridge_backup_port.sh line 461: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 463: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 465: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 476: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 478: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 480: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 482: tc_check_packets $sw2 "dev vx0 ingress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 1 In test_bridge_backup_port.sh line 486: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 490: tc_check_packets $sw1 "dev swp1 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 4 In test_bridge_backup_port.sh line 492: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_backup_port.sh line 494: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 496: tc_check_packets $sw2 "dev vx0 ingress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 102 2 In test_bridge_backup_port.sh line 522: tx_drop=$(ip -n $sw1 -s -j link show dev vx0 | jq '.[]["stats64"]["tx"]["dropped"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tx_drop=$(ip -n "$sw1" -s -j link show dev vx0 | jq '.[]["stats64"]["tx"]["dropped"]') In test_bridge_backup_port.sh line 543: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 547: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 549: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_backup_port.sh line 551: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 562: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 564: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_backup_port.sh line 566: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 578: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 580: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_backup_port.sh line 582: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 593: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 595: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_backup_port.sh line 597: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 611: tc_check_packets $sw1 "dev swp1 egress" 101 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev swp1 egress" 101 0 In test_bridge_backup_port.sh line 613: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_backup_port.sh line 615: tc_check_packets $sw2 "dev vx0 ingress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw2" "dev vx0 ingress" 101 1 In test_bridge_backup_port.sh line 631: sw1_mac=$(ip -n $sw1 -j -p link show br0.10 | jq -r '.[]["address"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sw1_mac=$(ip -n "$sw1" -j -p link show br0.10 | jq -r '.[]["address"]') In test_bridge_backup_port.sh line 632: sw2_mac=$(ip -n $sw2 -j -p link show br0.10 | jq -r '.[]["address"]') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sw2_mac=$(ip -n "$sw2" -j -p link show br0.10 | jq -r '.[]["address"]') In test_bridge_backup_port.sh line 651: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw1 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw1" swp1 disabled In test_bridge_backup_port.sh line 653: busywait $BUSYWAIT_TIMEOUT bridge_link_check $sw2 swp1 disabled ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait "$BUSYWAIT_TIMEOUT" bridge_link_check "$sw2" swp1 disabled In test_bridge_backup_port.sh line 669: ip -n $sw1 nexthop del id 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" nexthop del id 10 In test_bridge_backup_port.sh line 670: ip -n $sw1 nexthop replace id 10 group 1/2 fdb ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" nexthop replace id 10 group 1/2 fdb In test_bridge_backup_port.sh line 680: local pid3 ^--^ SC2034 (warning): pid3 appears unused. Verify use (or export if used externally). In test_bridge_backup_port.sh line 702: ip netns exec $sw1 mausezahn br0.10 -a $smac -b $dmac -A 198.51.100.1 -B 198.51.100.2 -t ip -p 100 -q -c 0 & ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$sw1" mausezahn br0.10 -a "$smac" -b "$dmac" -A 198.51.100.1 -B 198.51.100.2 -t ip -p 100 -q -c 0 & In test_bridge_backup_port.sh line 706: kill -9 $pid1 $pid2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill -9 "$pid1" "$pid2" In test_bridge_backup_port.sh line 707: wait $pid1 $pid2 2>/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait "$pid1" "$pid2" 2>/dev/null In test_bridge_backup_port.sh line 739: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_bridge_backup_port.sh line 780: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_bridge_backup_port.sh line 794: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_bridge_backup_port.sh line 795: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2034 -- pid3 appears unused. Verify use (... https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2154 -- sw1 is referenced but not assigned.