WARNING: line length of 97 exceeds 80 columns #160: FILE: tools/testing/selftests/bpf/veristat.c:1630: + qsort(ctx->kernel_syms, ctx->kernel_sym_cnt, sizeof(*ctx->kernel_syms), kernel_syms_cmp); WARNING: Prefer __printf(2, 3) over __attribute__((format(printf, 2, 3))) #167: FILE: tools/testing/selftests/bpf/veristat.c:1637: +__attribute__((format(printf, 2, 3))) WARNING: line length of 89 exceeds 80 columns #177: FILE: tools/testing/selftests/bpf/veristat.c:1647: +static struct kernel_sym *kernel_syms_search(unsigned long key, struct dump_context *ctx) WARNING: line length of 86 exceeds 80 columns #183: FILE: tools/testing/selftests/bpf/veristat.c:1653: + return ctx->kernel_syms ? bsearch(&sym, ctx->kernel_syms, ctx->kernel_sym_cnt, WARNING: line length of 87 exceeds 80 columns #184: FILE: tools/testing/selftests/bpf/veristat.c:1654: + sizeof(*ctx->kernel_syms), kernel_syms_cmp) : WARNING: line length of 83 exceeds 80 columns #196: FILE: tools/testing/selftests/bpf/veristat.c:1666: + if ((__u32)insn->imm < info->nr_jited_ksyms && info->jited_ksyms) { WARNING: line length of 95 exceeds 80 columns #204: FILE: tools/testing/selftests/bpf/veristat.c:1674: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "%+d", insn->off); WARNING: line length of 97 exceeds 80 columns #206: FILE: tools/testing/selftests/bpf/veristat.c:1676: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "%+d#%s", insn->off, WARNING: line length of 100 exceeds 80 columns #209: FILE: tools/testing/selftests/bpf/veristat.c:1679: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "%+d#0x%lx", insn->off, WARNING: line length of 94 exceeds 80 columns #214: FILE: tools/testing/selftests/bpf/veristat.c:1684: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "%s", sym->name); WARNING: line length of 95 exceeds 80 columns #216: FILE: tools/testing/selftests/bpf/veristat.c:1686: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "0x%lx", address); WARNING: line length of 93 exceeds 80 columns #221: FILE: tools/testing/selftests/bpf/veristat.c:1691: +static const char *print_imm(void *private_data, const struct bpf_insn *insn, __u64 full_imm) WARNING: line length of 94 exceeds 80 columns #227: FILE: tools/testing/selftests/bpf/veristat.c:1697: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "map[id:%d]", insn->imm); WARNING: line length of 99 exceeds 80 columns #230: FILE: tools/testing/selftests/bpf/veristat.c:1700: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "map[id:%d][0]+%d", insn->imm, WARNING: line length of 97 exceeds 80 columns #234: FILE: tools/testing/selftests/bpf/veristat.c:1704: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "map[idx:%d]+%d", insn->imm, WARNING: line length of 96 exceeds 80 columns #238: FILE: tools/testing/selftests/bpf/veristat.c:1708: + snprintf(ctx->scratch_buf, sizeof(ctx->scratch_buf), "subprog[%+d]", insn->imm); WARNING: line length of 84 exceeds 80 columns #304: FILE: tools/testing/selftests/bpf/veristat.c:1774: +static void emit_line_info(const struct btf *btf, const struct bpf_line_info *linfo) WARNING: line length of 100 exceeds 80 columns #330: FILE: tools/testing/selftests/bpf/veristat.c:1800: +static void dump_xlated(const struct btf *btf, struct bpf_program *prog, struct bpf_prog_info *info) WARNING: Missing a blank line after declarations #339: FILE: tools/testing/selftests/bpf/veristat.c:1809: + bool double_insn = false; + LIBBPF_OPTS(btf_dump_opts, dump_opts); WARNING: line length of 81 exceeds 80 columns #354: FILE: tools/testing/selftests/bpf/veristat.c:1824: + /* load symbols for each prog, as prog load could have added new items */ WARNING: line length of 93 exceeds 80 columns #385: FILE: tools/testing/selftests/bpf/veristat.c:1855: +static void dump(const struct btf *btf, struct bpf_program *prog, struct bpf_prog_info *info, total: 0 errors, 21 warnings, 0 checks, 375 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4be255c40148 ("selftests/bpf: add BPF program dump in veristat") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 0 checks, 375 lines checked