ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.aos4521zXa and /tmp/tmp.QMgBYoewAe
Tree base:
37816488247d ("Merge tag 'net-6.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
Now at:
84161d9aa891 ("selftests: netconsole: Validate interface selection by MAC address")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

Checking tools/testing/selftests/drivers/net/netcons_cmdline.sh - f75b28a0b64acd58651652097980bfe7dcf1c3adcd0c80ad167a0d2467e05f1a


In netcons_cmdline.sh line 32:
set_network
^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_cmdline.sh line 52:
exit "${ksft_pass}"
      ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a...
  https://www.shellcheck.net/wiki/SC2119 -- Use set_network "$@" if function'...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

Checking tools/testing/selftests/drivers/net/netcons_cmdline.sh - f75b28a0b64acd58651652097980bfe7dcf1c3adcd0c80ad167a0d2467e05f1a


In netcons_cmdline.sh line 28:
set_network
^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_cmdline.sh line 63:
exit "${ksft_pass}"
      ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a...
  https://www.shellcheck.net/wiki/SC2119 -- Use set_network "$@" if function'...