WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #38: FILE: drivers/net/dsa/Kconfig:156: +config NET_DSA_YT921X + tristate "Motorcomm YT9215 ethernet switch chip support" + select NET_DSA_TAG_YT921X + help + This enables support for the Motorcomm YT9215 ethernet switch + chip. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 WARNING: line length of 85 exceeds 80 columns #87: FILE: drivers/net/dsa/yt921x.c:25: +#define YT921X_SMI_SWITCHIDv(x) FIELD_PREP(YT921X_SMI_SWITCHIDf, (x)) WARNING: line length of 98 exceeds 80 columns #106: FILE: drivers/net/dsa/yt921x.c:44: +#define YT921X_EXT_CPU_PORT_PORTv(x) FIELD_PREP(YT921X_EXT_CPU_PORT_PORTf, (x)) WARNING: line length of 91 exceeds 80 columns #115: FILE: drivers/net/dsa/yt921x.c:53: +#define YT921X_SGMII_MODEv(x) FIELD_PREP(YT921X_SGMII_MODEf, (x)) WARNING: line length of 92 exceeds 80 columns #128: FILE: drivers/net/dsa/yt921x.c:66: +#define YT921X_SGMII_SPEEDv(x) FIELD_PREP(YT921X_SGMII_SPEEDf, (x)) WARNING: line length of 84 exceeds 80 columns #136: FILE: drivers/net/dsa/yt921x.c:74: +#define YT921X_PORT_LINKf BIT(9) /* CTRL: auto negotiation */ WARNING: line length of 92 exceeds 80 columns #137: FILE: drivers/net/dsa/yt921x.c:75: +#define YT921X_PORT_HALF_FLOW_CONTROLf BIT(8) /* Half-duplex back pressure mode */ WARNING: line length of 91 exceeds 80 columns #144: FILE: drivers/net/dsa/yt921x.c:82: +#define YT921X_PORT_SPEEDv(x) FIELD_PREP(YT921X_PORT_SPEEDf, (x)) WARNING: line length of 99 exceeds 80 columns #158: FILE: drivers/net/dsa/yt921x.c:96: +#define YT921X_MDIO_POLLING_SPEEDv(x) FIELD_PREP(YT921X_MDIO_POLLING_SPEEDf, (x)) WARNING: line length of 85 exceeds 80 columns #159: FILE: drivers/net/dsa/yt921x.c:97: +#define YT921X_MDIO_POLLING_SPEED_10v YT921X_MDIO_POLLING_SPEEDv(0) WARNING: line length of 85 exceeds 80 columns #160: FILE: drivers/net/dsa/yt921x.c:98: +#define YT921X_MDIO_POLLING_SPEED_100v YT921X_MDIO_POLLING_SPEEDv(1) WARNING: line length of 85 exceeds 80 columns #161: FILE: drivers/net/dsa/yt921x.c:99: +#define YT921X_MDIO_POLLING_SPEED_1000v YT921X_MDIO_POLLING_SPEEDv(2) WARNING: line length of 85 exceeds 80 columns #162: FILE: drivers/net/dsa/yt921x.c:100: +#define YT921X_MDIO_POLLING_SPEED_2500v YT921X_MDIO_POLLING_SPEEDv(4) WARNING: line length of 89 exceeds 80 columns #166: FILE: drivers/net/dsa/yt921x.c:104: +#define YT921X_EXTIF_SEL_EXTIFn_XMIIf(port) BIT(9 - (port)) /* Yes, it's reversed */ WARNING: line length of 96 exceeds 80 columns #169: FILE: drivers/net/dsa/yt921x.c:107: +#define YT921X_EXTIF_MODE_MODEv(x) FIELD_PREP(YT921X_EXTIF_MODE_MODEf, (x)) WARNING: line length of 82 exceeds 80 columns #170: FILE: drivers/net/dsa/yt921x.c:108: +#define YT921X_EXTIF_MODE_MODE_MIIv YT921X_EXTIF_MODE_MODEv(0) WARNING: line length of 82 exceeds 80 columns #171: FILE: drivers/net/dsa/yt921x.c:109: +#define YT921X_EXTIF_MODE_MODE_REVMIIv YT921X_EXTIF_MODE_MODEv(1) WARNING: line length of 82 exceeds 80 columns #172: FILE: drivers/net/dsa/yt921x.c:110: +#define YT921X_EXTIF_MODE_MODE_RMIIv YT921X_EXTIF_MODE_MODEv(2) WARNING: line length of 82 exceeds 80 columns #173: FILE: drivers/net/dsa/yt921x.c:111: +#define YT921X_EXTIF_MODE_MODE_REVRMIIv YT921X_EXTIF_MODE_MODEv(3) WARNING: line length of 82 exceeds 80 columns #174: FILE: drivers/net/dsa/yt921x.c:112: +#define YT921X_EXTIF_MODE_MODE_RGMIIv YT921X_EXTIF_MODE_MODEv(4) WARNING: line length of 82 exceeds 80 columns #175: FILE: drivers/net/dsa/yt921x.c:113: +#define YT921X_EXTIF_MODE_MODE_DISABLEv YT921X_EXTIF_MODE_MODEv(5) WARNING: line length of 95 exceeds 80 columns #180: FILE: drivers/net/dsa/yt921x.c:118: +#define YT921X_MAC_FRAME_SIZEv(x) FIELD_PREP(YT921X_MAC_FRAME_SIZEf, (x)) WARNING: line length of 94 exceeds 80 columns #191: FILE: drivers/net/dsa/yt921x.c:129: +#define YT921X_MIB_CTRL_PORTv(x) FIELD_PREP(YT921X_MIB_CTRL_PORTf, (x)) WARNING: line length of 96 exceeds 80 columns #199: FILE: drivers/net/dsa/yt921x.c:137: +#define YT921X_EDATA_CTRL_ADDRv(x) FIELD_PREP(YT921X_EDATA_CTRL_ADDRf, (x)) WARNING: line length of 98 exceeds 80 columns #213: FILE: drivers/net/dsa/yt921x.c:151: +#define YT921X_IF_MDIO_CTRL_PORTv(x) FIELD_PREP(YT921X_IF_MDIO_CTRL_PORTf, (x)) WARNING: line length of 97 exceeds 80 columns #215: FILE: drivers/net/dsa/yt921x.c:153: +#define YT921X_IF_MDIO_CTRL_REGv(x) FIELD_PREP(YT921X_IF_MDIO_CTRL_REGf, (x)) WARNING: line length of 98 exceeds 80 columns #217: FILE: drivers/net/dsa/yt921x.c:155: +#define YT921X_IF_MDIO_CTRL_TYPEv(x) FIELD_PREP(YT921X_IF_MDIO_CTRL_TYPEf, (x)) WARNING: line length of 84 exceeds 80 columns #218: FILE: drivers/net/dsa/yt921x.c:156: +#define YT921X_IF_MDIO_CTRL_TYPE_C22v YT921X_IF_MDIO_CTRL_TYPEv(4) WARNING: line length of 96 exceeds 80 columns #220: FILE: drivers/net/dsa/yt921x.c:158: +#define YT921X_IF_MDIO_CTRL_OPv(x) FIELD_PREP(YT921X_IF_MDIO_CTRL_OPf, (x)) WARNING: line length of 82 exceeds 80 columns #221: FILE: drivers/net/dsa/yt921x.c:159: +#define YT921X_IF_MDIO_CTRL_WRITEv YT921X_IF_MDIO_CTRL_OPv(1) WARNING: line length of 82 exceeds 80 columns #222: FILE: drivers/net/dsa/yt921x.c:160: +#define YT921X_IF_MDIO_CTRL_READv YT921X_IF_MDIO_CTRL_OPv(2) WARNING: line length of 96 exceeds 80 columns #244: FILE: drivers/net/dsa/yt921x.c:182: + MIB_DESC(1, 0x08, "RxMulticast"), /* rx multicast pkts, excluding pause and OAM */ WARNING: line length of 81 exceeds 80 columns #245: FILE: drivers/net/dsa/yt921x.c:183: + MIB_DESC(1, 0x0c, "RxCrcErr"), /* rx crc err pkts, len >= 64B */ WARNING: line length of 86 exceeds 80 columns #247: FILE: drivers/net/dsa/yt921x.c:185: + MIB_DESC(1, 0x10, "RxAlignErr"), /* rx pkts with odd number of bytes */ WARNING: line length of 85 exceeds 80 columns #252: FILE: drivers/net/dsa/yt921x.c:190: + MIB_DESC(1, 0x20, "RxPktSz65To127"), /* rx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #253: FILE: drivers/net/dsa/yt921x.c:191: + MIB_DESC(1, 0x24, "RxPktSz128To255"), /* rx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #254: FILE: drivers/net/dsa/yt921x.c:192: + MIB_DESC(1, 0x28, "RxPktSz256To511"), /* rx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #255: FILE: drivers/net/dsa/yt921x.c:193: + MIB_DESC(1, 0x2c, "RxPktSz512To1023"), /* rx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #257: FILE: drivers/net/dsa/yt921x.c:195: + MIB_DESC(1, 0x30, "RxPktSz1024To1518"), /* rx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 83 exceeds 80 columns #264: FILE: drivers/net/dsa/yt921x.c:202: + MIB_DESC(2, 0x48, "RxOverSzErr"), /* rx pkts, len > mac frame size */ WARNING: line length of 98 exceeds 80 columns #267: FILE: drivers/net/dsa/yt921x.c:205: + MIB_DESC(1, 0x50, "RxDropped"), /* rx dropped pkts, excluding crc err and pause */ WARNING: line length of 96 exceeds 80 columns #270: FILE: drivers/net/dsa/yt921x.c:208: + MIB_DESC(1, 0x5c, "TxMulticast"), /* tx multicast pkts, excluding pause and OAM */ WARNING: line length of 85 exceeds 80 columns #274: FILE: drivers/net/dsa/yt921x.c:212: + MIB_DESC(1, 0x68, "TxPktSz65To127"), /* tx pkts, len >= 65B and <= 127B */ WARNING: line length of 86 exceeds 80 columns #275: FILE: drivers/net/dsa/yt921x.c:213: + MIB_DESC(1, 0x6c, "TxPktSz128To255"), /* tx pkts, len >= 128B and <= 255B */ WARNING: line length of 86 exceeds 80 columns #277: FILE: drivers/net/dsa/yt921x.c:215: + MIB_DESC(1, 0x70, "TxPktSz256To511"), /* tx pkts, len >= 256B and <= 511B */ WARNING: line length of 87 exceeds 80 columns #278: FILE: drivers/net/dsa/yt921x.c:216: + MIB_DESC(1, 0x74, "TxPktSz512To1023"), /* tx pkts, len >= 512B and <= 1023B */ WARNING: line length of 88 exceeds 80 columns #279: FILE: drivers/net/dsa/yt921x.c:217: + MIB_DESC(1, 0x78, "TxPktSz1024To1518"), /* tx pkts, len >= 1024B and <= 1518B */ WARNING: line length of 96 exceeds 80 columns #287: FILE: drivers/net/dsa/yt921x.c:225: + MIB_DESC(1, 0x90, "TxExcessiveCollistion"), /* aborted pkts due to too many colls */ WARNING: line length of 92 exceeds 80 columns #288: FILE: drivers/net/dsa/yt921x.c:226: + MIB_DESC(1, 0x94, "TxMultipleCollision"), /* multiple collision for one mac */ WARNING: line length of 86 exceeds 80 columns #292: FILE: drivers/net/dsa/yt921x.c:230: + MIB_DESC(1, 0xa0, "TxDeferred"), /* delayed pkts due to defer signal */ WARNING: line length of 82 exceeds 80 columns #1471: FILE: drivers/net/dsa/yt921x.c:1409: + s->rx_bytes = u64_from_u32(mib->rx_good_bytes_hi, mib->rx_good_bytes_lo) - WARNING: line length of 82 exceeds 80 columns #1473: FILE: drivers/net/dsa/yt921x.c:1411: + s->tx_bytes = u64_from_u32(mib->tx_good_bytes_hi, mib->tx_good_bytes_lo) - WARNING: line length of 83 exceeds 80 columns #1641: FILE: drivers/net/dsa/yt921x.c:1579: + YT921X_EXTIF_SEL_EXTIFn_XMIIf(port)); WARNING: line length of 81 exceeds 80 columns #1715: FILE: drivers/net/dsa/yt921x.c:1653: + YT921X_EXTIF_SERDES_EXTIFnf(port)); WARNING: line length of 81 exceeds 80 columns #1719: FILE: drivers/net/dsa/yt921x.c:1657: + YT921X_EXTIF_SEL_EXTIFn_XMIIf(port)); WARNING: quoted string split across lines #1810: FILE: drivers/net/dsa/yt921x.c:1748: + "%s: port %d, mode %u, interface %d, speed %d, duplex %d, " + "pause %d, advertising %lx\n", __func__, WARNING: quoted string split across lines #1862: FILE: drivers/net/dsa/yt921x.c:1800: + "%s: port %d, mode %u, interface %d, speed %d, duplex %d, " + "tx_pause %d, rx_pause %d\n", __func__, port, mode, interface, WARNING: DT compatible string "motorcomm,yt9215" appears un-documented -- check ./Documentation/devicetree/bindings/ #1938: FILE: drivers/net/dsa/yt921x.c:1876: + { .compatible = "motorcomm,yt9215" }, total: 0 errors, 59 warnings, 0 checks, 1913 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2bcd6afbc029 ("net: dsa: yt921x: Add support for Motorcomm YT921x") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 59 warnings, 0 checks, 1913 lines checked