========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/drivers/net/netdevsim/ethtool-stats.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.My3zMFBYU1 2025-08-05 15:23:47.204421377 -0700 +++ /tmp/tmp.DTedgWKUAe 2025-08-05 15:23:47.420420244 -0700 @@ -11,0 +12,71 @@ + +In ethtool-stats.sh line 4: +source ethtool-common.sh + ^---------------^ SC1094 (warning): Parsing of sourced file failed. Ignoring it. + + +In ethtool-stats.sh line 11: +echo y > $MOCK_STATS_DFS + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +echo y > "$MOCK_STATS_DFS" + + +In ethtool-stats.sh line 13: +stat=$(ethtool -S $NSIM_NETDEV | grep "hw_out_of_buffer" | awk '{print $2}') + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +stat=$(ethtool -S "$NSIM_NETDEV" | grep "hw_out_of_buffer" | awk '{print $2}') + + +In ethtool-stats.sh line 19: +stat=$(ethtool -S $NSIM_NETDEV | grep "hw_out_of_buffer" | awk '{print $2}') + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +stat=$(ethtool -S "$NSIM_NETDEV" | grep "hw_out_of_buffer" | awk '{print $2}') + + +In ethtool-stats.sh line 23: +echo n > $MOCK_STATS_DFS + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +echo n > "$MOCK_STATS_DFS" + + +In ethtool-stats.sh line 24: +echo y > $MOCK_STATS_DFS + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +echo y > "$MOCK_STATS_DFS" + + +In ethtool-stats.sh line 26: +stat=$(ethtool -S $NSIM_NETDEV | grep "hw_out_of_buffer" | awk '{print $2}') + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +stat=$(ethtool -S "$NSIM_NETDEV" | grep "hw_out_of_buffer" | awk '{print $2}') + + +In ethtool-stats.sh line 30: +if [ $num_errors -eq 0 ]; then + ^---------^ SC2154 (warning): num_errors is referenced but not assigned. + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +if [ "$num_errors" -eq 0 ]; then + + +In ethtool-stats.sh line 31: + echo "PASSED all $((num_passes)) checks" + ^--------^ SC2154 (warning): num_passes is referenced but not assigned. + +For more information: + https://www.shellcheck.net/wiki/SC1094 -- Parsing of sourced file failed. I... + https://www.shellcheck.net/wiki/SC2154 -- num_errors is referenced but not ... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...