ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.RaVClVQceV and /tmp/tmp.vVRVvKwwc6
Tree base:
757265a09e52 ("netfilter: xt_nfacct: don't assume acct name is null-terminated")
Now at:
6c5b318c2df0 ("selftests: netfilter: Ignore tainted kernels in interface stress test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/nft_interface_stress.sh - 29439562d9ed3c3f99e405c818e74c3360fc9db7851247f6d685411953fdff2f


In nft_interface_stress.sh line 22:
ip -net $nsc link add cr0 type veth peer name rc0 netns $nsr
        ^--^ SC2154 (warning): nsc is referenced but not assigned.
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^--^ SC2154 (warning): nsr is referenced but not assigned.
                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" link add cr0 type veth peer name rc0 netns "$nsr"


In nft_interface_stress.sh line 23:
ip -net $nsc addr add 10.0.0.1/24 dev cr0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" addr add 10.0.0.1/24 dev cr0


In nft_interface_stress.sh line 24:
ip -net $nsc link set cr0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" link set cr0 up


In nft_interface_stress.sh line 25:
ip -net $nsc route add default via 10.0.0.2
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" route add default via 10.0.0.2


In nft_interface_stress.sh line 27:
ip -net $nss link add sr0 type veth peer name rs0 netns $nsr
        ^--^ SC2154 (warning): nss is referenced but not assigned.
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" link add sr0 type veth peer name rs0 netns "$nsr"


In nft_interface_stress.sh line 28:
ip -net $nss addr add 10.1.0.1/24 dev sr0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" addr add 10.1.0.1/24 dev sr0


In nft_interface_stress.sh line 29:
ip -net $nss link set sr0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" link set sr0 up


In nft_interface_stress.sh line 30:
ip -net $nss route add default via 10.1.0.2
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" route add default via 10.1.0.2


In nft_interface_stress.sh line 32:
ip -net $nsr addr add 10.0.0.2/24 dev rc0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" addr add 10.0.0.2/24 dev rc0


In nft_interface_stress.sh line 33:
ip -net $nsr link set rc0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" link set rc0 up


In nft_interface_stress.sh line 34:
ip -net $nsr addr add 10.1.0.2/24 dev rs0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" addr add 10.1.0.2/24 dev rs0


In nft_interface_stress.sh line 35:
ip -net $nsr link set rs0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" link set rs0 up


In nft_interface_stress.sh line 36:
ip netns exec $nsr sysctl -q net.ipv4.ip_forward=1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" sysctl -q net.ipv4.ip_forward=1


In nft_interface_stress.sh line 37:
ip netns exec $nsr sysctl -q net.ipv4.conf.all.forwarding=1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" sysctl -q net.ipv4.conf.all.forwarding=1


In nft_interface_stress.sh line 72:
} | ip netns exec $nsr nft -f - || {
                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
} | ip netns exec "$nsr" nft -f - || {


In nft_interface_stress.sh line 78:
	ip -net $nsr link set rc$o name rc$n
                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -net "$nsr" link set rc$o name rc$n


In nft_interface_stress.sh line 79:
	ip -net $nsr link set rs$o name rs$n
                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -net "$nsr" link set rs$o name rs$n


In nft_interface_stress.sh line 83:
while true; do ip netns exec $nsr nft list ruleset >/dev/null 2>&1; done &
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
while true; do ip netns exec "$nsr" nft list ruleset >/dev/null 2>&1; done &


In nft_interface_stress.sh line 86:
ip netns exec $nsr nft monitor >/dev/null &
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" nft monitor >/dev/null &


In nft_interface_stress.sh line 89:
ip netns exec $nss iperf3 --server --daemon -1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nss" iperf3 --server --daemon -1


In nft_interface_stress.sh line 91:
rate=$(ip netns exec $nsc iperf3 \
                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
rate=$(ip netns exec "$nsc" iperf3 \


In nft_interface_stress.sh line 101:
	ip netns exec $nsr nft -f - <<EOF
                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "$nsr" nft -f - <<EOF


In nft_interface_stress.sh line 115:
		ip -net $nsr link add wild$i type dummy &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link add wild$i type dummy &


In nft_interface_stress.sh line 119:
		ip -net $nsr link del wild$i &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link del wild$i &


In nft_interface_stress.sh line 122:
		ip -net $nsr link del wild$i &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link del wild$i &


In nft_interface_stress.sh line 128:
			ip -net $nsr link add wild$((i + j)) type dummy
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip -net "$nsr" link add wild$((i + j)) type dummy


In nft_interface_stress.sh line 131:
			ip -net $nsr link del wild$((i + j))
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip -net "$nsr" link del wild$((i + j))

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- nsc is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/nft_interface_stress.sh - 29439562d9ed3c3f99e405c818e74c3360fc9db7851247f6d685411953fdff2f


In nft_interface_stress.sh line 13:
read kernel_tainted < /proc/sys/kernel/tainted
^--^ SC2162 (info): read without -r will mangle backslashes.


In nft_interface_stress.sh line 24:
ip -net $nsc link add cr0 type veth peer name rc0 netns $nsr
        ^--^ SC2154 (warning): nsc is referenced but not assigned.
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^--^ SC2154 (warning): nsr is referenced but not assigned.
                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" link add cr0 type veth peer name rc0 netns "$nsr"


In nft_interface_stress.sh line 25:
ip -net $nsc addr add 10.0.0.1/24 dev cr0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" addr add 10.0.0.1/24 dev cr0


In nft_interface_stress.sh line 26:
ip -net $nsc link set cr0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" link set cr0 up


In nft_interface_stress.sh line 27:
ip -net $nsc route add default via 10.0.0.2
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsc" route add default via 10.0.0.2


In nft_interface_stress.sh line 29:
ip -net $nss link add sr0 type veth peer name rs0 netns $nsr
        ^--^ SC2154 (warning): nss is referenced but not assigned.
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" link add sr0 type veth peer name rs0 netns "$nsr"


In nft_interface_stress.sh line 30:
ip -net $nss addr add 10.1.0.1/24 dev sr0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" addr add 10.1.0.1/24 dev sr0


In nft_interface_stress.sh line 31:
ip -net $nss link set sr0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" link set sr0 up


In nft_interface_stress.sh line 32:
ip -net $nss route add default via 10.1.0.2
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nss" route add default via 10.1.0.2


In nft_interface_stress.sh line 34:
ip -net $nsr addr add 10.0.0.2/24 dev rc0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" addr add 10.0.0.2/24 dev rc0


In nft_interface_stress.sh line 35:
ip -net $nsr link set rc0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" link set rc0 up


In nft_interface_stress.sh line 36:
ip -net $nsr addr add 10.1.0.2/24 dev rs0
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" addr add 10.1.0.2/24 dev rs0


In nft_interface_stress.sh line 37:
ip -net $nsr link set rs0 up
        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip -net "$nsr" link set rs0 up


In nft_interface_stress.sh line 38:
ip netns exec $nsr sysctl -q net.ipv4.ip_forward=1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" sysctl -q net.ipv4.ip_forward=1


In nft_interface_stress.sh line 39:
ip netns exec $nsr sysctl -q net.ipv4.conf.all.forwarding=1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" sysctl -q net.ipv4.conf.all.forwarding=1


In nft_interface_stress.sh line 74:
} | ip netns exec $nsr nft -f - || {
                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
} | ip netns exec "$nsr" nft -f - || {


In nft_interface_stress.sh line 80:
	ip -net $nsr link set rc$o name rc$n
                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -net "$nsr" link set rc$o name rc$n


In nft_interface_stress.sh line 81:
	ip -net $nsr link set rs$o name rs$n
                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -net "$nsr" link set rs$o name rs$n


In nft_interface_stress.sh line 85:
while true; do ip netns exec $nsr nft list ruleset >/dev/null 2>&1; done &
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
while true; do ip netns exec "$nsr" nft list ruleset >/dev/null 2>&1; done &


In nft_interface_stress.sh line 88:
ip netns exec $nsr nft monitor >/dev/null &
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nsr" nft monitor >/dev/null &


In nft_interface_stress.sh line 91:
ip netns exec $nss iperf3 --server --daemon -1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
ip netns exec "$nss" iperf3 --server --daemon -1


In nft_interface_stress.sh line 93:
rate=$(ip netns exec $nsc iperf3 \
                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
rate=$(ip netns exec "$nsc" iperf3 \


In nft_interface_stress.sh line 103:
	ip netns exec $nsr nft -f - <<EOF
                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "$nsr" nft -f - <<EOF


In nft_interface_stress.sh line 117:
		ip -net $nsr link add wild$i type dummy &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link add wild$i type dummy &


In nft_interface_stress.sh line 121:
		ip -net $nsr link del wild$i &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link del wild$i &


In nft_interface_stress.sh line 124:
		ip -net $nsr link del wild$i &
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip -net "$nsr" link del wild$i &


In nft_interface_stress.sh line 130:
			ip -net $nsr link add wild$((i + j)) type dummy
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip -net "$nsr" link add wild$((i + j)) type dummy


In nft_interface_stress.sh line 133:
			ip -net $nsr link del wild$((i + j))
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip -net "$nsr" link del wild$((i + j))

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- nsc is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...