pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.hybYFSbS4R and /tmp/tmp.0SfquSCP0Q Tree base: 17b8f44d8903 ("selftests: drv-net: Fix remote command checking in require_cmd()") Now at: be97b5952826 ("selftests: drv-net: Make command requirements explicit") ====== Checking before the patch ====== -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ************* Module rss_input_xfrm tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:57:0: C0301: Line too long (145/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:13:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:62:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:71:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:76:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:81:0: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.77/10 (previous run: 8.77/10, +0.00) ************* Module tso tools/testing/selftests/drivers/net/hw/tso.py:106:0: C0301: Line too long (118/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:112:0: C0301: Line too long (125/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:217:0: C0301: Line too long (118/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:218:0: C0301: Line too long (116/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:36:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:42:61: W0612: Unused variable 'nc' (unused-variable) tools/testing/selftests/drivers/net/hw/tso.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:122:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/drivers/net/hw/tso.py:122:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/drivers/net/hw/tso.py:129:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/tso.py:122:23: W0613: Unused argument 'cfg' (unused-argument) tools/testing/selftests/drivers/net/hw/tso.py:206:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:15:0: W0611: Unused cmd imported from lib.py (unused-import) ------------------------------------------------------------------ Your code has been rated at 9.10/10 (previous run: 2.90/10, +6.21) ************* Module py.load tools/testing/selftests/drivers/net/lib/py/load.py:31:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/load.py:34:0: C0301: Line too long (105/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/load.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:5:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/load.py:7:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:24:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/load.py:44:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:48:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 7.14/10 (previous run: 7.50/10, -0.36) ************* Module ping tools/testing/selftests/drivers/net/ping.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/ping.py:5:0: C0410: Multiple imports on one line (random, string, time) (multiple-imports) tools/testing/selftests/drivers/net/ping.py:12:0: C0103: Constant name "no_sleep" doesn't conform to UPPER_CASE naming style (invalid-name) tools/testing/selftests/drivers/net/ping.py:53:34: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:66:4: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/drivers/net/ping.py:63:0: R1711: Useless return at end of function or method (useless-return) tools/testing/selftests/drivers/net/ping.py:63:31: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:75:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:82:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:85:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:93:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:95:8: W0105: String statement has no effect (pointless-string-statement) tools/testing/selftests/drivers/net/ping.py:102:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:113:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('device does not support native-multi-buffer XDP') from e' (raise-missing-from) tools/testing/selftests/drivers/net/ping.py:115:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:112:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/ping.py:124:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('device does not support offloaded XDP') from e' (raise-missing-from) tools/testing/selftests/drivers/net/ping.py:128:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:123:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/ping.py:131:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:132:4: W0603: Using the global statement (global-statement) tools/testing/selftests/drivers/net/ping.py:136:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:142:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:149:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:160:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:171:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:183:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:195:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:207:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:219:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:219:26: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:225:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:4:0: W0611: Unused import os (unused-import) ----------------------------------- Your code has been rated at 8.24/10 ====== Checking the tree with the patch ====== -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ************* Module rss_input_xfrm tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:57:0: C0301: Line too long (145/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:13:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:62:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:71:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:76:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py:81:0: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.77/10 (previous run: 8.77/10, +0.00) ************* Module tso tools/testing/selftests/drivers/net/hw/tso.py:106:0: C0301: Line too long (118/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:112:0: C0301: Line too long (125/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:217:0: C0301: Line too long (118/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:218:0: C0301: Line too long (116/100) (line-too-long) tools/testing/selftests/drivers/net/hw/tso.py:36:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:42:61: W0612: Unused variable 'nc' (unused-variable) tools/testing/selftests/drivers/net/hw/tso.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:122:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/drivers/net/hw/tso.py:122:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/drivers/net/hw/tso.py:129:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/tso.py:122:23: W0613: Unused argument 'cfg' (unused-argument) tools/testing/selftests/drivers/net/hw/tso.py:206:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/tso.py:15:0: W0611: Unused cmd imported from lib.py (unused-import) ------------------------------------------------------------------ Your code has been rated at 9.10/10 (previous run: 9.10/10, +0.00) ************* Module py.load tools/testing/selftests/drivers/net/lib/py/load.py:31:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/load.py:34:0: C0301: Line too long (105/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/load.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:5:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/load.py:7:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:24:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/load.py:44:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/load.py:48:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 7.14/10 (previous run: 7.14/10, +0.00) ************* Module ping tools/testing/selftests/drivers/net/ping.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/ping.py:5:0: C0410: Multiple imports on one line (random, string, time) (multiple-imports) tools/testing/selftests/drivers/net/ping.py:12:0: C0103: Constant name "no_sleep" doesn't conform to UPPER_CASE naming style (invalid-name) tools/testing/selftests/drivers/net/ping.py:53:34: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:66:4: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/drivers/net/ping.py:63:0: R1711: Useless return at end of function or method (useless-return) tools/testing/selftests/drivers/net/ping.py:63:31: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:75:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:82:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:85:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:93:18: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:95:8: W0105: String statement has no effect (pointless-string-statement) tools/testing/selftests/drivers/net/ping.py:102:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:113:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('device does not support native-multi-buffer XDP') from e' (raise-missing-from) tools/testing/selftests/drivers/net/ping.py:115:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:112:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/ping.py:124:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('device does not support offloaded XDP') from e' (raise-missing-from) tools/testing/selftests/drivers/net/ping.py:128:7: C0121: Comparison 'no_sleep != True' should be 'no_sleep is not True' if checking for the singleton value True, or 'not no_sleep' if testing for falsiness (singleton-comparison) tools/testing/selftests/drivers/net/ping.py:123:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/ping.py:131:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:132:4: W0603: Using the global statement (global-statement) tools/testing/selftests/drivers/net/ping.py:136:20: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/ping.py:142:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:149:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:160:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:171:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:183:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:195:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:207:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:219:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:219:26: W0613: Unused argument 'netnl' (unused-argument) tools/testing/selftests/drivers/net/ping.py:225:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/ping.py:4:0: W0611: Unused import os (unused-import) ------------------------------------------------------------------ Your code has been rated at 8.24/10 (previous run: 8.24/10, +0.00)