CHECK: extern prototypes should be avoided in .h files #33: FILE: include/linux/if_hsr.h:46: +extern int hsr_get_port_type(struct net_device *hsr_dev, struct net_device *dev, WARNING: line length of 87 exceeds 80 columns #43: FILE: include/linux/if_hsr.h:65: +static inline int hsr_get_port_type(struct net_device *hsr_dev, struct net_device *dev, WARNING: line length of 99 exceeds 80 columns #61: FILE: net/hsr/hsr_device.c:684: +int hsr_get_port_type(struct net_device *hsr_dev, struct net_device *dev, enum hsr_port_type *type) total: 0 errors, 2 warnings, 1 checks, 71 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit da9205bb5860 ("net: hsr: create an API to get hsr port type") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 2 warnings, 1 checks, 71 lines checked