ERROR: Using weak declarations can have unintended link defects #80: FILE: tools/bpf/bpftool/main.h:169: +int do_token(int argc, char **argv) __weak; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #85: new file mode 100644 CHECK: Comparison to NULL could be written "strstr" #114: FILE: tools/bpf/bpftool/token.c:25: + return strstr(mnt_ops, "delegate_cmds") != NULL || CHECK: Comparison to NULL could be written "strstr" #115: FILE: tools/bpf/bpftool/token.c:26: + strstr(mnt_ops, "delegate_maps") != NULL || CHECK: Comparison to NULL could be written "strstr" #116: FILE: tools/bpf/bpftool/token.c:27: + strstr(mnt_ops, "delegate_progs") != NULL || CHECK: Comparison to NULL could be written "strstr" #117: FILE: tools/bpf/bpftool/token.c:28: + strstr(mnt_ops, "delegate_attachs") != NULL; CHECK: Comparison to NULL could be written "token" #128: FILE: tools/bpf/bpftool/token.c:39: + for (token = strtok_r(opts_copy, ",", &rest); token != NULL; CHECK: Alignment should match open parenthesis #131: FILE: tools/bpf/bpftool/token.c:42: + if (strncmp(token, key, strlen(key)) == 0 && + token[strlen(key)] == '=') { CHECK: Comparison to NULL could be written "str" #153: FILE: tools/bpf/bpftool/token.c:64: + for (str = strtok_r(strs, ":", &rest); str != NULL; CHECK: Comparison to NULL could be written "str" #205: FILE: tools/bpf/bpftool/token.c:116: + for (str = strtok_r(strs, ":", &rest); str != NULL; CHECK: Blank lines aren't necessary after an open brace '{' #243: FILE: tools/bpf/bpftool/token.c:154: +{ + total: 1 errors, 1 warnings, 9 checks, 254 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e51ffcd1d8ed ("bpftool: Add bpf_token show") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.