====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ipv6_force_forwarding.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.WwiIfjqKKe 2025-07-22 03:25:22.622120014 -0700 +++ /tmp/tmp.moAZHeXx5k 2025-07-22 03:25:23.320114727 -0700 @@ -0,0 +1,192 @@ + +In ipv6_force_forwarding.sh line 14: + cleanup_ns $ns1 $ns2 $ns3 + ^--^ SC2154 (warning): ns1 is referenced but not assigned. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2154 (warning): ns2 is referenced but not assigned. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2154 (warning): ns3 is referenced but not assigned. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + cleanup_ns "$ns1" "$ns2" "$ns3" + + +In ipv6_force_forwarding.sh line 28: + ip link set veth12 netns $ns1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set veth12 netns "$ns1" + + +In ipv6_force_forwarding.sh line 29: + ip link set veth21 netns $ns2 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set veth21 netns "$ns2" + + +In ipv6_force_forwarding.sh line 30: + ip link set veth23 netns $ns2 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set veth23 netns "$ns2" + + +In ipv6_force_forwarding.sh line 31: + ip link set veth32 netns $ns3 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set veth32 netns "$ns3" + + +In ipv6_force_forwarding.sh line 34: + ip -n $ns1 addr add 2001:db8:1::1/64 dev veth12 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" addr add 2001:db8:1::1/64 dev veth12 nodad + + +In ipv6_force_forwarding.sh line 35: + ip -n $ns2 addr add 2001:db8:1::2/64 dev veth21 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" addr add 2001:db8:1::2/64 dev veth21 nodad + + +In ipv6_force_forwarding.sh line 36: + ip -n $ns2 addr add 2001:db8:2::1/64 dev veth23 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" addr add 2001:db8:2::1/64 dev veth23 nodad + + +In ipv6_force_forwarding.sh line 37: + ip -n $ns3 addr add 2001:db8:2::2/64 dev veth32 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns3" addr add 2001:db8:2::2/64 dev veth32 nodad + + +In ipv6_force_forwarding.sh line 40: + ip -n $ns1 link set veth12 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link set veth12 up + + +In ipv6_force_forwarding.sh line 41: + ip -n $ns2 link set veth21 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link set veth21 up + + +In ipv6_force_forwarding.sh line 42: + ip -n $ns2 link set veth23 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link set veth23 up + + +In ipv6_force_forwarding.sh line 43: + ip -n $ns3 link set veth32 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns3" link set veth32 up + + +In ipv6_force_forwarding.sh line 46: + ip -n $ns1 route add 2001:db8:2::/64 via 2001:db8:1::2 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" route add 2001:db8:2::/64 via 2001:db8:1::2 + + +In ipv6_force_forwarding.sh line 47: + ip -n $ns3 route add 2001:db8:1::/64 via 2001:db8:2::1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns3" route add 2001:db8:1::/64 via 2001:db8:2::1 + + +In ipv6_force_forwarding.sh line 50: + ip netns exec $ns2 sysctl -qw net.ipv6.conf.all.forwarding=0 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$ns2" sysctl -qw net.ipv6.conf.all.forwarding=0 + + +In ipv6_force_forwarding.sh line 59: + if ! ip netns exec $ns2 test -f /proc/sys/net/ipv6/conf/veth21/force_forwarding; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if ! ip netns exec "$ns2" test -f /proc/sys/net/ipv6/conf/veth21/force_forwarding; then + + +In ipv6_force_forwarding.sh line 65: + ip netns exec $ns2 sysctl -qw net.ipv6.conf.veth21.force_forwarding=0 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$ns2" sysctl -qw net.ipv6.conf.veth21.force_forwarding=0 + + +In ipv6_force_forwarding.sh line 66: + ip netns exec $ns2 sysctl -qw net.ipv6.conf.veth23.force_forwarding=0 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$ns2" sysctl -qw net.ipv6.conf.veth23.force_forwarding=0 + + +In ipv6_force_forwarding.sh line 68: + if ip netns exec $ns1 ping -6 -c 1 -W 2 2001:db8:2::2 &>/dev/null; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if ip netns exec "$ns1" ping -6 -c 1 -W 2 2001:db8:2::2 &>/dev/null; then + + +In ipv6_force_forwarding.sh line 76: + ip netns exec $ns2 sysctl -qw net.ipv6.conf.veth21.force_forwarding=1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$ns2" sysctl -qw net.ipv6.conf.veth21.force_forwarding=1 + + +In ipv6_force_forwarding.sh line 77: + ip netns exec $ns2 sysctl -qw net.ipv6.conf.veth23.force_forwarding=1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$ns2" sysctl -qw net.ipv6.conf.veth23.force_forwarding=1 + + +In ipv6_force_forwarding.sh line 79: + if ip netns exec $ns1 ping -6 -c 1 -W 2 2001:db8:2::2 &>/dev/null; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if ip netns exec "$ns1" ping -6 -c 1 -W 2 2001:db8:2::2 &>/dev/null; then + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned. + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...