ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.BSnU6KWxrk and /tmp/tmp.7RVRyFIHDM
Tree base:
81e0db8e8398 ("Merge branch 'mlx5-misc-fixes-2025-07-17'")
Now at:
b13d381a49eb ("selftests: netfilter: tone-down conntrack clash test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/conntrack_clash.sh - a00afbba902107e2b49d2d5f043fa4339644dd960e3ac6bdd6eaf88e1106a0e3


In conntrack_clash.sh line 24:
ip netns exec "$nsrouter" nft -f -<<EOF
               ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In conntrack_clash.sh line 63:
		ip netns exec "$ns" socat UDP-RECVFROM:$port,fork PIPE 2>/dev/null &
                                                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip netns exec "$ns" socat UDP-RECVFROM:"$port",fork PIPE 2>/dev/null &


In conntrack_clash.sh line 67:
		wait_local_port_listen "$ns" $port udp
                                             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		wait_local_port_listen "$ns" "$port" udp


In conntrack_clash.sh line 87:
	if ! ip netns exec "$ns" ping -q -c 1 $daddr > /dev/null;then
                                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if ! ip netns exec "$ns" ping -q -c 1 "$daddr" > /dev/null;then


In conntrack_clash.sh line 101:
	if ! ip netns exec "$ns" ./udpclash $daddr $dport;then
                                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                   ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if ! ip netns exec "$ns" ./udpclash "$daddr" "$dport";then


In conntrack_clash.sh line 108:
	cre=$(conntrack -S | grep -v "clash_resolve=0" | wc -l)
                             ^-----------------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In conntrack_clash.sh line 145:
ip link add veth0 netns "$nsclient1" type veth peer name veth0 netns "$nsrouter"
                         ^--------^ SC2154 (warning): nsclient1 is referenced but not assigned.


In conntrack_clash.sh line 146:
ip link add veth0 netns "$nsclient2" type veth peer name veth1 netns "$nsrouter"
                         ^--------^ SC2154 (warning): nsclient2 is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- nsclient1 is referenced but not a...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2126 -- Consider using 'grep -c' instead ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/conntrack_clash.sh - a00afbba902107e2b49d2d5f043fa4339644dd960e3ac6bdd6eaf88e1106a0e3


In conntrack_clash.sh line 24:
ip netns exec "$nsrouter" nft -f -<<EOF
               ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In conntrack_clash.sh line 63:
		ip netns exec "$ns" socat UDP-RECVFROM:$port,fork PIPE 2>/dev/null &
                                                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip netns exec "$ns" socat UDP-RECVFROM:"$port",fork PIPE 2>/dev/null &


In conntrack_clash.sh line 67:
		wait_local_port_listen "$ns" $port udp
                                             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		wait_local_port_listen "$ns" "$port" udp


In conntrack_clash.sh line 87:
	if ! ip netns exec "$ns" ping -q -c 1 $daddr > /dev/null;then
                                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if ! ip netns exec "$ns" ping -q -c 1 "$daddr" > /dev/null;then


In conntrack_clash.sh line 102:
	if ! ip netns exec "$ns" ./udpclash $daddr $dport;then
                                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                   ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if ! ip netns exec "$ns" ./udpclash "$daddr" "$dport";then


In conntrack_clash.sh line 109:
	cre=$(ip netns exec "$ctns" conntrack -S | grep "clash_resolve=0" | wc -l)
                                                   ^--------------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In conntrack_clash.sh line 144:
ip link add veth0 netns "$nsclient1" type veth peer name veth0 netns "$nsrouter"
                         ^--------^ SC2154 (warning): nsclient1 is referenced but not assigned.


In conntrack_clash.sh line 145:
ip link add veth0 netns "$nsclient2" type veth peer name veth1 netns "$nsrouter"
                         ^--------^ SC2154 (warning): nsclient2 is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- nsclient1 is referenced but not a...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2126 -- Consider using 'grep -c' instead ...