ERROR: Using weak declarations can have unintended link defects #74: FILE: tools/bpf/bpftool/main.h:169: +int do_token(int argc, char **argv) __weak; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #79: new file mode 100644 CHECK: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues #105: FILE: tools/bpf/bpftool/token.c:22: +#define zclose(fd) do { if (fd >= 0) close(fd); fd = -1; } while (0) CHECK: Comparison to NULL could be written "strstr" #109: FILE: tools/bpf/bpftool/token.c:26: + return strstr(mnt_ops, "delegate_cmds") != NULL || CHECK: Comparison to NULL could be written "strstr" #110: FILE: tools/bpf/bpftool/token.c:27: + strstr(mnt_ops, "delegate_maps") != NULL || CHECK: Comparison to NULL could be written "strstr" #111: FILE: tools/bpf/bpftool/token.c:28: + strstr(mnt_ops, "delegate_progs") != NULL || CHECK: Comparison to NULL could be written "strstr" #112: FILE: tools/bpf/bpftool/token.c:29: + strstr(mnt_ops, "delegate_attachs") != NULL; CHECK: Comparison to NULL could be written "token" #123: FILE: tools/bpf/bpftool/token.c:40: + for (token = strtok_r(opts_copy, ",", &rest); token != NULL; CHECK: Alignment should match open parenthesis #126: FILE: tools/bpf/bpftool/token.c:43: + if (strncmp(token, key, strlen(key)) == 0 && + token[strlen(key)] == '=') { CHECK: Comparison to NULL could be written "str" #145: FILE: tools/bpf/bpftool/token.c:62: + for (str = strtok_r(strs, ":", &rest); str != NULL; CHECK: Comparison to NULL could be written "str" #199: FILE: tools/bpf/bpftool/token.c:116: + for (str = strtok_r(strs, ":", &rest); str != NULL; CHECK: Blank lines aren't necessary after an open brace '{' #241: FILE: tools/bpf/bpftool/token.c:158: +{ + total: 1 errors, 1 warnings, 10 checks, 251 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c1894a897fc7 ("bpftool: Add bpf_token show") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.