ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.eM8RyoiGxa and /tmp/tmp.XVNz1KIEuo Tree base: a96cee9b369e ("Merge branch 'ppp-replace-per-cpu-recursion-counter-with-lock-owner-field'") Now at: f91cefe4bbe8 ("selftests: rtnetlink: Add operational state test") ====== Checking before the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 54: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 68: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 84: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 85: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 103: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 104: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 111: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 112: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 122: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 127: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 150: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 153: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 155: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 183: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 198: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 199: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 200: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 201: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 208: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 210: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 236: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 253: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 262: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 286: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 298: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 309: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 324: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 326: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 330: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 331: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 336: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 363: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 378: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 385: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 410: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 423: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 425: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 428: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 433: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 442: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 455: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 457: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 488: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 500: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 502: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 507: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 512: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 519: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 532: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 534: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 543: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 551: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 553: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 556: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 566: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 598: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 600: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 606: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 607: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 611: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 613: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 616: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 617: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 620: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 621: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 622: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 624: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 625: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 628: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 629: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 633: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 634: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 638: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 639: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 641: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 643: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 644: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 647: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 648: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 649: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 650: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 655: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 657: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 694: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 696: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 702: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 704: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 706: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 707: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 708: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 712: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 721: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 722: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 725: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 726: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 729: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 730: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 731: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 733: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 734: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 735: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 737: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 743: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 744: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 750: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 752: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 755: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 764: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 772: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 773: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 782: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 795: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 797: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 801: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 804: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 813: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 820: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 836: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 838: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 842: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 845: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 854: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 861: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 876: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 878: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 881: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 883: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 893: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 903: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 910: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 925: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 927: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 930: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 932: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 942: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 952: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 961: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 981: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 983: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 987: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 989: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 993: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 995: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 996: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 997: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 998: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 999: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1000: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1001: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1003: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1005: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1021: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1023: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1027: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1029: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1033: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1034: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1035: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1036: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1037: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1038: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1039: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1040: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1042: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1044: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1060: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1062: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1066: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1067: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1068: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1071: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1072: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1073: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1076: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1077: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1078: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1081: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1082: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1083: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1085: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1101: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1103: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1109: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1111: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1113: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1114: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1116: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1117: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1128: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1209: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1226: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1235: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1237: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1240: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1241: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1242: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1243: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1244: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1264: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1265: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1267: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1270: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1276: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1277: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1285: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1299: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1301: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1305: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1306: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1307: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1308: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1309: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1310: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1316: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1321: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1327: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1328: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1329: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1331: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1334: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1337: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1344: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1373: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1388: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 55: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 69: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 85: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 86: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 104: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 105: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 112: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 113: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 123: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 128: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 151: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 154: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 156: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 184: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 199: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 200: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 201: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 202: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 209: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 211: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 237: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 254: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 263: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 287: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 299: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 310: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 325: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 327: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 331: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 332: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 337: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 364: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 379: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 386: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 411: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 424: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 426: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 429: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 434: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 443: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 456: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 458: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 489: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 501: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 503: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 508: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 513: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 520: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 533: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 535: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 544: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 552: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 554: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 557: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 567: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 599: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 601: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 607: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 608: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 612: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 614: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 617: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 618: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 621: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 622: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 623: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 625: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 626: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 629: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 630: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 634: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 635: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 639: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 640: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 642: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 644: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 645: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 648: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 649: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 650: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 651: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 656: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 658: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 695: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 697: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 703: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 705: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 707: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 708: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 709: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 713: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 722: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 723: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 726: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 727: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 730: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 731: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 732: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 734: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 735: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 736: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 738: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 744: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 745: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 751: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 753: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 756: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 765: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 773: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 774: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 783: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 796: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 798: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 802: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 805: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 814: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 821: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 837: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 839: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 843: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 846: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 855: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 862: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 877: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 879: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 882: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 884: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 894: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 904: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 911: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 926: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 928: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 931: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 933: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 943: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 953: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 962: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 982: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 984: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 988: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 990: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 994: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 996: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 997: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 998: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 999: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1000: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1001: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1002: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1004: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1006: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1022: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1024: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1028: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1030: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1034: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1035: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1036: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1037: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1038: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1039: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1040: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1041: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1043: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1045: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1061: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1063: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1067: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1068: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1069: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1072: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1073: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1074: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1077: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1078: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1079: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1082: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1083: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1084: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1086: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1102: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1104: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1110: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1112: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1114: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1115: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1117: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1118: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1129: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1210: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1227: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1236: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1238: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1241: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1242: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1243: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1244: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1245: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1265: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1266: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1268: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1271: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1277: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1278: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1286: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1300: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1302: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1306: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1307: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1308: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1309: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1310: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1311: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1317: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1322: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1328: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1329: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1330: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1332: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1335: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1338: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1345: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1407: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1422: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi...