CHECK: Lines should not end with a '(' #401: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:135: + sensor->data_types[i].name = devm_kstrdup_const( CHECK: Lines should not end with a '(' #403: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:137: + sensor->data_types[i].vendor = devm_kstrdup_const( CHECK: Lines should not end with a '(' #412: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:146: + .native_sample_rates = devm_kmemdup_array( CHECK: braces {} should be used on all arms of this statement #444: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:178: + if (enable) { [...] + } else [...] CHECK: Unbalanced braces around else statement #488: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:222: + } else CHECK: Alignment should match open parenthesis #549: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:283: + dev_warn_ratelimited(smgr->dev, + "Received buffering report with unknown ID: %02x", WARNING: line length of 81 exceeds 80 columns #567: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:301: + * The value reported is a boolean (0 or 1, still in the same fixed-point WARNING: line length of 81 exceeds 80 columns #942: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:676: +static const struct iio_chan_spec *const qcom_smgr_sensor_type_iio_channels[] = { WARNING: line length of 84 exceeds 80 columns #955: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:689: + [SNS_SMGR_SENSOR_TYPE_PROX_LIGHT] = ARRAY_SIZE(qcom_smgr_prox_iio_channels), WARNING: line length of 85 exceeds 80 columns #956: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:690: + [SNS_SMGR_SENSOR_TYPE_PRESSURE] = ARRAY_SIZE(qcom_smgr_pressure_iio_channels) WARNING: line length of 81 exceeds 80 columns #980: FILE: drivers/iio/common/qcom_smgr/qcom_smgr.c:714: + iio_dev->num_channels = qcom_smgr_sensor_type_num_channels[sensor->type]; CHECK: Lines should not end with a '(' #1204: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:83: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1221: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:100: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1231: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:110: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1241: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:120: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1258: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:137: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1276: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:155: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1285: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:164: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1295: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:174: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1304: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:183: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1314: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:193: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1323: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:202: + .elem_size = sizeof_field( WARNING: line length of 90 exceeds 80 columns #1335: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:214: +static const struct qmi_elem_info sns_smgr_single_sensor_info_native_sample_rates_ei[] = { CHECK: Lines should not end with a '(' #1339: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:218: + .elem_size = sizeof_field( WARNING: line length of 92 exceeds 80 columns #1340: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:219: + struct sns_smgr_single_sensor_info_native_sample_rates, rate_count), WARNING: line length of 90 exceeds 80 columns #1342: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:221: + .offset = offsetof(struct sns_smgr_single_sensor_info_native_sample_rates, WARNING: line length of 90 exceeds 80 columns #1350: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:229: + .offset = offsetof(struct sns_smgr_single_sensor_info_native_sample_rates, CHECK: Lines should not end with a '(' #1362: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:241: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1372: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:251: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1393: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:272: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1412: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:291: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1422: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:301: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1441: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:320: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1452: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:331: + .elem_size = sizeof( CHECK: Lines should not end with a '(' #1463: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:342: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1540: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:419: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1550: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:429: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1673: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:552: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1692: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:571: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1701: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:580: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1724: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:603: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1733: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:612: + .elem_size = sizeof_field( CHECK: Lines should not end with a '(' #1742: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.c:621: + .elem_size = sizeof_field( WARNING: line length of 90 exceeds 80 columns #1928: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.h:88: + struct sns_smgr_single_sensor_info_data_type data_types[SNS_SMGR_DATA_TYPE_COUNT]; WARNING: line length of 82 exceeds 80 columns #1988: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.h:148: + struct sns_smgr_buffering_report_sample samples[SNS_SMGR_SAMPLES_MAX_LEN]; WARNING: line length of 81 exceeds 80 columns #1999: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.h:159: +extern enum qcom_smgr_sensor_type sns_smgr_sensor_type_from_str(const char *str); CHECK: extern prototypes should be avoided in .h files #1999: FILE: drivers/iio/common/qcom_smgr/qmi/qmi_sns_smgr.h:159: +extern enum qcom_smgr_sensor_type sns_smgr_sensor_type_from_str(const char *str); CHECK: Please don't use multiple blank lines #2070: FILE: include/linux/iio/common/qcom_smgr.h:63: + + total: 0 errors, 12 warnings, 36 checks, 1990 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 65a702c06197 ("iio: Add Qualcomm Sensor Manager driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 36 checks, 1990 lines checked