========== checkpatch - FAILED WARNING: line length of 89 exceeds 80 columns #25: FILE: tools/testing/selftests/bpf/bpf_arena_common.h:49: +int bpf_arena_reserve_pages(void *map, void __arena *addr, __u32 page_cnt) __ksym __weak; WARNING: line length of 84 exceeds 80 columns #28: FILE: tools/testing/selftests/bpf/bpf_arena_common.h:52: +#define arena_base(map) ((void __arena *)((struct bpf_arena *)(map))->user_vm_start) WARNING: line length of 81 exceeds 80 columns #73: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:142: + /* Try to implicitly allocate the page (since there's only 2 of them). */ WARNING: line length of 99 exceeds 80 columns #165: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:70: +/* Try to access a reserved page. Behavior should be identical with accessing unallocated pages. */ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #171: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:76: + volatile char __arena *page; CHECK: multiple assignments should be avoided #177: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:82: + page = base = arena_base(&arena) + 16384 * PAGE_SIZE; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #188: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:93: + page = (volatile char __arena *)(base + i * PAGE_SIZE); WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #210: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:115: + volatile char __arena *page; CHECK: multiple assignments should be avoided #215: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:120: + page = base = arena_base(&arena) + 4096 * __PAGE_SIZE; ERROR: space prohibited before that ',' (ctx:WxW) #253: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:158: + bpf_arena_free_pages(&arena, addr + __PAGE_SIZE , 2); ^ WARNING: line length of 87 exceeds 80 columns #255: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:160: + /* The free call above should have succeeded, so this allocation should too. */ WARNING: line length of 85 exceeds 80 columns #256: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:161: + page = bpf_arena_alloc_pages(&arena, addr + __PAGE_SIZE, 2, NUMA_NO_NODE, 0); total: 1 errors, 9 warnings, 2 checks, 233 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit aea55b23a4d0 ("selftests/bpf: add selftests for bpf_arena_reserve_pages") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.