pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.UfFPUPrQ4C and /tmp/tmp.LazQZONGPx Tree base: ea988b450690 ("udp: remove udp_tunnel_gro_init()") Now at: 85816270cd16 ("selftests: drv-net: add helper/wrapper for bpftrace") ====== Checking before the patch ====== ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 3.33/10, +0.00) ************* Module py.utils tools/testing/selftests/net/lib/py/utils.py:141:0: C0301: Line too long (124/100) (line-too-long) tools/testing/selftests/net/lib/py/utils.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/utils.py:14:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:20:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:22:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/testing/selftests/net/lib/py/utils.py:28:0: C0103: Class name "cmd" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:34:4: R0913: Too many arguments (9/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:34:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:69:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:60:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/testing/selftests/net/lib/py/utils.py:73:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:91:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/net/lib/py/utils.py:28:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/utils.py:95:0: C0103: Class name "bkg" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:114:4: R0913: Too many arguments (8/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:114:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:136:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:136:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:138:8: W0602: Using global for 'global_defer_queue' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/utils.py:141:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:156:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:159:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:162:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:167:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:178:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:184:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:188:14: W0622: Redefining built-in 'type' (redefined-builtin) tools/testing/selftests/net/lib/py/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:197:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:197:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:211:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:3:0: W0611: Unused import errno (unused-import) tools/testing/selftests/net/lib/py/utils.py:6:0: W0611: Unused import random (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.48/10 (previous run: 7.84/10, -0.36) ====== Checking the tree with the patch ====== ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:27:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:29:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:34:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 3.33/10, +0.00) ************* Module py.utils tools/testing/selftests/net/lib/py/utils.py:141:0: C0301: Line too long (124/100) (line-too-long) tools/testing/selftests/net/lib/py/utils.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/utils.py:14:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:20:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:22:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/testing/selftests/net/lib/py/utils.py:28:0: C0103: Class name "cmd" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:34:4: R0913: Too many arguments (9/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:34:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:69:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:60:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/testing/selftests/net/lib/py/utils.py:73:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:91:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/net/lib/py/utils.py:28:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/utils.py:95:0: C0103: Class name "bkg" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:114:4: R0913: Too many arguments (8/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:114:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:136:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/utils.py:136:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/utils.py:138:8: W0602: Using global for 'global_defer_queue' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/utils.py:141:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:156:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:159:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:162:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:167:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:178:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:184:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:221:14: W0622: Redefining built-in 'type' (redefined-builtin) tools/testing/selftests/net/lib/py/utils.py:230:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/utils.py:230:0: R0913: Too many arguments (6/5) (too-many-arguments) tools/testing/selftests/net/lib/py/utils.py:230:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/testing/selftests/net/lib/py/utils.py:244:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/utils.py:3:0: W0611: Unused import errno (unused-import) tools/testing/selftests/net/lib/py/utils.py:6:0: W0611: Unused import random (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.81/10 (previous run: 7.48/10, +0.33)