ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.HXxoWrHaTZ and /tmp/tmp.6jO33AAiWV
Tree base:
df65b936eff9 ("bonding: update ntt to true in passive mode")
Now at:
1d0cca7ce0cc ("selftests: bonding: add test for passive LACP mode")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/bonding/bond_passive_lacp.sh - d07a65ed606c4922666022e989934d406754d37b37427d5aedfa7ae47f950485


In bond_passive_lacp.sh line 7:
source ${lib_dir}/bond_topo_lacp.sh
^-- SC3046 (warning): In POSIX sh, 'source' in place of '.' is undefined.
^-- SC3051 (warning): In POSIX sh, 'source' in place of '.' is undefined.
       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
source "${lib_dir}"/bond_topo_lacp.sh


In bond_passive_lacp.sh line 14:
if slowwait 15 ip netns exec ${s_ns} grep -q 'port state: 143' /proc/net/bonding/bond0; then
                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
if slowwait 15 ip netns exec "${s_ns}" grep -q 'port state: 143' /proc/net/bonding/bond0; then


In bond_passive_lacp.sh line 17:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).


In bond_passive_lacp.sh line 21:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC3046 -- In POSIX sh, 'source' in place of...
  https://www.shellcheck.net/wiki/SC3051 -- In POSIX sh, 'source' in place of...

Checking tools/testing/selftests/drivers/net/bonding/bond_topo_lacp.sh - 6845fce1984e16e7bf0dc6578c28f323cd256a2262f3b6564b915e7763c6613e


In bond_topo_lacp.sh line 34:
	ip netns exec ${s_ns} sysctl -q net.ipv6.conf.default.keep_addr_on_down=1
                      ^-----^ SC2154 (warning): s_ns is referenced but not assigned.
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "${s_ns}" sysctl -q net.ipv6.conf.default.keep_addr_on_down=1


In bond_topo_lacp.sh line 35:
	ip -n ${s_ns} link add eth0 type veth peer name eth0 netns ${c_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----^ SC2154 (warning): c_ns is referenced but not assigned.
                                                                   ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link add eth0 type veth peer name eth0 netns "${c_ns}"


In bond_topo_lacp.sh line 36:
	ip -n ${s_ns} link add eth1 type veth peer name eth1 netns ${c_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link add eth1 type veth peer name eth1 netns "${c_ns}"


In bond_topo_lacp.sh line 37:
	ip -n ${s_ns} link add bond0 type bond mode 802.3ad miimon 100 lacp_active on lacp_rate fast
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link add bond0 type bond mode 802.3ad miimon 100 lacp_active on lacp_rate fast


In bond_topo_lacp.sh line 38:
	ip -n ${s_ns} link set eth0 master bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link set eth0 master bond0


In bond_topo_lacp.sh line 39:
	ip -n ${s_ns} link set eth1 master bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link set eth1 master bond0


In bond_topo_lacp.sh line 40:
	ip -n ${s_ns} addr add ${s_ip4}/24 dev bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" addr add ${s_ip4}/24 dev bond0


In bond_topo_lacp.sh line 41:
	ip -n ${s_ns} addr add ${s_ip6}/24 dev bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" addr add ${s_ip6}/24 dev bond0


In bond_topo_lacp.sh line 42:
	ip -n ${s_ns} link set bond0 up
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${s_ns}" link set bond0 up


In bond_topo_lacp.sh line 47:
	ip netns exec ${c_ns} sysctl -q net.ipv6.conf.default.keep_addr_on_down=1
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "${c_ns}" sysctl -q net.ipv6.conf.default.keep_addr_on_down=1


In bond_topo_lacp.sh line 48:
	ip -n ${c_ns} link add bond0 type bond mode 802.3ad miimon 100 lacp_active on lacp_rate fast
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" link add bond0 type bond mode 802.3ad miimon 100 lacp_active on lacp_rate fast


In bond_topo_lacp.sh line 49:
	ip -n ${c_ns} link set eth0 master bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" link set eth0 master bond0


In bond_topo_lacp.sh line 50:
	ip -n ${c_ns} link set eth1 master bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" link set eth1 master bond0


In bond_topo_lacp.sh line 51:
	ip -n ${c_ns} addr add ${c_ip4}/24 dev bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" addr add ${c_ip4}/24 dev bond0


In bond_topo_lacp.sh line 52:
	ip -n ${c_ns} addr add ${c_ip6}/24 dev bond0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" addr add ${c_ip6}/24 dev bond0


In bond_topo_lacp.sh line 53:
	ip -n ${c_ns} link set bond0 up
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${c_ns}" link set bond0 up


In bond_topo_lacp.sh line 71:
	ip -n ${netns} link set bond0 down
              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${netns}" link set bond0 down


In bond_topo_lacp.sh line 72:
	ip -n ${netns} link set bond0 type bond $param
              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${netns}" link set bond0 type bond "$param"


In bond_topo_lacp.sh line 73:
	ip -n ${netns} link set bond0 up
              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -n "${netns}" link set bond0 up


In bond_topo_lacp.sh line 76:
	slowwait 10 ip netns exec ${c_ns} ping6 ${s_ip6} -c 1 -W 0.1 &> /dev/null
                                  ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	slowwait 10 ip netns exec "${c_ns}" ping6 ${s_ip6} -c 1 -W 0.1 &> /dev/null

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- c_ns is referenced but not assign...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...