ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.nyl50q7xgw and /tmp/tmp.5O5HOdu5i4
Tree base:
5780e9abf1f3 ("selftests: ethtool: Drop the unused old_netdevs variable")
Now at:
35e34ef62786 ("selftests: ethtool: Introduce ethernet PHY selftests on netdevsim")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh - 96396ff6ab6bdd3c996088938f8cfa96ad87ac1a24714cc19d3162809b71da2e


In ethtool-common.sh line 31:
    if [ $code $cop 0 ]; then
    ^-- SC1009 (info): The mentioned syntax error was in this if expression.
       ^-- SC1073 (error): Couldn't parse this test expression. Fix to allow more checks.
               ^-- SC1072 (error): Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again.

For more information:
  https://www.shellcheck.net/wiki/SC1072 -- Expected test to end here (don't ...
  https://www.shellcheck.net/wiki/SC1073 -- Couldn't parse this test expressi...
  https://www.shellcheck.net/wiki/SC1009 -- The mentioned syntax error was in...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh - 96396ff6ab6bdd3c996088938f8cfa96ad87ac1a24714cc19d3162809b71da2e


In ethtool-common.sh line 31:
    if [ $code $cop 0 ]; then
    ^-- SC1009 (info): The mentioned syntax error was in this if expression.
       ^-- SC1073 (error): Couldn't parse this test expression. Fix to allow more checks.
               ^-- SC1072 (error): Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again.

For more information:
  https://www.shellcheck.net/wiki/SC1072 -- Expected test to end here (don't ...
  https://www.shellcheck.net/wiki/SC1073 -- Couldn't parse this test expressi...
  https://www.shellcheck.net/wiki/SC1009 -- The mentioned syntax error was in...

Checking tools/testing/selftests/drivers/net/netdevsim/ethtool-phy.sh - 022c4f8724fa0f92f68c163dd288563f1dd07ebc95c45b18f1c1214bc3407535


In ethtool-phy.sh line 4:
source ethtool-common.sh
       ^---------------^ SC1094 (warning): Parsing of sourced file failed. Ignoring it.


In ethtool-phy.sh line 33:
PHY_DFS=$(make_phydev_on_netdev "$NSIM_ID" 0)
^-----^ SC2034 (warning): PHY_DFS appears unused. Verify use (or export if used externally).
                                 ^------^ SC2153 (info): Possible misspelling: NSIM_ID may not be assigned. Did you mean NSIM_ID2?


In ethtool-phy.sh line 40:
PHY2_DFS=$(make_phydev_on_netdev "$NSIM_ID" 0)
^------^ SC2034 (warning): PHY2_DFS appears unused. Verify use (or export if used externally).


In ethtool-phy.sh line 44:
NSIM_NETDEV_2=$(make_netdev_from_id "$NSIM_ID2")
^-----------^ SC2034 (warning): NSIM_NETDEV_2 appears unused. Verify use (or export if used externally).


In ethtool-phy.sh line 46:
PHY3_DFS=$(make_phydev_on_netdev "$NSIM_ID2" 0);
^------^ SC2034 (warning): PHY3_DFS appears unused. Verify use (or export if used externally).


In ethtool-phy.sh line 58:
if [ "$num_errors" -eq 0 ]; then
      ^---------^ SC2154 (warning): num_errors is referenced but not assigned.


In ethtool-phy.sh line 59:
    echo "PASSED all $((num_passes)) checks"
                        ^--------^ SC2154 (warning): num_passes is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC1094 -- Parsing of sourced file failed. I...
  https://www.shellcheck.net/wiki/SC2034 -- NSIM_NETDEV_2 appears unused. Ver...
  https://www.shellcheck.net/wiki/SC2154 -- num_errors is referenced but not ...