WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 WARNING: line length of 82 exceeds 80 columns #122: FILE: net/quic/path.c:48: + struct quic_udp_sock *us = container_of(work, struct quic_udp_sock, work); WARNING: line length of 81 exceeds 80 columns #125: FILE: net/quic/path.c:51: + head = quic_udp_sock_head(sock_net(us->sk), ntohs(us->addr.v4.sin_port)); WARNING: line length of 86 exceeds 80 columns #133: FILE: net/quic/path.c:59: +static struct quic_udp_sock *quic_udp_sock_create(struct sock *sk, union quic_addr *a) WARNING: line length of 95 exceeds 80 columns #180: FILE: net/quic/path.c:106: +/* Lookup a quic_udp_sock in the global hash table. If not found, creates and returns a new one WARNING: line length of 96 exceeds 80 columns #183: FILE: net/quic/path.c:109: +static struct quic_udp_sock *quic_udp_sock_lookup(struct sock *sk, union quic_addr *a, u16 port) WARNING: line length of 89 exceeds 80 columns #271: FILE: net/quic/path.c:197: + * Promotes the alternate path (path[1]) to become the new active path (path[0]). If the WARNING: line length of 90 exceeds 80 columns #272: FILE: net/quic/path.c:198: + * alternate path has a valid UDP socket, the entire path is swapped. Otherwise, only the WARNING: line length of 93 exceeds 80 columns #273: FILE: net/quic/path.c:199: + * destination address is exchanged, assuming the source address is the same and no rebind is WARNING: line length of 87 exceeds 80 columns #297: FILE: net/quic/path.c:223: + * This is used for cleanup during error handling or when the path is no longer needed. WARNING: line length of 92 exceeds 80 columns #312: FILE: net/quic/path.c:238: + * If the new source or destination address differs from the active path, and alternate path WARNING: line length of 92 exceeds 80 columns #313: FILE: net/quic/path.c:239: + * detection is not disabled, the function pdates the alternate path slot (path[1]) with the WARNING: line length of 93 exceeds 80 columns #316: FILE: net/quic/path.c:242: + * This is typically called on packet receive to detect new possible network paths (e.g., NAT WARNING: line length of 97 exceeds 80 columns #321: FILE: net/quic/path.c:247: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 98 exceeds 80 columns #324: FILE: net/quic/path.c:250: + if ((!quic_cmp_sk_addr(sk, quic_path_saddr(paths, 0), sa) && !paths->disable_saddr_alt) || WARNING: line length of 98 exceeds 80 columns #325: FILE: net/quic/path.c:251: + (!quic_cmp_sk_addr(sk, quic_path_daddr(paths, 0), da) && !paths->disable_daddr_alt)) { WARNING: line length of 87 exceeds 80 columns #340: FILE: net/quic/path.c:266: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 87 exceeds 80 columns #349: FILE: net/quic/path.c:275: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 92 exceeds 80 columns #378: FILE: net/quic/path.c:304: + * Called immediately after sending a probe packet in QUIC Path MTU Discovery. Tracks probe WARNING: line length of 93 exceeds 80 columns #379: FILE: net/quic/path.c:305: + * count and manages state transitions based on the number of probes sent and current PLPMTUD WARNING: line length of 92 exceeds 80 columns #380: FILE: net/quic/path.c:306: + * state (BASE, SEARCH, COMPLETE, ERROR). Detects probe failures and black holes, adjusting WARNING: line length of 99 exceeds 80 columns #395: FILE: net/quic/path.c:321: + if (paths->pl.probe_size == QUIC_BASE_PLPMTU) { /* BASE_PLPMTU Confirming Failed */ WARNING: line length of 87 exceeds 80 columns #402: FILE: net/quic/path.c:328: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 87 exceeds 80 columns #414: FILE: net/quic/path.c:340: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 86 exceeds 80 columns #415: FILE: net/quic/path.c:341: + paths->pl.state = QUIC_PL_BASE; /* Search Complete -> Base */ WARNING: line length of 91 exceeds 80 columns #424: FILE: net/quic/path.c:350: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #425: FILE: net/quic/path.c:351: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 90 exceeds 80 columns #432: FILE: net/quic/path.c:358: + * Called when a probe packet is acknowledged. Updates probe size and transitions state if WARNING: line length of 86 exceeds 80 columns #433: FILE: net/quic/path.c:359: + * needed (e.g., from SEARCH to COMPLETE). Expands PMTU using binary or linear search WARNING: line length of 87 exceeds 80 columns #438: FILE: net/quic/path.c:364: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete) WARNING: line length of 91 exceeds 80 columns #442: FILE: net/quic/path.c:368: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #443: FILE: net/quic/path.c:369: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 89 exceeds 80 columns #462: FILE: net/quic/path.c:388: + (u16)min(paths->pl.probe_size + QUIC_PL_BIG_STEP, WARNING: line length of 91 exceeds 80 columns #472: FILE: net/quic/path.c:398: + paths->pl.state = QUIC_PL_COMPLETE; /* Search -> Search Complete */ WARNING: line length of 83 exceeds 80 columns #479: FILE: net/quic/path.c:405: + /* Raise probe_size again after 30 * interval in Search Complete */ WARNING: line length of 81 exceeds 80 columns #480: FILE: net/quic/path.c:406: + paths->pl.state = QUIC_PL_SEARCH; /* Search Complete -> Search */ WARNING: line length of 88 exceeds 80 columns #481: FILE: net/quic/path.c:407: + paths->pl.probe_size = (u16)min(paths->pl.probe_size + QUIC_PL_MIN_STEP, WARNING: line length of 90 exceeds 80 columns #491: FILE: net/quic/path.c:417: + * Responds to an incoming ICMP error by reducing the probe size or falling back to a safe WARNING: line length of 89 exceeds 80 columns #492: FILE: net/quic/path.c:418: + * baseline PMTU depending on current state. Also handles cases where the PMTU hint lies WARNING: line length of 83 exceeds 80 columns #497: FILE: net/quic/path.c:423: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer) WARNING: line length of 90 exceeds 80 columns #501: FILE: net/quic/path.c:427: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, ptb: %d\n", __func__, paths, WARNING: line length of 92 exceeds 80 columns #524: FILE: net/quic/path.c:450: + } else if (pmtu > (u32)paths->pl.pmtu && pmtu < (u32)paths->pl.probe_size) { WARNING: line length of 92 exceeds 80 columns #545: FILE: net/quic/path.c:471: + * Resets all PLPMTUD-related state to its initial configuration. Called when a new path is WARNING: line length of 90 exceeds 80 columns #558: FILE: net/quic/path.c:484: + * Checks whether the last probe (tracked by .number) has been acknowledged. If the probe WARNING: line length of 83 exceeds 80 columns #563: FILE: net/quic/path.c:489: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest) WARNING: line length of 95 exceeds 80 columns #565: FILE: net/quic/path.c:491: + return paths->pl.number && paths->pl.number >= smallest && paths->pl.number <= largest; WARNING: line length of 87 exceeds 80 columns #627: FILE: net/quic/path.h:40: + QUIC_PATH_ALT_NONE, /* No alternate path (migration complete or aborted) */ WARNING: line length of 85 exceeds 80 columns #628: FILE: net/quic/path.h:41: + QUIC_PATH_ALT_PENDING, /* Waiting for a new destination CID for migration */ WARNING: line length of 84 exceeds 80 columns #629: FILE: net/quic/path.h:42: + QUIC_PATH_ALT_PROBING, /* Validating the alternate path (PATH_CHALLENGE) */ WARNING: line length of 81 exceeds 80 columns #630: FILE: net/quic/path.h:43: + QUIC_PATH_ALT_SWAPPED, /* Alternate path is now active; roles swapped */ WARNING: line length of 84 exceeds 80 columns #634: FILE: net/quic/path.h:47: + struct work_struct work; /* Workqueue to destroy UDP tunnel socket */ WARNING: line length of 90 exceeds 80 columns #635: FILE: net/quic/path.h:48: + struct hlist_node node; /* Entry in address-based UDP socket hash table */ WARNING: line length of 93 exceeds 80 columns #644: FILE: net/quic/path.h:57: + struct quic_udp_sock *udp_sk; /* Wrapped UDP socket used to receive QUIC packets */ WARNING: line length of 82 exceeds 80 columns #649: FILE: net/quic/path.h:62: + struct quic_conn_id retry_dcid; /* Source CID from Retry packet */ WARNING: line length of 88 exceeds 80 columns #650: FILE: net/quic/path.h:63: + struct quic_conn_id orig_dcid; /* Destination CID from first Initial */ WARNING: line length of 92 exceeds 80 columns #654: FILE: net/quic/path.h:67: + struct quic_path path[2]; /* Active path (0) and alternate path (1) */ WARNING: line length of 86 exceeds 80 columns #655: FILE: net/quic/path.h:68: + struct flowi fl; /* Flow info from routing decisions */ WARNING: line length of 82 exceeds 80 columns #662: FILE: net/quic/path.h:75: + u32 mtu_info; /* PMTU value from received ICMP, pending apply */ WARNING: line length of 92 exceeds 80 columns #674: FILE: net/quic/path.h:87: + u8 disable_saddr_alt:1; /* Remote disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 91 exceeds 80 columns #675: FILE: net/quic/path.h:88: + u8 disable_daddr_alt:1; /* Local disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 86 exceeds 80 columns #676: FILE: net/quic/path.h:89: + u8 pref_addr:1; /* Preferred address offered (rfc9000#section-18.2) */ WARNING: line length of 90 exceeds 80 columns #678: FILE: net/quic/path.h:91: + u8 alt_state; /* State for alternate path migration logic (see above) */ WARNING: line length of 86 exceeds 80 columns #687: FILE: net/quic/path.h:100: +static inline union quic_addr *quic_path_saddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #698: FILE: net/quic/path.h:111: +static inline union quic_addr *quic_path_daddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #709: FILE: net/quic/path.h:122: +static inline union quic_addr *quic_path_uaddr(struct quic_path_group *paths, u8 path) WARNING: line length of 83 exceeds 80 columns #719: FILE: net/quic/path.h:132: +static inline void quic_path_set_alt_state(struct quic_path_group *paths, u8 state) WARNING: line length of 84 exceeds 80 columns #724: FILE: net/quic/path.h:137: +/* Returns the destination Connection ID (DCID) used for identifying the connection. WARNING: line length of 88 exceeds 80 columns #725: FILE: net/quic/path.h:138: + * Per rfc9000#section-7.3, handshake packets are considered part of the same connection WARNING: line length of 85 exceeds 80 columns #728: FILE: net/quic/path.h:141: +static inline struct quic_conn_id *quic_path_orig_dcid(struct quic_path_group *paths) WARNING: line length of 97 exceeds 80 columns #733: FILE: net/quic/path.h:146: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 88 exceeds 80 columns #739: FILE: net/quic/path.h:152: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete); WARNING: line length of 84 exceeds 80 columns #740: FILE: net/quic/path.h:153: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer); WARNING: line length of 88 exceeds 80 columns #743: FILE: net/quic/path.h:156: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 88 exceeds 80 columns #744: FILE: net/quic/path.h:157: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 84 exceeds 80 columns #745: FILE: net/quic/path.h:158: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest); total: 0 errors, 75 warnings, 0 checks, 734 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit cd1229ecfecf ("quic: add path management") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 75 warnings, 0 checks, 734 lines checked