====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.30nzG4e2LB 2025-07-03 01:12:20.063977059 -0700 +++ /tmp/tmp.amznkPW1Fl 2025-07-03 01:12:20.271975637 -0700 @@ -7,2 +7,10 @@ -In vlan_hw_filter.sh line 9: - ip netns del $NETNS +In vlan_hw_filter.sh line 17: + ip netns add ${NETNS} + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns add "${NETNS}" + + +In vlan_hw_filter.sh line 21: + ip netns del $NETNS 2>/dev/null @@ -12 +20,6 @@ - ip netns del "$NETNS" + ip netns del "$NETNS" 2>/dev/null + + +In vlan_hw_filter.sh line 27: + echo "ERROR: ${1:-unexpected return code} (ret: $_)" >&2 + ^-- SC3028 (warning): In POSIX sh, _ is undefined. @@ -15,3 +28,3 @@ -In vlan_hw_filter.sh line 15: - echo "ERROR: ${1:-unexpected return code} (ret: $_)" >&2 - ^-- SC3028 (warning): In POSIX sh, _ is undefined. +In vlan_hw_filter.sh line 33: + local current_test + ^----------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. @@ -20,3 +33,3 @@ -In vlan_hw_filter.sh line 19: -ip netns add ${NETNS} - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 41: + ip netns exec ${NETNS} ip link add bond0 type bond mode 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -25 +38 @@ -ip netns add "${NETNS}" + ip netns exec "${NETNS}" ip link add bond0 type bond mode 0 @@ -28,3 +41,3 @@ -In vlan_hw_filter.sh line 20: -ip netns exec ${NETNS} ip link add bond0 type bond mode 0 - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 42: + ip netns exec ${NETNS} ip link add bond_slave_1 type veth peer veth2 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -33 +46 @@ -ip netns exec "${NETNS}" ip link add bond0 type bond mode 0 + ip netns exec "${NETNS}" ip link add bond_slave_1 type veth peer veth2 @@ -36,3 +49,3 @@ -In vlan_hw_filter.sh line 21: -ip netns exec ${NETNS} ip link add bond_slave_1 type veth peer veth2 - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 43: + ip netns exec ${NETNS} ip link set bond_slave_1 master bond0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -41 +54 @@ -ip netns exec "${NETNS}" ip link add bond_slave_1 type veth peer veth2 + ip netns exec "${NETNS}" ip link set bond_slave_1 master bond0 @@ -44,3 +57,3 @@ -In vlan_hw_filter.sh line 22: -ip netns exec ${NETNS} ip link set bond_slave_1 master bond0 - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 44: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -49 +62 @@ -ip netns exec "${NETNS}" ip link set bond_slave_1 master bond0 + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off @@ -52,3 +65,3 @@ -In vlan_hw_filter.sh line 23: -ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 45: + ip netns exec ${NETNS} ip link add link bond_slave_1 name bond_slave_1.0 type vlan id 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -57 +70 @@ -ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off + ip netns exec "${NETNS}" ip link add link bond_slave_1 name bond_slave_1.0 type vlan id 0 @@ -60,3 +73,3 @@ -In vlan_hw_filter.sh line 24: -ip netns exec ${NETNS} ip link add link bond_slave_1 name bond_slave_1.0 type vlan id 0 - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 46: + ip netns exec ${NETNS} ip link add link bond0 name bond0.0 type vlan id 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -65 +78 @@ -ip netns exec "${NETNS}" ip link add link bond_slave_1 name bond_slave_1.0 type vlan id 0 + ip netns exec "${NETNS}" ip link add link bond0 name bond0.0 type vlan id 0 @@ -68,3 +81,3 @@ -In vlan_hw_filter.sh line 25: -ip netns exec ${NETNS} ip link add link bond0 name bond0.0 type vlan id 0 - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 47: + ip netns exec ${NETNS} ip link set bond_slave_1 nomaster + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -73 +86 @@ -ip netns exec "${NETNS}" ip link add link bond0 name bond0.0 type vlan id 0 + ip netns exec "${NETNS}" ip link set bond_slave_1 nomaster @@ -76,3 +89,3 @@ -In vlan_hw_filter.sh line 26: -ip netns exec ${NETNS} ip link set bond_slave_1 nomaster - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 48: + ip netns exec ${NETNS} ip link del veth2 || fail "Please check vlan HW filter function" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -81 +94 @@ -ip netns exec "${NETNS}" ip link set bond_slave_1 nomaster + ip netns exec "${NETNS}" ip link del veth2 || fail "Please check vlan HW filter function" @@ -84,3 +97,203 @@ -In vlan_hw_filter.sh line 27: -ip netns exec ${NETNS} ip link del veth2 || fail "Please check vlan HW filter function" - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In vlan_hw_filter.sh line 55: + ip netns exec ${NETNS} ip link add bond0 type bond mode 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add bond0 type bond mode 0 + + +In vlan_hw_filter.sh line 56: + ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + + +In vlan_hw_filter.sh line 57: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off + + +In vlan_hw_filter.sh line 58: + ip netns exec ${NETNS} ifconfig bond0 up + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 up + + +In vlan_hw_filter.sh line 59: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter on + + +In vlan_hw_filter.sh line 60: + ip netns exec ${NETNS} ifconfig bond0 down + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 down + + +In vlan_hw_filter.sh line 61: + ip netns exec ${NETNS} ifconfig bond0 up + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 up + + +In vlan_hw_filter.sh line 62: + ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link del vlan0 || fail "Please check vlan HW filter function" + + +In vlan_hw_filter.sh line 69: + ip netns exec ${NETNS} ip link add bond0 type bond mode 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add bond0 type bond mode 0 + + +In vlan_hw_filter.sh line 70: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off + + +In vlan_hw_filter.sh line 71: + ip netns exec ${NETNS} ifconfig bond0 up + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 up + + +In vlan_hw_filter.sh line 72: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter on + + +In vlan_hw_filter.sh line 73: + ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + + +In vlan_hw_filter.sh line 74: + ip netns exec ${NETNS} ifconfig bond0 down + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 down + + +In vlan_hw_filter.sh line 75: + ip netns exec ${NETNS} ifconfig bond0 up + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 up + + +In vlan_hw_filter.sh line 76: + ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link del vlan0 || fail "Please check vlan HW filter function" + + +In vlan_hw_filter.sh line 84: + ip netns exec ${NETNS} ip link add bond0 type bond mode 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add bond0 type bond mode 0 + + +In vlan_hw_filter.sh line 85: + ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q + + +In vlan_hw_filter.sh line 86: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off + + +In vlan_hw_filter.sh line 87: + ip netns exec ${NETNS} ifconfig bond0 up + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 up + + +In vlan_hw_filter.sh line 88: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter on + + +In vlan_hw_filter.sh line 89: + ip netns exec ${NETNS} ifconfig bond0 down + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ifconfig bond0 down + + +In vlan_hw_filter.sh line 90: + ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link del vlan0 || fail "Please check vlan HW filter function" + + +In vlan_hw_filter.sh line 96: + ip netns exec ${NETNS} ip link add bond0 up type bond mode 0 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ip link add bond0 up type bond mode 0 + + +In vlan_hw_filter.sh line 97: + ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "${NETNS}" ethtool -K bond0 rx-vlan-filter off + + +In vlan_hw_filter.sh line 98: + ip netns exec ${NETNS} ip link del dev bond0 || fail "Please check vlan HW filter function" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -89 +302 @@ -ip netns exec "${NETNS}" ip link del veth2 || fail "Please check vlan HW filter function" + ip netns exec "${NETNS}" ip link del dev bond0 || fail "Please check vlan HW filter function" @@ -94 +307 @@ - https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined.