====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/netdev-l2addr.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.P7x4oLVnFa 2025-07-02 06:29:59.661007168 -0700 +++ /tmp/tmp.THsDeDNzP2 2025-07-02 06:30:00.535001300 -0700 @@ -97 +97,48 @@ -In lib.sh line 259: +In lib.sh line 249: + echo "$port_id $perm_addr" | ip netns exec $ns tee /sys/bus/netdevsim/devices/netdevsim$nsim_id/new_port > /dev/null + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + echo "$port_id $perm_addr" | ip netns exec "$ns" tee /sys/bus/netdevsim/devices/netdevsim"$nsim_id"/new_port > /dev/null + + +In lib.sh line 251: + local orig_dev=$(basename $(ip netns exec $ns find /sys/bus/netdevsim/devices/netdevsim$nsim_id/net/ -maxdepth 1 -name 'e*' | tail -n 1)) + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-- SC2046 (warning): Quote this to prevent word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local orig_dev=$(basename $(ip netns exec "$ns" find /sys/bus/netdevsim/devices/netdevsim"$nsim_id"/net/ -maxdepth 1 -name 'e*' | tail -n 1)) + + +In lib.sh line 254: + ip -netns $ns link set dev $orig_dev name $new_dev + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -netns "$ns" link set dev "$orig_dev" name "$new_dev" + + +In lib.sh line 255: + ip -netns $ns link set dev $new_dev up + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -netns "$ns" link set dev "$new_dev" up + + +In lib.sh line 257: + echo $new_dev + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + echo "$new_dev" + + +In lib.sh line 276: @@ -107 +154 @@ -In lib.sh line 270: +In lib.sh line 287: @@ -116 +163 @@ -In lib.sh line 282: +In lib.sh line 299: @@ -125 +172 @@ -In lib.sh line 285: +In lib.sh line 302: @@ -134 +181 @@ -In lib.sh line 286: +In lib.sh line 303: @@ -143 +190 @@ -In lib.sh line 288: +In lib.sh line 305: @@ -153 +200 @@ -In lib.sh line 289: +In lib.sh line 306: @@ -161 +208 @@ -In lib.sh line 296: +In lib.sh line 313: @@ -170 +217 @@ -In lib.sh line 304: +In lib.sh line 321: @@ -178 +225 @@ -In lib.sh line 305: +In lib.sh line 322: @@ -183 +230 @@ -In lib.sh line 327: +In lib.sh line 344: @@ -188 +235 @@ -In lib.sh line 385: +In lib.sh line 402: @@ -196 +243 @@ -In lib.sh line 386: +In lib.sh line 403: @@ -204 +251 @@ -In lib.sh line 391: +In lib.sh line 408: @@ -209 +256 @@ -In lib.sh line 396: +In lib.sh line 413: @@ -214 +261 @@ -In lib.sh line 412: +In lib.sh line 429: @@ -222 +269 @@ -In lib.sh line 448: +In lib.sh line 465: @@ -230 +277 @@ -In lib.sh line 450: +In lib.sh line 467: @@ -238 +285 @@ -In lib.sh line 480: +In lib.sh line 497: @@ -246 +293 @@ -In lib.sh line 493: +In lib.sh line 510: @@ -254 +301 @@ -In lib.sh line 501: +In lib.sh line 518: @@ -263 +310 @@ -In lib.sh line 510: +In lib.sh line 527: @@ -271 +318 @@ -In lib.sh line 519: +In lib.sh line 536: @@ -279 +326 @@ -In lib.sh line 545: +In lib.sh line 562: @@ -284 +331 @@ -In lib.sh line 555: +In lib.sh line 572: @@ -289 +336 @@ -In lib.sh line 616: +In lib.sh line 633: @@ -297 +344 @@ -In lib.sh line 618: +In lib.sh line 635: @@ -303,0 +351,150 @@ + https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... + +In netdev-l2addr.sh line 13: + cleanup_netdevsim $NSIM_ADDR + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + cleanup_netdevsim "$NSIM_ADDR" + + +In netdev-l2addr.sh line 14: + cleanup_ns $NS + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + cleanup_ns "$NS" + + +In netdev-l2addr.sh line 31: + local output=$(ip -n $ns link show dev $dev | grep "link/") + ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local output=$(ip -n "$ns" link show dev "$dev" | grep "link/") + + +In netdev-l2addr.sh line 35: + echo $k + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + echo "$k" + + +In netdev-l2addr.sh line 48: +nsim=$(create_netdevsim $NSIM_ADDR $NS) + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +nsim=$(create_netdevsim $NSIM_ADDR "$NS") + + +In netdev-l2addr.sh line 50: +get_addr link/ether $nsim $NS >/dev/null || fail "Couldn't get ether addr" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +get_addr link/ether "$nsim" "$NS" >/dev/null || fail "Couldn't get ether addr" + + +In netdev-l2addr.sh line 51: +get_addr brd $nsim $NS >/dev/null || fail "Couldn't get brd addr" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +get_addr brd "$nsim" "$NS" >/dev/null || fail "Couldn't get brd addr" + + +In netdev-l2addr.sh line 52: +get_addr perm $nsim $NS && fail "Found perm_addr without setting it" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +get_addr perm "$nsim" "$NS" && fail "Found perm_addr without setting it" + + +In netdev-l2addr.sh line 54: +ip -n $NS link set dev $nsim address $TEST_ADDR + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip -n "$NS" link set dev "$nsim" address $TEST_ADDR + + +In netdev-l2addr.sh line 55: +ip -n $NS link set dev $nsim brd $TEST_ADDR + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip -n "$NS" link set dev "$nsim" brd $TEST_ADDR + + +In netdev-l2addr.sh line 57: +[[ "$(get_addr link/ether $nsim $NS)" == "$TEST_ADDR" ]] || fail "Couldn't set ether addr" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +[[ "$(get_addr link/ether "$nsim" "$NS")" == "$TEST_ADDR" ]] || fail "Couldn't set ether addr" + + +In netdev-l2addr.sh line 58: +[[ "$(get_addr brd $nsim $NS)" == "$TEST_ADDR" ]] || fail "Couldn't set brd addr" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +[[ "$(get_addr brd "$nsim" "$NS")" == "$TEST_ADDR" ]] || fail "Couldn't set brd addr" + + +In netdev-l2addr.sh line 60: +nsim_port=$(create_netdevsim_port $NSIM_ADDR $NS 2 $TEST_ADDR) + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +nsim_port=$(create_netdevsim_port $NSIM_ADDR "$NS" 2 $TEST_ADDR) + + +In netdev-l2addr.sh line 62: +get_addr link/ether $nsim_port $NS >/dev/null || fail "Couldn't get ether addr" + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +get_addr link/ether "$nsim_port" "$NS" >/dev/null || fail "Couldn't get ether addr" + + +In netdev-l2addr.sh line 63: +get_addr brd $nsim_port $NS >/dev/null || fail "Couldn't get brd addr" + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +get_addr brd "$nsim_port" "$NS" >/dev/null || fail "Couldn't get brd addr" + + +In netdev-l2addr.sh line 64: +[[ "$(get_addr permaddr $nsim_port $NS)" == "$TEST_ADDR" ]] || fail "Couldn't get permaddr" + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +[[ "$(get_addr permaddr "$nsim_port" "$NS")" == "$TEST_ADDR" ]] || fail "Couldn't get permaddr" + + +In netdev-l2addr.sh line 66: +cleanup_netdevsim $NSIM_ADDR $NS + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +cleanup_netdevsim $NSIM_ADDR "$NS" + +For more information: @@ -304,0 +502 @@ + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...