WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 WARNING: void function return statements are not generally useful #45: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:19: + return; +} WARNING: line length of 94 exceeds 80 columns #100: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:74: + prog = (struct bpf_program **)(((char *)skel) + stream_error_arr[i].prog_off); WARNING: line length of 89 exceeds 80 columns #109: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:83: + ret = bpf_prog_stream_read(prog_fd, 2, buf, sizeof(buf), &ropts); WARNING: line length of 97 exceeds 80 columns #115: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:89: + ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDERR, buf, sizeof(buf), &ropts); WARNING: line length of 100 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:119: + ASSERT_LT(bpf_prog_stream_read(0, BPF_STREAM_STDOUT, buf, sizeof(buf), &ropts), 0, "error"); WARNING: line length of 90 exceeds 80 columns #149: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:123: + ASSERT_LT(bpf_prog_stream_read(prog_fd, 0, buf, sizeof(buf), &ropts), 0, "error"); WARNING: line length of 105 exceeds 80 columns #153: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:127: + ASSERT_LT(bpf_prog_stream_read(prog_fd, BPF_STREAM_STDOUT, NULL, sizeof(buf), NULL), 0, "error"); ERROR: Macros with complex values should be enclosed in parentheses #196: FILE: tools/testing/selftests/bpf/progs/stream.c:23: +#define STREAM_STR (u64)(_STR _STR _STR _STR) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 84 exceeds 80 columns #207: FILE: tools/testing/selftests/bpf/progs/stream.c:34: + if (bpf_stream_printk(BPF_STDOUT, _STR) == -ENOSPC && size == 99954) total: 1 errors, 9 warnings, 0 checks, 239 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7ee5798dba70 ("selftests/bpf: Add tests for prog streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.