ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.OcQg8g9YPH and /tmp/tmp.56kFCqaYJU Tree base: dc35e79c01eb ("seg6: fix lenghts typo in a comment") Now at: 3c7ea66d00ad ("selftests: seg6: fix instaces typo in comments") ====== Checking before the patch ====== Checking tools/testing/selftests/net/srv6_end_next_csid_l3vpn_test.sh - 72a1d51d88d2c0b929060d873c3b9e333f58da838051d6c5c983edac1015586c In srv6_end_next_csid_l3vpn_test.sh line 340: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_end_next_csid_l3vpn_test.sh line 432: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 435: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 467: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 526: printf "${out}" ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_next_csid_l3vpn_test.sh line 533: printf "${LCNODEFUNC_FMT}" "${nodeid}" ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_next_csid_l3vpn_test.sh line 563: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 635: eval rtsrc_nsname=\${$(get_rtname "${src}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 636: eval rtdst_nsname=\${$(get_rtname "${dst}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 711: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 712: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 842: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 865: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 877: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 973: encap seg6local action End flavors next-csid ${layout} \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: encap seg6local action End flavors next-csid "${layout}" \ In srv6_end_next_csid_l3vpn_test.sh line 987: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... Checking tools/testing/selftests/net/srv6_end_x_next_csid_l3vpn_test.sh - 21b8652cd0a18be17cc3cabab36507a7fb38dd6981fc559d176a1ec430d13733 In srv6_end_x_next_csid_l3vpn_test.sh line 385: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_end_x_next_csid_l3vpn_test.sh line 444: eval nsname=\${$(get_rtname "${rtid}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 482: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 485: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 517: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 574: printf "${out}" ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_x_next_csid_l3vpn_test.sh line 581: printf "${LCNODEFUNC_FMT}" "${nodeid}" ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_x_next_csid_l3vpn_test.sh line 604: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 623: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 644: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 679: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 722: eval rtsrc_nsname=\${$(get_rtname "${src}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 723: eval rtdst_nsname=\${$(get_rtname "${dst}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 798: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 799: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 936: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 959: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 971: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 1089: flavors next-csid ${layout} \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flavors next-csid "${layout}" \ In srv6_end_x_next_csid_l3vpn_test.sh line 1103: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... Checking tools/testing/selftests/net/srv6_hencap_red_l3vpn_test.sh - 27236f866c8cc6379746c47ffb7d17df227c837c6c9d6d5ef787820c50d56b7a In srv6_hencap_red_l3vpn_test.sh line 212: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hencap_red_l3vpn_test.sh line 303: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 306: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 338: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 369: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 435: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 482: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 483: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 617: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 640: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 652: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 778: for k in 0 1; do ^-^ SC2034 (warning): k appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2034 -- k appears unused. Verify use (or ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/net/srv6_hl2encap_red_l2vpn_test.sh - fef07094a5dbfa1ba688e02c76977ac8965209102cd45098ccf55d7d82988ce9 In srv6_hl2encap_red_l2vpn_test.sh line 163: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hl2encap_red_l2vpn_test.sh line 255: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 258: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 290: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 324: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 374: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 413: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 430: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 431: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 470: eval nsname=\${${nodename}} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. Did you mean: eval nsname=\${"${nodename}"} In srv6_hl2encap_red_l2vpn_test.sh line 494: eval hssrc_name=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 609: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 632: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 644: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/srv6_end_next_csid_l3vpn_test.sh - 72a1d51d88d2c0b929060d873c3b9e333f58da838051d6c5c983edac1015586c In srv6_end_next_csid_l3vpn_test.sh line 340: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_end_next_csid_l3vpn_test.sh line 432: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 435: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 467: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 526: printf "${out}" ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_next_csid_l3vpn_test.sh line 533: printf "${LCNODEFUNC_FMT}" "${nodeid}" ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_next_csid_l3vpn_test.sh line 563: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 635: eval rtsrc_nsname=\${$(get_rtname "${src}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 636: eval rtdst_nsname=\${$(get_rtname "${dst}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 711: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 712: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 842: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 865: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 877: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_next_csid_l3vpn_test.sh line 973: encap seg6local action End flavors next-csid ${layout} \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: encap seg6local action End flavors next-csid "${layout}" \ In srv6_end_next_csid_l3vpn_test.sh line 987: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... Checking tools/testing/selftests/net/srv6_end_x_next_csid_l3vpn_test.sh - 21b8652cd0a18be17cc3cabab36507a7fb38dd6981fc559d176a1ec430d13733 In srv6_end_x_next_csid_l3vpn_test.sh line 385: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_end_x_next_csid_l3vpn_test.sh line 444: eval nsname=\${$(get_rtname "${rtid}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 482: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 485: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 517: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 574: printf "${out}" ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_x_next_csid_l3vpn_test.sh line 581: printf "${LCNODEFUNC_FMT}" "${nodeid}" ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In srv6_end_x_next_csid_l3vpn_test.sh line 604: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 623: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 644: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 679: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 722: eval rtsrc_nsname=\${$(get_rtname "${src}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 723: eval rtdst_nsname=\${$(get_rtname "${dst}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 798: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 799: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 936: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 959: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 971: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_end_x_next_csid_l3vpn_test.sh line 1089: flavors next-csid ${layout} \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flavors next-csid "${layout}" \ In srv6_end_x_next_csid_l3vpn_test.sh line 1103: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... Checking tools/testing/selftests/net/srv6_hencap_red_l3vpn_test.sh - 27236f866c8cc6379746c47ffb7d17df227c837c6c9d6d5ef787820c50d56b7a In srv6_hencap_red_l3vpn_test.sh line 212: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hencap_red_l3vpn_test.sh line 303: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 306: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 338: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 369: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 435: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 482: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 483: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 617: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 640: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 652: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 778: for k in 0 1; do ^-^ SC2034 (warning): k appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2034 -- k appears unused. Verify use (or ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/net/srv6_hl2encap_red_l2vpn_test.sh - fef07094a5dbfa1ba688e02c76977ac8965209102cd45098ccf55d7d82988ce9 In srv6_hl2encap_red_l2vpn_test.sh line 163: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hl2encap_red_l2vpn_test.sh line 255: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 258: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 290: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 324: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 374: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 413: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 430: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 431: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 470: eval nsname=\${${nodename}} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. Did you mean: eval nsname=\${"${nodename}"} In srv6_hl2encap_red_l2vpn_test.sh line 494: eval hssrc_name=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 609: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 632: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hl2encap_red_l2vpn_test.sh line 644: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...