pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.OuXITJURHN and /tmp/tmp.T2pl5KI1Z6 Tree base: 09d2920a915b ("net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw") Now at: 7e2af4489423 ("selftests: drv-net: Add test for devlink-rate traffic class bandwidth distribution") ====== Checking before the patch ====== ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 3.33/10, +0.76) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module py tools/testing/selftests/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) ------------------------------------------------------------------ Your code has been rated at 8.57/10 (previous run: 3.33/10, +5.24) ************* Module py.ynl tools/testing/selftests/net/lib/py/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ynl.py:34:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:34:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:40:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:40:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:45:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:45:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:50:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:50:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:55:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:55:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:16:8: W0611: Unused NlError imported from net.lib.ynl.pyynl.lib (unused-import) ------------------------------------------------------------------ Your code has been rated at 6.47/10 (previous run: 6.22/10, +0.25) ====== Checking the tree with the patch ====== ------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 9.76/10, +0.24) ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 8.57/10, -4.48) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module py tools/testing/selftests/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) ------------------------------------------------------------------ Your code has been rated at 8.57/10 (previous run: 3.33/10, +5.24) ************* Module py.ynl tools/testing/selftests/net/lib/py/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ynl.py:34:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:34:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:40:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:40:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:45:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:45:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:50:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:50:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:55:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:55:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:60:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ynl.py:60:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/testing/selftests/net/lib/py/ynl.py:16:8: W0611: Unused NlError imported from net.lib.ynl.pyynl.lib (unused-import) ------------------------------------------------------------------ Your code has been rated at 6.22/10 (previous run: 6.47/10, -0.25)