CHECK: Please use a blank line after function/struct/union/enum declarations #284: FILE: include/uapi/linux/openvswitch.h:949: +}; +#define OVS_SOCK_TRY_ATTR_MAX (__OVS_SOCK_TRY_ATTR_MAX - 1) WARNING: Block comments use a trailing */ on a separate line #309: FILE: include/uapi/linux/openvswitch.h:1061: + * the provided action list. */ WARNING: Block comments use a trailing */ on a separate line #311: FILE: include/uapi/linux/openvswitch.h:1063: + * the key's 5-tuple details. */ WARNING: Block comments should align the * on each line #311: FILE: include/uapi/linux/openvswitch.h:1063: + OVS_ACTION_ATTR_SOCK_TUPLE, /* Sets the socket map criteria to use + * the key's 5-tuple details. */ WARNING: line length of 84 exceeds 80 columns #313: FILE: include/uapi/linux/openvswitch.h:1065: + * and if possible tries to find a socket. If WARNING: line length of 83 exceeds 80 columns #314: FILE: include/uapi/linux/openvswitch.h:1066: + * found, take a reference to the socket, and WARNING: line length of 83 exceeds 80 columns #315: FILE: include/uapi/linux/openvswitch.h:1067: + * populate the map with the last loaded sock WARNING: line length of 84 exceeds 80 columns #316: FILE: include/uapi/linux/openvswitch.h:1068: + * tuple as a key, and the socket as value */ WARNING: Block comments use a trailing */ on a separate line #316: FILE: include/uapi/linux/openvswitch.h:1068: + * tuple as a key, and the socket as value */ WARNING: line length of 82 exceeds 80 columns #320: FILE: include/uapi/linux/openvswitch.h:1072: + * and keep for the lifetime of the flow. */ WARNING: Block comments use a trailing */ on a separate line #320: FILE: include/uapi/linux/openvswitch.h:1072: + * and keep for the lifetime of the flow. */ WARNING: line length of 84 exceeds 80 columns #386: FILE: net/openvswitch/actions.c:1332: +static bool ovs_skbuff_validate_for_sockmap(struct sk_buff *skb, unsigned int *hlen) WARNING: line length of 81 exceeds 80 columns #676: FILE: net/openvswitch/actions.c:1827: + err = execute_ovs_add_sock(dp, skb, key, nla_get_u32(a)); WARNING: line length of 81 exceeds 80 columns #716: FILE: net/openvswitch/datapath.h:90: + __be32 src; /* IP4 source address. */ WARNING: line length of 86 exceeds 80 columns #717: FILE: net/openvswitch/datapath.h:91: + __be32 dst; /* IP4 destination address. */ WARNING: line length of 89 exceeds 80 columns #720: FILE: net/openvswitch/datapath.h:94: + struct in6_addr src; /* IP6 source address. */ WARNING: line length of 94 exceeds 80 columns #721: FILE: net/openvswitch/datapath.h:95: + struct in6_addr dst; /* IP6 destination address. */ WARNING: line length of 84 exceeds 80 columns #722: FILE: net/openvswitch/datapath.h:96: + __be32 label; /* IP6 flow labe. */ WARNING: line length of 84 exceeds 80 columns #928: FILE: net/openvswitch/flow_netlink.c:3270: + &tcp_hashinfo.ehash[i].chain, ERROR: trailing statements should be on next line #935: FILE: net/openvswitch/flow_netlink.c:3277: + if (sk->sk_socket && sk->sk_socket->file && [...] + osk.socket_inode)) { CHECK: Alignment should match open parenthesis #963: FILE: net/openvswitch/flow_netlink.c:3305: + nested_acts_start = add_nested_action_start(sfa, + OVS_SOCK_FWD_ATTR_ACTIONS_IF_FAIL, log); WARNING: line length of 85 exceeds 80 columns #993: FILE: net/openvswitch/flow_netlink.c:3342: + static const struct nla_policy sock_try_policy[OVS_SOCK_TRY_ATTR_MAX + 1] = { total: 1 errors, 19 warnings, 2 checks, 756 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e8724258c703 ("net: openvswitch: Inroduce a light-weight socket map concept.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.