WARNING: line length of 91 exceeds 80 columns #148: FILE: drivers/mfd/nct6694.c:61: +static int nct6694_response_err_handling(struct nct6694 *nct6694, unsigned char err_status) WARNING: line length of 97 exceeds 80 columns #184: FILE: drivers/mfd/nct6694.c:97: +int nct6694_read_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf) WARNING: line length of 94 exceeds 80 columns #196: FILE: drivers/mfd/nct6694.c:109: + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), &msg->cmd_header, WARNING: line length of 98 exceeds 80 columns #202: FILE: drivers/mfd/nct6694.c:115: + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), &msg->response_header, WARNING: line length of 83 exceeds 80 columns #209: FILE: drivers/mfd/nct6694.c:122: + le16_to_cpu(cmd_hd->len), &rx_len, NCT6694_URB_TIMEOUT); WARNING: line length of 98 exceeds 80 columns #234: FILE: drivers/mfd/nct6694.c:147: +int nct6694_write_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf) WARNING: line length of 94 exceeds 80 columns #246: FILE: drivers/mfd/nct6694.c:159: + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), &msg->cmd_header, WARNING: line length of 81 exceeds 80 columns #252: FILE: drivers/mfd/nct6694.c:165: + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), buf, WARNING: line length of 83 exceeds 80 columns #253: FILE: drivers/mfd/nct6694.c:166: + le16_to_cpu(cmd_hd->len), &tx_len, NCT6694_URB_TIMEOUT); WARNING: line length of 98 exceeds 80 columns #258: FILE: drivers/mfd/nct6694.c:171: + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), &msg->response_header, WARNING: line length of 83 exceeds 80 columns #265: FILE: drivers/mfd/nct6694.c:178: + le16_to_cpu(cmd_hd->len), &rx_len, NCT6694_URB_TIMEOUT); WARNING: line length of 92 exceeds 80 columns #309: FILE: drivers/mfd/nct6694.c:222: + dev_warn(nct6694->dev, "Failed to resubmit urb, status %pe", ERR_PTR(ret)); WARNING: line length of 93 exceeds 80 columns #341: FILE: drivers/mfd/nct6694.c:254: +static int nct6694_irq_domain_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) WARNING: line length of 88 exceeds 80 columns #376: FILE: drivers/mfd/nct6694.c:289: + nct6694->usb_msg = devm_kzalloc(dev, sizeof(union nct6694_usb_msg), GFP_KERNEL); WARNING: line length of 90 exceeds 80 columns #380: FILE: drivers/mfd/nct6694.c:293: + nct6694->int_buffer = devm_kzalloc(dev, sizeof(*nct6694->int_buffer), GFP_KERNEL); WARNING: line length of 92 exceeds 80 columns #418: FILE: drivers/mfd/nct6694.c:331: + usb_fill_int_urb(nct6694->int_in_urb, udev, usb_rcvintpipe(udev, NCT6694_INT_IN_EP), WARNING: line length of 93 exceeds 80 columns #419: FILE: drivers/mfd/nct6694.c:332: + nct6694->int_buffer, sizeof(*nct6694->int_buffer), usb_int_callback, WARNING: line length of 83 exceeds 80 columns #428: FILE: drivers/mfd/nct6694.c:341: + ret = mfd_add_hotplug_devices(dev, nct6694_devs, ARRAY_SIZE(nct6694_devs)); WARNING: line length of 99 exceeds 80 columns #462: FILE: drivers/mfd/nct6694.c:375: + { USB_DEVICE_AND_INTERFACE_INFO(NCT6694_VENDOR_ID, NCT6694_PRODUCT_ID, 0xFF, 0x00, 0x00) }, CHECK: struct mutex definition without comment #573: FILE: include/linux/mfd/nct6694.h:90: + struct mutex access_lock; CHECK: spinlock_t definition without comment #574: FILE: include/linux/mfd/nct6694.h:91: + spinlock_t irq_lock; WARNING: line length of 98 exceeds 80 columns #582: FILE: include/linux/mfd/nct6694.h:99: +int nct6694_read_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf); WARNING: line length of 99 exceeds 80 columns #583: FILE: include/linux/mfd/nct6694.h:100: +int nct6694_write_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf); total: 0 errors, 21 warnings, 2 checks, 533 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ecf828670022 ("mfd: Add core driver for Nuvoton NCT6694") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 2 checks, 533 lines checked