WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100755

WARNING: line length of 92 exceeds 80 columns
#146: FILE: tools/testing/selftests/net/test_neigh.sh:82:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#147: FILE: tools/testing/selftests/net/test_neigh.sh:83:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 95 exceeds 80 columns
#158: FILE: tools/testing/selftests/net/test_neigh.sh:94:
+	check_fail $? "Managed to add an entry with \"extern_valid\" flag and an invalid state"

WARNING: line length of 96 exceeds 80 columns
#167: FILE: tools/testing/selftests/net/test_neigh.sh:103:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 91 exceeds 80 columns
#168: FILE: tools/testing/selftests/net/test_neigh.sh:104:
+	check_fail $? "Managed to add an entry with \"extern_valid\" flag and \"use\" flag"

WARNING: line length of 96 exceeds 80 columns
#177: FILE: tools/testing/selftests/net/test_neigh.sh:113:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#178: FILE: tools/testing/selftests/net/test_neigh.sh:114:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 83 exceeds 80 columns
#180: FILE: tools/testing/selftests/net/test_neigh.sh:116:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0"

WARNING: line length of 81 exceeds 80 columns
#181: FILE: tools/testing/selftests/net/test_neigh.sh:117:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 82 exceeds 80 columns
#182: FILE: tools/testing/selftests/net/test_neigh.sh:118:
+	check_fail $? "Did not manage to clear \"extern_valid\" flag with replace"

WARNING: line length of 92 exceeds 80 columns
#191: FILE: tools/testing/selftests/net/test_neigh.sh:127:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 104 exceeds 80 columns
#192: FILE: tools/testing/selftests/net/test_neigh.sh:128:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid managed"

WARNING: line length of 99 exceeds 80 columns
#193: FILE: tools/testing/selftests/net/test_neigh.sh:129:
+	check_err $? "Did not manage to add \"managed\" flag to an existing \"extern_valid\" entry"

WARNING: line length of 85 exceeds 80 columns
#195: FILE: tools/testing/selftests/net/test_neigh.sh:131:
+	log_test "$af_str \"extern_valid\" flag: Replace entry with \"managed\" flag"

WARNING: line length of 92 exceeds 80 columns
#202: FILE: tools/testing/selftests/net/test_neigh.sh:138:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 83 exceeds 80 columns
#203: FILE: tools/testing/selftests/net/test_neigh.sh:139:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr nud none dev veth0 extern_valid"

WARNING: line length of 99 exceeds 80 columns
#204: FILE: tools/testing/selftests/net/test_neigh.sh:140:
+	check_fail $? "Managed to replace an entry with \"extern_valid\" flag and an invalid state"

WARNING: line length of 92 exceeds 80 columns
#213: FILE: tools/testing/selftests/net/test_neigh.sh:149:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 92 exceeds 80 columns
#226: FILE: tools/testing/selftests/net/test_neigh.sh:162:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 103 exceeds 80 columns
#242: FILE: tools/testing/selftests/net/test_neigh.sh:178:
+	delay_probe=$(ip -n "$ns1" -j ntable show dev veth0 name "$tbl_name" | jq '.[]["delay_probe"]')

WARNING: line length of 92 exceeds 80 columns
#244: FILE: tools/testing/selftests/net/test_neigh.sh:180:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 100 exceeds 80 columns
#245: FILE: tools/testing/selftests/net/test_neigh.sh:181:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 81 exceeds 80 columns
#249: FILE: tools/testing/selftests/net/test_neigh.sh:185:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 107 exceeds 80 columns
#250: FILE: tools/testing/selftests/net/test_neigh.sh:186:
+	check_err $? "Entry did not maintain \"extern_valid\" flag after transition to \"reachable\" state"

WARNING: line length of 83 exceeds 80 columns
#252: FILE: tools/testing/selftests/net/test_neigh.sh:188:
+	log_test "$af_str \"extern_valid\" flag: Transition to \"reachable\" state"

WARNING: line length of 88 exceeds 80 columns
#267: FILE: tools/testing/selftests/net/test_neigh.sh:203:
+	run_cmd "tc -n $ns2 filter add dev veth1 ingress proto all matchall action drop"

WARNING: line length of 92 exceeds 80 columns
#268: FILE: tools/testing/selftests/net/test_neigh.sh:204:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 100 exceeds 80 columns
#269: FILE: tools/testing/selftests/net/test_neigh.sh:205:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 100 exceeds 80 columns
#270: FILE: tools/testing/selftests/net/test_neigh.sh:206:
+	retrans_time=$(ip -n "$ns1" -j ntable show dev veth0 name "$tbl_name" | jq '.[]["retrans"]')

WARNING: line length of 105 exceeds 80 columns
#271: FILE: tools/testing/selftests/net/test_neigh.sh:207:
+	ucast_probes=$(ip -n "$ns1" -j ntable show dev veth0 name "$tbl_name" | jq '.[]["ucast_probes"]')

WARNING: line length of 101 exceeds 80 columns
#272: FILE: tools/testing/selftests/net/test_neigh.sh:208:
+	app_probes=$(ip -n "$ns1" -j ntable show dev veth0 name "$tbl_name" | jq '.[]["app_probes"]')

WARNING: line length of 109 exceeds 80 columns
#273: FILE: tools/testing/selftests/net/test_neigh.sh:209:
+	mcast_reprobes=$(ip -n "$ns1" -j ntable show dev veth0 name "$tbl_name" | jq '.[]["mcast_reprobes"]')

WARNING: line length of 92 exceeds 80 columns
#274: FILE: tools/testing/selftests/net/test_neigh.sh:210:
+	delay=$((delay_probe + (ucast_probes + app_probes + mcast_reprobes) * retrans_time))

WARNING: line length of 81 exceeds 80 columns
#278: FILE: tools/testing/selftests/net/test_neigh.sh:214:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 102 exceeds 80 columns
#279: FILE: tools/testing/selftests/net/test_neigh.sh:215:
+	check_err $? "Entry did not maintain \"extern_valid\" flag after returning to \"stale\" state"

WARNING: line length of 88 exceeds 80 columns
#280: FILE: tools/testing/selftests/net/test_neigh.sh:216:
+	probes=$(ip -n "$ns1" -j -s neigh get "$ip_addr" dev veth0 | jq '.[]["probes"]')

WARNING: line length of 84 exceeds 80 columns
#285: FILE: tools/testing/selftests/net/test_neigh.sh:221:
+	log_test "$af_str \"extern_valid\" flag: Transition back to \"stale\" state"

WARNING: line length of 109 exceeds 80 columns
#308: FILE: tools/testing/selftests/net/test_neigh.sh:244:
+	orig_thresh1=$(ip -j ntable show name "$tbl_name" | jq '.[] | select(has("thresh1")) | .["thresh1"]')

WARNING: line length of 109 exceeds 80 columns
#309: FILE: tools/testing/selftests/net/test_neigh.sh:245:
+	orig_thresh2=$(ip -j ntable show name "$tbl_name" | jq '.[] | select(has("thresh2")) | .["thresh2"]')

WARNING: line length of 109 exceeds 80 columns
#310: FILE: tools/testing/selftests/net/test_neigh.sh:246:
+	orig_thresh3=$(ip -j ntable show name "$tbl_name" | jq '.[] | select(has("thresh3")) | .["thresh3"]')

WARNING: line length of 92 exceeds 80 columns
#312: FILE: tools/testing/selftests/net/test_neigh.sh:248:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#313: FILE: tools/testing/selftests/net/test_neigh.sh:249:
+	run_cmd "ip -n $ns1 neigh add ${subnet}3 lladdr $mac nud stale dev veth0"

WARNING: line length of 131 exceeds 80 columns
#315: FILE: tools/testing/selftests/net/test_neigh.sh:251:
+	forced_gc_runs_t0=$(ip -j -s ntable show name "$tbl_name" | jq '.[] | select(has("forced_gc_runs")) | .["forced_gc_runs"]')

WARNING: line length of 85 exceeds 80 columns
#317: FILE: tools/testing/selftests/net/test_neigh.sh:253:
+		run_cmd "ip -n $ns1 neigh add ${subnet}$((i + 4)) nud none dev veth0"

WARNING: line length of 131 exceeds 80 columns
#319: FILE: tools/testing/selftests/net/test_neigh.sh:255:
+	forced_gc_runs_t1=$(ip -j -s ntable show name "$tbl_name" | jq '.[] | select(has("forced_gc_runs")) | .["forced_gc_runs"]')

WARNING: line length of 81 exceeds 80 columns
#323: FILE: tools/testing/selftests/net/test_neigh.sh:259:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 97 exceeds 80 columns
#324: FILE: tools/testing/selftests/net/test_neigh.sh:260:
+	check_err $? "Entry with \"extern_valid\" flag did not survive forced garbage collection"

WARNING: line length of 94 exceeds 80 columns
#326: FILE: tools/testing/selftests/net/test_neigh.sh:262:
+	check_fail $? "Entry without \"extern_valid\" flag survived forced garbage collection"

WARNING: line length of 115 exceeds 80 columns
#330: FILE: tools/testing/selftests/net/test_neigh.sh:266:
+	run_cmd "ip ntable change name $tbl_name thresh3 $orig_thresh3 thresh2 $orig_thresh2 thresh1 $orig_thresh1"

WARNING: line length of 109 exceeds 80 columns
#352: FILE: tools/testing/selftests/net/test_neigh.sh:288:
+	orig_thresh1=$(ip -j ntable show name "$tbl_name" | jq '.[] | select(has("thresh1")) | .["thresh1"]')

WARNING: line length of 123 exceeds 80 columns
#353: FILE: tools/testing/selftests/net/test_neigh.sh:289:
+	orig_base_reachable=$(ip -j ntable show name "$tbl_name" | jq '.[] | select(has("thresh1")) | .["base_reachable"]')

WARNING: line length of 81 exceeds 80 columns
#354: FILE: tools/testing/selftests/net/test_neigh.sh:290:
+	run_cmd "ip ntable change name $tbl_name thresh1 10 base_reachable 10000"

WARNING: line length of 102 exceeds 80 columns
#355: FILE: tools/testing/selftests/net/test_neigh.sh:291:
+	orig_gc_stale=$(ip -n "$ns1" -j ntable show name "$tbl_name" dev veth0 | jq '.[]["gc_stale"]')

WARNING: line length of 81 exceeds 80 columns
#356: FILE: tools/testing/selftests/net/test_neigh.sh:292:
+	run_cmd "ip -n $ns1 ntable change name $tbl_name dev veth0 gc_stale 5000"

WARNING: line length of 92 exceeds 80 columns
#359: FILE: tools/testing/selftests/net/test_neigh.sh:295:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#360: FILE: tools/testing/selftests/net/test_neigh.sh:296:
+	run_cmd "ip -n $ns1 neigh add ${subnet}3 lladdr $mac nud stale dev veth0"

WARNING: line length of 85 exceeds 80 columns
#362: FILE: tools/testing/selftests/net/test_neigh.sh:298:
+		run_cmd "ip -n $ns1 neigh add ${subnet}$((i + 4)) nud none dev veth0"

WARNING: line length of 137 exceeds 80 columns
#364: FILE: tools/testing/selftests/net/test_neigh.sh:300:
+	periodic_gc_runs_t0=$(ip -j -s ntable show name "$tbl_name" | jq '.[] | select(has("periodic_gc_runs")) | .["periodic_gc_runs"]')

WARNING: line length of 137 exceeds 80 columns
#366: FILE: tools/testing/selftests/net/test_neigh.sh:302:
+	periodic_gc_runs_t1=$(ip -j -s ntable show name "$tbl_name" | jq '.[] | select(has("periodic_gc_runs")) | .["periodic_gc_runs"]')

WARNING: line length of 81 exceeds 80 columns
#369: FILE: tools/testing/selftests/net/test_neigh.sh:305:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 99 exceeds 80 columns
#370: FILE: tools/testing/selftests/net/test_neigh.sh:306:
+	check_err $? "Entry with \"extern_valid\" flag did not survive periodic garbage collection"

WARNING: line length of 96 exceeds 80 columns
#372: FILE: tools/testing/selftests/net/test_neigh.sh:308:
+	check_fail $? "Entry without \"extern_valid\" flag survived periodic garbage collection"

WARNING: line length of 91 exceeds 80 columns
#376: FILE: tools/testing/selftests/net/test_neigh.sh:312:
+	run_cmd "ip -n $ns1 ntable change name $tbl_name dev veth0 gc_stale $orig_gc_stale"

WARNING: line length of 107 exceeds 80 columns
#377: FILE: tools/testing/selftests/net/test_neigh.sh:313:
+	run_cmd "ip ntable change name $tbl_name thresh1 $orig_thresh1 base_reachable $orig_base_reachable"

total: 0 errors, 65 warnings, 0 checks, 373 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 365be7e6bd72 ("selftests: net: Add a selftest for externally validated neighbor entries") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 65 warnings, 0 checks, 373 lines checked