====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.NEzdcdrVsg 2025-06-25 16:00:03.453087575 -0700 +++ /tmp/tmp.0U6g2Vs6xX 2025-06-25 16:00:03.979084244 -0700 @@ -851 +851,29 @@ -In devlink.sh line 615: +In devlink.sh line 625: + rate_attr_set $handle tc-bw "$tc_bw_str" + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + rate_attr_set "$handle" tc-bw "$tc_bw_str" + + +In devlink.sh line 631: + local debug_value=$(cat $debug_file/tc${tc}_bw) + ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local debug_value=$(cat "$debug_file"/tc"${tc}"_bw) + + +In devlink.sh line 640: + local api_value=$(rate_attr_get $handle tc_$tc) + ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local api_value=$(rate_attr_get "$handle" tc_"$tc") + + +In devlink.sh line 653: @@ -859 +887 @@ -In devlink.sh line 622: +In devlink.sh line 660: @@ -867 +895 @@ -In devlink.sh line 627: +In devlink.sh line 665: @@ -872 +900 @@ -In devlink.sh line 629: +In devlink.sh line 667: @@ -881 +909 @@ -In devlink.sh line 630: +In devlink.sh line 668: @@ -889 +917 @@ -In devlink.sh line 631: +In devlink.sh line 669: @@ -899 +927 @@ -In devlink.sh line 632: +In devlink.sh line 670: @@ -909 +937 @@ -In devlink.sh line 639: +In devlink.sh line 677: @@ -918 +946 @@ -In devlink.sh line 640: +In devlink.sh line 678: @@ -927 +955 @@ -In devlink.sh line 641: +In devlink.sh line 679: @@ -932 +960 @@ -In devlink.sh line 647: +In devlink.sh line 685: @@ -941 +969 @@ -In devlink.sh line 648: +In devlink.sh line 686: @@ -950 +978 @@ -In devlink.sh line 649: +In devlink.sh line 687: @@ -955 +983,18 @@ -In devlink.sh line 657: +In devlink.sh line 693: + rate_attr_tc_bw_check $r_obj "$tc_bw" \ + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + rate_attr_tc_bw_check "$r_obj" "$tc_bw" \ + + +In devlink.sh line 694: + $DEBUGFS_DIR/ports/${r_obj##*/} + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "$DEBUGFS_DIR"/ports/"${r_obj##*/}" + + +In devlink.sh line 702: @@ -965 +1010 @@ -In devlink.sh line 658: +In devlink.sh line 703: @@ -973 +1018 @@ -In devlink.sh line 662: +In devlink.sh line 707: @@ -982 +1027 @@ -In devlink.sh line 663: +In devlink.sh line 708: @@ -991 +1036 @@ -In devlink.sh line 666: +In devlink.sh line 711: @@ -1000 +1045 @@ -In devlink.sh line 667: +In devlink.sh line 712: @@ -1009 +1054,18 @@ -In devlink.sh line 671: +In devlink.sh line 716: + rate_attr_tc_bw_check $node1 "$tc_bw" \ + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + rate_attr_tc_bw_check "$node1" "$tc_bw" \ + + +In devlink.sh line 717: + $DEBUGFS_DIR/rate_nodes/${node1##*/} + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}" + + +In devlink.sh line 722: @@ -1019 +1081 @@ -In devlink.sh line 672: +In devlink.sh line 723: @@ -1027 +1089 @@ -In devlink.sh line 680: +In devlink.sh line 731: @@ -1036 +1098 @@ -In devlink.sh line 681: +In devlink.sh line 732: @@ -1045 +1107 @@ -In devlink.sh line 688: +In devlink.sh line 739: @@ -1054 +1116 @@ -In devlink.sh line 689: +In devlink.sh line 740: @@ -1063 +1125 @@ -In devlink.sh line 720: +In devlink.sh line 771: