WARNING: line length of 92 exceeds 80 columns #58: FILE: net/xfrm/xfrm_state.c:1714: +static struct xfrm_state *xfrm_state_lookup_spi_proto(struct net *net, __be32 spi, u8 proto) WARNING: please, no spaces at the start of a line #60: FILE: net/xfrm/xfrm_state.c:1716: + struct xfrm_state *x;$ WARNING: please, no spaces at the start of a line #61: FILE: net/xfrm/xfrm_state.c:1717: + unsigned int i;$ WARNING: please, no spaces at the start of a line #63: FILE: net/xfrm/xfrm_state.c:1719: + rcu_read_lock();$ WARNING: please, no spaces at the start of a line #65: FILE: net/xfrm/xfrm_state.c:1721: + for (i = 0; i <= net->xfrm.state_hmask; i++) {$ ERROR: code indent should use tabs where possible #66: FILE: net/xfrm/xfrm_state.c:1722: + hlist_for_each_entry_rcu(x, &net->xfrm.state_byspi[i], byspi) {$ WARNING: please, no spaces at the start of a line #66: FILE: net/xfrm/xfrm_state.c:1722: + hlist_for_each_entry_rcu(x, &net->xfrm.state_byspi[i], byspi) {$ WARNING: suspect code indent for conditional statements (8, 12) #66: FILE: net/xfrm/xfrm_state.c:1722: + hlist_for_each_entry_rcu(x, &net->xfrm.state_byspi[i], byspi) { + if (x->id.spi == spi && x->id.proto == proto) { ERROR: code indent should use tabs where possible #67: FILE: net/xfrm/xfrm_state.c:1723: + if (x->id.spi == spi && x->id.proto == proto) {$ WARNING: please, no spaces at the start of a line #67: FILE: net/xfrm/xfrm_state.c:1723: + if (x->id.spi == spi && x->id.proto == proto) {$ ERROR: code indent should use tabs where possible #68: FILE: net/xfrm/xfrm_state.c:1724: + if (!xfrm_state_hold_rcu(x))$ WARNING: please, no spaces at the start of a line #68: FILE: net/xfrm/xfrm_state.c:1724: + if (!xfrm_state_hold_rcu(x))$ WARNING: suspect code indent for conditional statements (16, 20) #68: FILE: net/xfrm/xfrm_state.c:1724: + if (!xfrm_state_hold_rcu(x)) + continue; ERROR: code indent should use tabs where possible #69: FILE: net/xfrm/xfrm_state.c:1725: + continue;$ WARNING: please, no spaces at the start of a line #69: FILE: net/xfrm/xfrm_state.c:1725: + continue;$ ERROR: code indent should use tabs where possible #70: FILE: net/xfrm/xfrm_state.c:1726: + rcu_read_unlock();$ WARNING: please, no spaces at the start of a line #70: FILE: net/xfrm/xfrm_state.c:1726: + rcu_read_unlock();$ ERROR: code indent should use tabs where possible #71: FILE: net/xfrm/xfrm_state.c:1727: + return x;$ WARNING: please, no spaces at the start of a line #71: FILE: net/xfrm/xfrm_state.c:1727: + return x;$ ERROR: code indent should use tabs where possible #72: FILE: net/xfrm/xfrm_state.c:1728: + }$ WARNING: please, no spaces at the start of a line #72: FILE: net/xfrm/xfrm_state.c:1728: + }$ ERROR: code indent should use tabs where possible #73: FILE: net/xfrm/xfrm_state.c:1729: + }$ WARNING: please, no spaces at the start of a line #73: FILE: net/xfrm/xfrm_state.c:1729: + }$ WARNING: please, no spaces at the start of a line #74: FILE: net/xfrm/xfrm_state.c:1730: + }$ WARNING: please, no spaces at the start of a line #76: FILE: net/xfrm/xfrm_state.c:1732: + rcu_read_unlock();$ WARNING: please, no spaces at the start of a line #77: FILE: net/xfrm/xfrm_state.c:1733: + return NULL;$ WARNING: line length of 84 exceeds 80 columns #121: FILE: net/xfrm/xfrm_state.c:2596: + u32 spi = (low == high) ? low : get_random_u32_inclusive(low, high); WARNING: Missing a blank line after declarations #122: FILE: net/xfrm/xfrm_state.c:2597: + u32 spi = (low == high) ? low : get_random_u32_inclusive(low, high); + newspi = htonl(spi); WARNING: line length of 99 exceeds 80 columns #132: FILE: net/xfrm/xfrm_state.c:2603: + h = xfrm_spi_hash(net, &x->id.daddr, newspi, x->id.proto, x->props.family); WARNING: line length of 100 exceeds 80 columns #133: FILE: net/xfrm/xfrm_state.c:2604: + XFRM_STATE_INSERT(byspi, &x->byspi, net->xfrm.state_byspi + h, x->xso.type); ERROR: code indent should use tabs where possible #137: FILE: net/xfrm/xfrm_state.c:2608: + }$ WARNING: please, no spaces at the start of a line #137: FILE: net/xfrm/xfrm_state.c:2608: + }$ ERROR: code indent should use tabs where possible #147: FILE: net/xfrm/xfrm_state.c:2615: + }$ WARNING: please, no spaces at the start of a line #147: FILE: net/xfrm/xfrm_state.c:2615: + }$ WARNING: line length of 82 exceeds 80 columns #154: FILE: net/xfrm/xfrm_state.c:2622: + NL_SET_ERR_MSG(extack, "No SPI available in the requested range"); total: 10 errors, 25 warnings, 0 checks, 102 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit d252fc5696ca ("xfrm: Duplicate SPI Handling") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.