pylint 3.3.7
astroid 3.3.8
Python 3.13.3 (main, Apr 22 2025, 00:00:00) [GCC 15.0.1 20250418 (Red Hat 15.0.1-0)]
Redirect to /tmp/tmp.RMVEyBS0jb and /tmp/tmp.Yj7GQwDnSf
Tree base:
4f4040ea5d3e ("net: ti: icssg-prueth: Add prp offload support to ICSSG driver")
Now at:
7ec8f4c057c0 ("selftests: drv-net: stats: fix pylint issues")
 ====== Checking before the patch ======
************* Module stats
tools/testing/selftests/drivers/net/stats.py:1:0: C0114: Missing module docstring (missing-module-docstring)
tools/testing/selftests/drivers/net/stats.py:7:0: E0611: No name 'ksft_run' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:7:0: E0611: No name 'ksft_exit' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_ge' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_eq' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_is' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_in' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_lt' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_true' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:8:0: E0611: No name 'ksft_raises' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:10:0: E0611: No name 'ksft_disruptive' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'EthtoolFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'NetdevFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'RtnlFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'NlError' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:13:0: E0611: No name 'defer' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:20:0: C0116: Missing function or method docstring (missing-function-docstring)
tools/testing/selftests/drivers/net/stats.py:21:4: W0602: Using global for 'ethnl' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:27:12: W0707: Consider explicitly re-raising using 'raise KsftXfailEx('pause not supported by the device') from e' (raise-missing-from)
tools/testing/selftests/drivers/net/stats.py:35:0: C0116: Missing function or method docstring (missing-function-docstring)
tools/testing/selftests/drivers/net/stats.py:36:4: W0602: Using global for 'ethnl' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:42:12: W0707: Consider explicitly re-raising using 'raise KsftXfailEx('FEC not supported by the device') from e' (raise-missing-from)
tools/testing/selftests/drivers/net/stats.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)
tools/testing/selftests/drivers/net/stats.py:51:4: W0602: Using global for 'netfam' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:51:4: W0602: Using global for 'rtnl' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:54:8: W0602: Using global for 'netfam' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:53:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
tools/testing/selftests/drivers/net/stats.py:80:12: W0719: Raising too general exception: Exception (broad-exception-raised)
tools/testing/selftests/drivers/net/stats.py:83:12: W0719: Raising too general exception: Exception (broad-exception-raised)
tools/testing/selftests/drivers/net/stats.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)
tools/testing/selftests/drivers/net/stats.py:87:4: W0602: Using global for 'netfam' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:88:4: W0602: Using global for 'rtnl' but no assignment is done (global-variable-not-assigned)
tools/testing/selftests/drivers/net/stats.py:96:19: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
tools/testing/selftests/drivers/net/stats.py:148:20: R1718: Consider using a set comprehension (consider-using-set-comprehension)
tools/testing/selftests/drivers/net/stats.py:86:21: W0613: Unused argument 'cfg' (unused-argument)
tools/testing/selftests/drivers/net/stats.py:160:0: C0116: Missing function or method docstring (missing-function-docstring)
tools/testing/selftests/drivers/net/stats.py:165:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('qstats not supported by the device') from e' (raise-missing-from)
tools/testing/selftests/drivers/net/stats.py:172:11: W0612: Unused variable 'v' (unused-variable)
tools/testing/selftests/drivers/net/stats.py:265:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 4.31/10

 ====== Checking the tree with the patch ======
************* Module stats
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'ksft_run' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:11:0: E0611: No name 'ksft_exit' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_ge' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_eq' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_is' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_in' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_lt' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_true' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:12:0: E0611: No name 'ksft_raises' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:13:0: E0611: No name 'KsftFailEx' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:14:0: E0611: No name 'ksft_disruptive' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:15:0: E0611: No name 'EthtoolFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:15:0: E0611: No name 'NetdevFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:15:0: E0611: No name 'RtnlFamily' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:15:0: E0611: No name 'NlError' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:17:0: E0611: No name 'defer' in module 'lib.py' (no-name-in-module)
tools/testing/selftests/drivers/net/stats.py:98:21: W0613: Unused argument 'cfg' (unused-argument)

------------------------------------------------------------------
Your code has been rated at 5.21/10 (previous run: 4.31/10, +0.90)